gistfile1.txt

23:53 <     proller> | https://github.com/minetest/minetest/pull/895
23:59 --> sapier [~sapier@pD9E2C997.dip0.t-ipconnect.de] has joined #minetest-dev
--- Day changed Thu Aug 29 2013
00:03 <-- nore [~Nore@85-170-196-16.rev.numericable.fr] has quit (Ping timeout: 256 seconds)
00:20 <-- jojoa1997 [~jojoa1997@user-0c6t2sc.cable.mindspring.com] has quit (Quit: Leaving)
00:20 <-- Ritchie [~mira@moravik-moh.cust.sloane.cz] has quit (Quit: Konversation terminated!)
01:07 <-- EdB [~edb@85.69.144.96] has quit (Quit: Konversation terminated!)
01:40 --> jojoa1997 [~jojoa1997@user-0c6t2sc.cable.mindspring.com] has joined #minetest-dev
01:49 <-- jojoa1997 [~jojoa1997@user-0c6t2sc.cable.mindspring.com] has quit (Quit: Leaving)
02:01 --> jojoa1997 [~jojoa1997@user-0c6t2sc.cable.mindspring.com] has joined #minetest-dev
02:21 --> kaeza [~kaeza@unaffiliated/kaeza] has joined #minetest-dev
--
22:18 <     proller> | https://github.com/minetest/minetest/pull/895  https://github.com/minetest/minetest/pull/892 https://github.com/minetest/minetest/pull/883
22:18 <     proller> | https://github.com/minetest/minetest/pull/882
22:19 <     proller> | celeron55, btw, 2 weeks of asking agree - reasonable time ?
22:23 <   celeron55> | well what can i say? it doesn't matter 8)
22:24 <-- proller [~proller@2a02:6b8:0:408:a5fc:184f:1545:4d80] has quit (Ping timeout: 264 seconds)
22:26 <-- Yepoleb [~znc@phoenix.uberspace.de] has quit (Quit: Quit)
22:26 --> Yepoleb [~znc@phoenix.uberspace.de] has joined #minetest-dev
22:27 <   celeron55> | if nobody is interested, there are exactly three options: 1) talk enough to get them interested (posting links is not talking); 2) give up; 3) code more to have a more impressive bunch of stuff
22:28 <        nore> | celeron55, I use the first option with my pulls...
22:29 <   celeron55> | i recommend the first option :P
22:30 <        nore> | btw, what do you thinkof #688?
--
14:52 <     proller> | https://github.com/minetest/minetest/pull/895
14:52 <     proller> | https://github.com/minetest/minetest/pull/892
14:53 <     proller> | https://github.com/minetest/minetest/pull/882
14:53 <+      kahrl> | can you add explanations what they do, squash them and remove the merge commits?
14:54 --> PilzAdam [~PilzAdam@77-21-29-156-dynip.superkabel.de] has joined #minetest-dev
14:54 --- ChanServ sets modes [#minetest-dev +v PilzAdam]
14:54 <+      sfan5> | pitriss: why do you want to disable fog?
14:55 --> Zeg9 [~Zeg9@dec35-1-88-189-252-245.fbx.proxad.net] has joined #minetest-dev
14:55 <     proller> | kahrl, better to squash before merge, to not squash 5+ times with every founded issue
14:55 <     pitriss> | sfan5: just because i don't like it.. and disabling it by F3 every relog / server crash is bit uncomfortable
14:55 <     proller> | some of have descriopion, but i will write more
--
20:01 <     proller> | 897 895 892 882 wants too
20:02 <+      kahrl> | #930 could be made more generic, I believe
20:02 <+      kahrl> | as in allow images to take half the screen, for example
20:05 <+      kahrl> | #928 has buffer overflows
20:05 <+      kahrl> | you read a color using split() but then you don't check that there are actually 4 parts
20:07 <    BlockMen> | kahrl, so like -0.5 == half screen ? (#930)
20:08 <    BlockMen> | and you mean at #928 like here? -> https://github.com/minetest/minetest/pull/928/files#L1R1378 so checking if color.size() == 4 ?
20:10 <+      kahrl> | #930: either that or adding a bool scale_from_screen (or whatever) seems fine
20:10 <+      kahrl> | #928: exactly
20:12 <    BlockMen> | ok, gonna change that. thanks.
20:20 <+      kahrl> | proller: #895 ummm... why do you set liquid_loop_max even lower
20:20 <+      kahrl> | it should be restored to 10000 if anything
20:21 <     proller> | because transform calls more frequent
20:21 <+      kahrl> | also the default values should be tuned for normal liquids not finite liquids (because normal liquids are the default)
20:21 <     proller> | its ok for normal too
20:23 <     proller> | if queue big - transform may work 10 times per second = 5000 nodes per second
20:23 <     proller> | its better than one looong call
20:24 <     proller> | processing 10000 nodes cause stuck of server
20:25 <+      kahrl> | okay
20:31 <-- smoke_fumus [~smoke_fum@188.35.176.90] has quit (Read error: Connection reset by peer)
20:31 <+      kahrl> | proller: I'd just get rid of the whole #if 0 block here: https://github.com/proller/minetest/commit/283799333cfacc981c45222f1f373fc4704655d5#L4R1217
--
00:37 <     proller> | 897 895 892 882 !
00:39 <       kaeza> | 42
00:40 <+      hmmmm> | no idea what the wingsuit thing is about
00:40 <+      hmmmm> | i've heard some people who don't like it
00:41 <+      hmmmm> | i suppose 895 is good, i'm not entirely sure of the ramifications though
00:41 <+      hmmmm> | you tested it i trust, and it doesn't break anything?
00:42 <     proller> | you can feel winsuit only when jumping from 100+
00:42 <      sapier> | tztz complaining about mainmenu event handling when there haven't even been events when mainmenu was created ;-)
00:42 <+      hmmmm> | sapier
00:42 <+      hmmmm> | hey man i've got some questions for you
00:42 <     proller> | all is 1 month testing on sky server
00:42 <      sapier> | ok I'm here ask ;-)
00:42 <+      hmmmm> | i'm trying to add an event for changing a dropdown item but i'm not having much luck
00:43 <      sapier> | what's wrong ?
00:43 <+      hmmmm> | i have it all wired up and it's executing gotText with the CHG:itemindexhere
--
00:46 <     proller> | commit 895? next step - make one send block queue with optimizations
00:46 <      sapier> | ok your problem is at c++ side did I understanc correct?
00:46 <+      hmmmm> | sapier, I think so, yeah
00:46 <      sapier> | and the problem is no event is generated?
00:47 <+      hmmmm> | yup
00:47 <      sapier> | why did you comment s.send?
00:47 <+      hmmmm> | s.send is already set in parseDropDown
00:48 <      sapier> | ahh yes I remember dropdown is interpreted as text input field not as button
00:48 <+      hmmmm> | oh great... what does this mean?
00:49 <+      hmmmm> | where's it set? how do I change that?
00:49 <+      kahrl> | hmmmm: have you tried uncommenting the first line of engine.button_handler?
--
17:48 <     proller> | 897 895 892 882 !
17:51 --> iqualfragile [~iqualfrag@unaffiliated/iqualfragile] has joined #minetest-dev
--- Log closed Fri Sep 20 17:57:54 2013
--- Log opened Fri Sep 20 18:22:06 2013
18:22 --> thexyz [~xyz@2a01:4f8:151:8106::2] has joined #minetest-dev
18:22 --- Users 49 nicks [0 ops, 0 halfops, 5 voices, 44 normal]
18:22 --- Channel #minetest-dev was synced in 33 seconds
18:25 --> IceCraft [bsl@bitcoinshell.mooo.com] has joined #minetest-dev
--- Log opened Fri Sep 20 19:05:09 2013
19:05 --> thexyz [~xyz@2a01:4f8:151:8106::2] has joined #minetest-dev
19:05 --- Users 50 nicks [0 ops, 0 halfops, 5 voices, 45 normal]
--
01:38 <     troller> | i want to merge my small and tested pulls before too: #956 #952 #897 #895
01:38 < ShadowNinja> | celeron55: Oh, 925 you mean? Any mods that used the metatables can be updated and work with ever version of the vector functions.
01:39 <   celeron55> | ShadowNinja: 856
01:39 < ShadowNinja> | celeron55: 856 won't break the API.
01:40 <   celeron55> | it will have to be broken in the future because it's half-designed
01:40 <-- iqualfragile [~iqualfrag@unaffiliated/iqualfragile] has quit (Ping timeout: 272 seconds)
01:40 < ShadowNinja> | celeron55: Half-designed? How so? How can it be fixed?
01:41 <   celeron55> | it can be fixed by designing it taking into account everything, as described in the lengthy discussion linked there
01:41 <   celeron55> | just ignore it for now
01:41 <   celeron55> | the vector stuff seems very arguable
01:42 <   celeron55> | the speed can be improved by just not constructing the metatable again every time but using one that is allocated only once at load time
--
16:27 <     proller> | or https://github.com/minetest/minetest/pull/895
16:29 <+   PilzAdam> | this seems to increase the speed of the default liquids
16:31 <     proller> | only if queue big
16:32 <     proller> | but now liquds have no constant speed
16:32 <     proller> | bigger queue -> slower
16:33 <+   PilzAdam> | you increase liquid_update, that makes the liquids faster when the queue is not full
16:37 <     proller> | no, because decreased liquid_loop_max = 500
16:39 <    VanessaE> | the problem with high values of _max is risk of huge server lags
16:40 <    VanessaE> | there's basically no protection against excessive CPU usage in the water flowing code - or there wasn't at the time the default value was reduced.
16:45 --> Gethiox3 [~gethiox@ekq154.neoplus.adsl.tpnet.pl] has joined #minetest-dev
16:47 <-- Gethiox2 [~gethiox@eks229.neoplus.adsl.tpnet.pl] has quit (Ping timeout: 260 seconds)
--
15:19 <     proller> | https://github.com/minetest/minetest/pull/895/files - now with annoying timers reset (prevent server 100% cpu use and lag)
15:21 <-- jojoa1997 [~jojoa1997@167.93.153.208] has quit (Ping timeout: 264 seconds)
15:33 <-- Calinou [~Calinou@unaffiliated/calinou] has quit (Quit: bye :))
15:48 --> jojoa1997 [~jojoa1997@167.93.153.208] has joined #minetest-dev
15:49 <-- jojoa1997 [~jojoa1997@167.93.153.208] has quit (Client Quit)
16:00 <-- nore [~Nore@85-170-196-16.rev.numericable.fr] has quit (Ping timeout: 256 seconds)
16:13 --> nore [~Nore@85-170-196-16.rev.numericable.fr] has joined #minetest-dev
16:27 --> hmmmm [~sdfgsf@cpe-184-58-9-98.woh.res.rr.com] has joined #minetest-dev
16:28 --- ChanServ sets modes [#minetest-dev +v hmmmm]
16:33 <     proller> | hmmmm, weather broken month ago..
16:35 --> ImQ009 [~vibrant@host-81-190-201-68.gorzow.mm.pl] has joined #minetest-dev
--
17:06 <     proller> | full set of my patches https://github.com/minetest/minetest/pull/895/files - they do absolutely nothing and useless ;)
17:06 <     proller> | ^ about speed
17:07 <+       nore> | VanessaE, 34?
17:08 <+       nore> | 34 can not fail
17:08 <    VanessaE> | ok good.
17:10 <+       nore> | about that space game perhaps shipped with Minetest... who would help doing it?
17:10 <+     sapier> | did we discuss usage of "signef off" git feature by some time?
17:11 <+     sapier> | I'll provide space mobs
17:11 <   celeron55> | nore: it's not really possible to make a reasonable one at the moment due to a number of reasons
17:11 <   celeron55> | or, it really depends on what can be considered reasonable...
17:11 <+       nore> | yes, you may be right...
--
21:08 <     proller> | https://github.com/minetest/minetest/pull/895/files - now liquid is fast
21:08 --> Calinou [~Calinou@unaffiliated/calinou] has joined #minetest-dev
21:09 <+     sapier> | hmm the only way to use this would be creating a lookup table on startup I don't want to do api calls each time a string is translated
21:10 <+     sapier> | I have to go now but I'm gonna have a try if this works later
21:10 +thexyz: that'd be great
21:11 <+     sapier> | maybe it's as easy as doing a name lookup ... not quite sure if I understood doc right ... but could be
21:11 <+     sapier> | bye
21:11 <-- sapier [~sapier@p5498D693.dip0.t-ipconnect.de] has left #minetest-dev ( )
21:12 <    VanessaE> | I don't advocate 0.4.8 going out just yet.  Not 'til the http_fetch and lib_6d both go in.
21:14 <     proller> | VanessaE, all liquids fast ^^
21:14 <+   PilzAdam> | VanessaE, lib_6d uses sneak for placement, that is not good since its used to place nodes at other nodes that would usually have a different effect on rightclick
--
22:03 <     proller> | celeron55, #895 - with lot useless stuff!
22:04 <+ShadowNinja> | Alright, I will push #856 then.
22:05 <+ShadowNinja> | rubenwardy: Already discussed, it will be going in after 0.4.8.
22:05 <+       nore> | ShadowNinja, you need to write something about it in News... (for modders, they need to know that since there are a lot of protection mods)
22:05 <+ShadowNinja> | nore: Alright.
22:06 <  rubenwardy> | ok
22:08 <    VanessaE> | PilzAdam: ok, check the code now.  It seems to work right anyway.
22:08 <+ShadowNinja> | Hmmm, it seems that GitHub properly auto-closes and marks as merged pulls that are merged with rebase and "git merge --ff-only".
22:09 <+       nore> | yep, I saw that
22:10 <+   PilzAdam> | only if they are alraedy rebased, AFAIK
22:10 --> Evergreen [~Evergreen@184.17.67.71] has joined #minetest-dev
--
22:58 <     proller> | 895 and 882 conflicting 8( and i cant merge them in one
22:59 +thexyz: ShadowNinja: shouldn't you tag your topic in the news section with [0.4.8]?
23:00 +ShadowNinja: thexyz: Ah, yes, done.
23:01 <+   PilzAdam> | ShadowNinja, and fix everything tha rubenwardy mentioned
23:05 <+ShadowNinja> | PilzAdam: Done.
23:06 <+ShadowNinja> | All except "* [0.4.8]?" that is
23:06 <+ShadowNinja> | And for mods "C++ API" == "builtin API".
23:07 <+ShadowNinja> | And "That's not really a hack." == false.
23:10 --> general3214_ [~general32@wireless-173-87-174-136.dr04.ekgv.ca.frontiernet.net] has joined #minetest-dev
23:11 <       kaeza> | It's not a hack; it's called compatibility layer
23:11 <    VanessaE> | PilzAdam, ShadowNinja:  any other changes to #959 ?
--
21:39 <     proller> | some time checks here - https://github.com/minetest/minetest/pull/895/files
21:39 <     proller> | samsung galaxy s2 cpu 8)
21:45 <-- RealBadAngel [~realbadan@81.210.110.11] has quit (Remote host closed the connection)
21:53 <     proller> | https://github.com/minetest/minetest/pull/980/files - now with autorespawn!
22:05 --> EvergreenTree [~Evergreen@184.17.67.71] has joined #minetest-dev
22:13 <+     sapier> | hmm peacful_mobs?
22:13 --> werwerwer_ [~1@158.181.202.254] has joined #minetest-dev
22:13 <+     sapier> | as long as mobs aren't included that's completely useless and if they are this shouldn't be engine issue
22:14 <+     sapier> | proller why do you add a variable for this anyway?
22:15 <     proller> | because i want no death screen too?
22:16 <-- werwerwer [~1@158.181.199.141] has quit (Ping timeout: 245 seconds)
--
22:22 <+     sapier> | 895 environment.cpp L 1287 + 1294 what's that change good for?
22:24 <+     sapier> | I don't question it reducing lag, I didn't have time to check I assume you don't lie to me
22:29 <     proller> | on slow cpu these queues always overloaded
22:29 <     proller> | and produce more load with every step
22:29 <+     sapier> | proller I'm not talking about queues ;-)
22:30 <     proller> | ups
22:30 <+     sapier> | I'm talking about:
22:30 <+     sapier> | bool only_peaceful_mobs = g_settings->getBool("only_peaceful_mobs");
22:30 <+     sapier> | if(only_peaceful_mobs){
22:30 <+     sapier> | why? ;-)
22:30 <     proller> | to not ask settings in every iteration
--
05:03 <     troller> | https://github.com/minetest/minetest/pull/895/files - now with breaked abms processing (if took to much time)
05:18 <+ShadowNinja> | troller: Fix your git E-mail to match one of your GitHub E-mails.
05:19 <+ShadowNinja> | troller: And use "git commit --amend" in pull requests. It means no squashing later.
05:20 <     troller> | oops, mail fixed
05:20 <     troller> | I'm afraid any -- git params ;)
06:18 <-- ecube [~ecube@unaffiliated/ecube] has quit (Ping timeout: 245 seconds)
06:21 --> ecube [~ecube@unaffiliated/ecube] has joined #minetest-dev
06:38 <-- iqualfragile [~iqualfrag@unaffiliated/iqualfragile] has quit (Read error: Connection reset by peer)
07:01 <-- EvergreenTree [~Evergreen@184.17.67.71] has quit (Quit: reactor chainsawed me)
07:09 <-- zat [~aleksandr@186-105-251-172.baf.movistar.cl] has quit (Quit: Leaving.)
08:24 --> Kamski [~kagen@74-130-253-210.dhcp.insightbb.com] has joined #minetest-dev
--
20:07 <     troller> | https://github.com/minetest/minetest/pull/895/files - best patch of year nomination
20:32 <    VanessaE> | EvergreenTree: I believe the intent is to merge it at some point, but it is not a separate file now, it's gonna be part of builtin/misc_helpers.lua .
20:44 --> Calinou [~Calinou@unaffiliated/calinou] has joined #minetest-dev
20:55 --> sapier [~sapier@p5B02E349.dip0.t-ipconnect.de] has joined #minetest-dev
20:55 --- ChanServ sets modes [#minetest-dev +v sapier]
20:58 <    VanessaE> | Calinou: #959 - proposal to remove the "forcewall" flag (whose presence allows moreblocks-style sneak-to-force-wall).  comments?
21:00 <     Calinou> | https://github.com/minetest/minetest/pull/959 ?
21:00 <     Calinou> | oh
21:00 <    VanessaE> | yeah
21:00 <     Calinou> | I don't get what that thing does
21:00 <     Calinou> | is it purely a code cleanup or does it add a feature?
--
21:54 <     troller> | https://github.com/minetest/minetest/pull/895/files  - this for server
21:55 <+     sapier> | what are bots meant for?
21:55 <+     sapier> | ok 895 is a little bit tricky to judge
21:55 <     troller> | screen nice ./minetest --go --address $address --port $port --name $n
21:55 <     troller> | for testing server 8)
21:56 +thexyz: you mean, your i5 can handle 30 bots with 78.32% cpu load?
21:56 <     troller> | no, 320% load
21:56 <     troller> | 78 free
21:56 <+     sapier> | i5 is dual core with hyperthreading right?
21:56 <     Calinou> | quad core without HT on desktop
21:56 <     Calinou> | on mobile, dual core with HT
21:57 --> PilzAdam [~PilzAdam@unaffiliated/pilzadam] has joined #minetest-dev
21:57 --- ChanServ sets modes [#minetest-dev +v PilzAdam]
--
22:01 <     troller> | maybe increase max players in #895 ? to 30 for example
22:01 <     troller> | sapier, 892 okay
22:01 <     Calinou> | whatever works, but I'll only change code when it's merged
22:04 --> EvergreenTree [~Evergreen@184.17.67.71] has joined #minetest-dev
22:05 <    VanessaE> | Calinou: ok.  well it's up to the others here to decide if it's merged, but I wanted your comments on which method you prefer.  by default, both are available.
22:05 <+     sapier> | any core dev to agree to 892? can't merge without ok ;-)
22:07 <     troller> | sapier, okay
22:07 <+     sapier> | sorry I'm the new guy I need to stick to the rules ;-)
22:10 +thexyz: sapier: can you explain what exactly this fixes
22:11 <+     sapier> | yeah actually this fixes a very silly bug, when you do a asString() a temporary string object is created
22:11 <+     sapier> | doing a c_str() afterwards creates a pointer to a constant string within that temporary object
--
01:40 <     troller> | https://github.com/minetest/minetest/pull/895/files need to test with 50+ players ;)
01:41 <+     sapier> | you should try to find them in minetest ;-)
01:43 <     troller> | in weekend maybe
01:45 <     troller> | and with it every can write lot of slow mods
01:48 <+ShadowNinja> | Any objections to reverting making the creative hand dig instantly? It makes punching impossible in creative.
01:57 <     troller> | 20 clients on arm without lag
01:58 <     troller> | with liquid_finite
02:10 <+ShadowNinja> | Alright, can someone agree to ^? troller, sapier?
02:12 --> n4x [uid8028@gateway/web/irccloud.com/x-cwlozyhmcmuyscdm] has joined #minetest-dev
02:12 --- n4x is now known as Guest90889
02:13 <+     sapier> | could you post a link so we can se what you're talking about?
--
00:31 <     proller> | lets start party: #983 #980 #956 #895 #892
00:31 <+     sapier> | I learned the hard way if it can be done bad it will be done bad yet I'm still looking for a must have feature in 5.2 justifying to add it
00:32 <     proller> | #983 is simplests
00:33 <+     sapier> | wtf they use goto to implement break ...
00:37 <+     sapier> | ok I assume most things in 5.2 are acceptable ... I'm a little bit concerned about the bitoperations ... those could result in different calculation results
00:37 <+ShadowNinja> | sapier: Look for one here: http://lua-users.org/wiki/LuaFiveTwo
00:38 <+ShadowNinja> | Not sure what you mean, but LuaJIT has BitOp if you need it.
00:38 <+     sapier> | http://www.inf.puc-rio.br/~roberto/talks/novelties-5.2.pdf this is better
00:39 * ShadowNinja shrugs
00:43 <+     sapier> | but shadow don't we have enough bugs to fix do we really need to add a new source of unknown bugs?
00:45 <+     sapier> | 983 seems to be fine
--
01:38 <+     sapier> | 895, there's no need to change default max user value for liquid levels
01:38 <     proller> | every server can work with 50+ clients
01:39 <     proller> | this value was decreased from 100 because current servers unplayable at 10+ players
01:39 <+     sapier> | it's not related to the fix don't try to push changes like that as trojan horses
01:39 <+     sapier> | I think 15 is to small to yet it's not to be changed in this special commit ;-)
01:39 <     proller> | no problem, i will remove this line
01:40 <+     sapier> | #max_simultaneous_block_sends_server_total = 100500 if the comment for this line is right I don't think that number is sane
01:41 <     proller> | i can remove this variable
01:41 <     proller> | its only for lag
01:41 <+     sapier> | what is it supposed to do?
01:42 <     proller> | to not send blocks if too many players
--
04:21 <     troller> | #895 updated
04:33 <-- general3214 [~general32@wireless-173-87-174-136.dr04.ekgv.ca.frontiernet.net] has quit (Quit: Leaving)
04:55 --> EvergreenTree [~Evergreen@184.17.67.71] has joined #minetest-dev
06:16 <-- zat [~aleksandr@186-105-185-197.baf.movistar.cl] has quit (Quit: Leaving.)
06:40 <-- EvergreenTree [~Evergreen@184.17.67.71] has quit (Quit: reactor chainsawed me)
06:41 --> Warr1024 [rz7ppbj39f@c-68-33-16-243.hsd1.md.comcast.net] has joined #minetest-dev
06:49 --> mrtux [~colin@unaffiliated/mrtux] has joined #minetest-dev
07:01 --> iqualfragile [~iqualfrag@unaffiliated/iqualfragile] has joined #minetest-dev
08:20 <-- Warr1024 [rz7ppbj39f@c-68-33-16-243.hsd1.md.comcast.net] has quit (Quit: Leaving.)
08:23 --> Guest16696 [~kaeza@5.175.169.22] has joined #minetest-dev
08:23 <-- Netsplit: *.net <-> *.split quits: ecube, kaeza
--
01:17 <     troller> | maybe add #895 to 0.4.8 milestone?
01:19 <+ShadowNinja> | troller: 21 commits? You shouldn't be submiting pull requests in this state.
01:19 <+     sapier> | I'm not sure about it it changes lots of things if we're gonna release 0.4.8 soo this has to wait for 0.4.9
01:20 <     troller> | ShadowNinja, 2 manth ago it was only one commit
01:20 <     troller> | after 2-4 rebases again 1
01:20 <+     sapier> | you should squash it it won't be merged as is for sure ;-)
01:20 <     troller> | i always squash before merge
01:20 <+ShadowNinja> | troller: Just use git commit --amend to begin with.
01:21 <     troller> | it works with pushed?
01:22 <     troller> | and look here https://github.com/minetest/minetest/pull/895/files
01:22 <+     sapier> | but that's a quite unimportant detail actually I'd be glad with performance improvements but I can't decide if there aren't any hard to see bugs hidden within it
01:23 <+     sapier> | and without some time of testing I'd not have a good feeling to add this to a stable release
01:23 <     troller> | better to do nothing...
01:23 <     troller> | 100% bug free
01:23 <-- ShadowNinja [~ShadowNin@unaffiliated/shadowninja] has quit (Read error: Operation timed out)
01:23 <+     sapier> | it's not about bug free it's about stability
01:24 <     troller> | my server works fine.
01:24 <+     sapier> | everything works fine within the environment it was created
01:24 --> ShadowNinja [~ShadowNin@unaffiliated/shadowninja] has joined #minetest-dev
01:24 --- ChanServ sets modes [#minetest-dev +v ShadowNinja]
--
05:17 <     proller> | hmmmm, #892 #895
05:18 <+      hmmmm> | I'll have to check out 895 better
05:18 <+      hmmmm> | you do a lot there
05:18 <+      hmmmm> | oh the weather stuff
05:18 <+      hmmmm> | 892 we need to talk about
05:19 <     proller> | it fixes weather
05:19 <     proller> | if weather disabled - return static value
05:19 <+      hmmmm> | I know, there's a better way to do it though
05:19 <     proller> | -33333c?
05:19 <    VanessaE> | use the values from plants_lib :)
05:20 <+      hmmmm> | that was INT16_MIN
05:20 <     proller> | and checks everywhere?
--
18:35 <+      kahrl> | https://github.com/kahrl/minetest/commit/3ad51376916fbe4e98d2f31de7b99cb27f71e061#diff-3fcaee4030e00b8f8895c2ff21d5b364R38
18:36 <+     sapier> | still doesn't change the trap with 0 in c_str() ;-)
18:37 <+      kahrl> | what do you suggest?
18:37 <+     sapier> | char* and size yes this isn't as elegant as std::string but way less error prone
18:38 <+      kahrl> | ugh... that's ugly
18:38 <+      kahrl> | std::string is basically a wrapper for those two so why not use it?
18:38 <+     sapier> | no it's c ;-)
18:38 <+     sapier> | because it's a string wrapper so you quite abuse it for binary data ;-)
18:41 <+      kahrl> | what exactly is "binary data"?
18:41 <+      kahrl> | everything in a modern computer is binary
18:42 <+     sapier> | when I'm speaking of binary data I'm talking about data not beeing linked to any char codeset
--
21:31 +thexyz: proller: did you see https://github.com/minetest/minetest/pull/895#issuecomment-28129708
21:31 --> OWNSyouAll [~ownsyoual@96.36.14.3] has joined #minetest-dev
21:32 <     proller> | no problem with abm timers, they increase chance if some calls was missed
21:33 <     proller> | but some every second on_step will be skipped
21:34 <     proller> | but anyway it better than now in master
21:39 <-- Akien [~akien@78.193.40.184] has quit (Remote host closed the connection)
21:42 --> Akien [~akien@78.193.40.184] has joined #minetest-dev
21:43 <-- OWNSyouAll [~ownsyoual@96.36.14.3] has quit (Read error: Connection reset by peer)
21:44 <     proller> | idea: improve commiting rules: if pull waits more than [1-2] weeks and have no objections - every core dev can commit it (even pull creator)
21:44 --> OWNSyouAll [~ownsyoual@96.36.14.3] has joined #minetest-dev
21:44 <     proller> | no future in current state