Skip to content

Instantly share code, notes, and snippets.

@yochannah

yochannah/cors-investigation-notes.md

Created August 6, 2019 12:17
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save yochannah/f4f975a2259d476a136efac3a1036363 to your computer and use it in GitHub Desktop.
Save yochannah/f4f975a2259d476a136efac3a1036363 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
cors-investigation-notes.md

CORS investigation notes

Repo used for testing: https://github.com/yochannah/cytoscape-intermine/tree/cors-investigations - cors investigation branch.

To test:

  1. Clone the repo and checkout cors-investigations branch
  2. npm install dependencies.
  3. npm install ../some/path/to/locally/compiled/imjs
  4. In the cytoscape-intermine/node_moduled/imjs directory change main : build/service to main : dist/im.js if needed.
  5. Back in the cytoscape-intermine directory, run gulp js to recompile the cytoscape viewer with the new copy of imjs.
  6. Test cytoscape-intermine for CORS errors. This might be via npm gulpDev or some other serve command.

Good commits vs bad commits

In imjs, for Yo, the cors error doesn't present until commit e2a98cf - see the diff: https://github.com/intermine/imjs/compare/55e7e99...e2a98cf?w=1

Good: 55e7e99 Bad: e2a98cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment