What is the best way to add options to a select from an array

select.js

selectValues = { "1": "test 1", "2": "test 2" };

$.each(selectValues, function(key, value) {   
     $('#mySelect')
          .append($('<option>', { value : key })
          .text(value)); 
});