Skip to content

Instantly share code, notes, and snippets.

@yuriy77k
Forked from RideSolo/ETH_fck_report.md
Created May 14, 2019 16:14
Show Gist options
  • Save yuriy77k/316d0183bf8686bb63e56a95da31f1ef to your computer and use it in GitHub Desktop.
Save yuriy77k/316d0183bf8686bb63e56a95da31f1ef to your computer and use it in GitHub Desktop.

FCK Audit Report.

1. Summary

This document is a security audit report performed by RideSolo, where FCK has been reviewed.

2. In scope

  • fck.sol github commit hash a7fd48b135db2f4828cbc8e5e694b4a9627cd323.

3. Findings

2 issues were reported including:

  • 2 low severity issues.

3.1. Fallback Function

Severity: low

Description

The fallback function allows anyone to deposit ether to the contract, only addresses intended to deposit tokens should be allowed to deposit.

Code snippet

https://github.com/RideSolo/FCK-contracts/blob/master/dice/fck.com%20Sol#L139

3.2. Kill Function

Severity: low

Description

Once kill function called, all payables function should be blocked inlcuding the fallback function.

Code snippet

https://github.com/RideSolo/FCK-contracts/blob/master/dice/fck.com%20Sol#L139

https://github.com/RideSolo/FCK-contracts/blob/master/dice/fck.com%20Sol#L191

4. Conclusion

The audited contract is safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment