Skip to content

Instantly share code, notes, and snippets.

@yuriy77k
Forked from RideSolo/ETH_Asure_report.md
Created April 27, 2019 19:14
Show Gist options
  • Save yuriy77k/451e55756c987ff65ec9c365d60f03b5 to your computer and use it in GitHub Desktop.
Save yuriy77k/451e55756c987ff65ec9c365d60f03b5 to your computer and use it in GitHub Desktop.

Asure Token Report.

1. Summary

This document is a security audit report performed by RideSolo, where Asure Token has been reviewed.

2. In scope

3. Findings

2 issues were reported:

  • 2 low severity issues.

3.1. Array Size

Severity: low

Description

In drop function member of AsureBounty contract, recipients and values arrays length should be checked if they are the same length.

Code snippet

https://github.com/RideSolo/crowdsale/blob/master/packages/crowdsale/contracts/AsureBounty.sol#L16

3.2. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here
  2. Lack of transaction handling mechanism issue. WARNING! This is a very common issue and it already caused millions of dollars losses for lots of token users! More details here

Recommendation

Add the following code to the transfer(_to address, ...) function:

require( _to != address(this) );

Code snippet

https://github.com/RideSolo/crowdsale/blob/master/packages/crowdsale/contracts/AsureToken.sol

Conclusion

The audited contracts can be deployed safely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment