Skip to content

Instantly share code, notes, and snippets.

@yuriy77k

yuriy77k/ETH_Heiswap_report.md Secret

Forked from MrCrambo/ETH_Heiswap_report.md
Created July 19, 2019 19:39
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save yuriy77k/573a83e8a78142ab86a0f9e6cbfea71d to your computer and use it in GitHub Desktop.
Save yuriy77k/573a83e8a78142ab86a0f9e6cbfea71d to your computer and use it in GitHub Desktop.
Download ZIP
Raw
ETH_Heiswap_report.md

Summary

This is the report from a security audit performed on Heiswap by MrCrambo.

The audit focused primarily on the security of Heiswap smart contract.

In scope

  1. https://github.com/kendricktan/heiswap-dapp/blob/master/contracts/AltBn128.sol
  2. https://github.com/kendricktan/heiswap-dapp/blob/master/contracts/Heiswap.sol
  3. https://github.com/kendricktan/heiswap-dapp/blob/master/contracts/LSAG.sol

Findings

In total, 3 issues were reported including:

  • 0 high severity issues.

  • 0 medium severity issues.

  • 0 owner privilegies issues.

  • 2 low severity issues.

  • 1 notes.

Security issues

1. Wrong function name

Severity: note

Description

All function names should follow solidity style guide. But functions powmod, addmodn don't follow it.

2. Zero address checking

Severity: low

Description

In function withdraw there is no zero address checking

3. SafeMath

Severity: low

Description

There are math operations that should be rewrited with SafeMath library.

Conclusion

Smart contracts are safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment