Skip to content

Instantly share code, notes, and snippets.

@yuriy77k
Forked from MrCrambo/ETH_VCP_report.md
Created May 23, 2019 18:28
Show Gist options
  • Save yuriy77k/a944cbbffe7d1728eb0df95a56abe164 to your computer and use it in GitHub Desktop.
Save yuriy77k/a944cbbffe7d1728eb0df95a56abe164 to your computer and use it in GitHub Desktop.

Summary

This is the report from a security audit performed on VCP by MrCrambo.

The audit focused primarily on the security of VCP smart contract.

In scope

  1. https://etherscan.io/address/0x9b7922f5c51b43b59ea666ed77191c4cdbfca72f#code

Findings

In total, 2 issues were reported including:

  • 0 high severity issues.

  • 0 medium severity issues.

  • 0 owner privilegies issues.

  • 2 low severity issues.

Security issues

1. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here
  2. Lack of transaction handling mechanism issue. More details here

Recommendation

Add into a function transfer(address _to, ... ) following code:

require( _to != address(this) );

2. Zero address checking

Severity: low

Description

  1. In functions transfer and transferFrom there are no zero address checking.
  2. totalSupply() function will show wrong amount, because of subtracting zero address balance from it.

Conclusion

Smart contract contains only low severity issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment