Skip to content

Instantly share code, notes, and snippets.

@yuriy77k
Forked from MrCrambo/ETH_Twogap_report.md
Created May 23, 2019 18:28
Show Gist options
  • Save yuriy77k/c5aea1e544c1cc2557f391cbe17b154c to your computer and use it in GitHub Desktop.
Save yuriy77k/c5aea1e544c1cc2557f391cbe17b154c to your computer and use it in GitHub Desktop.

Summary

This is the report from a security audit performed on Twogap by MrCrambo.

The audit focused primarily on the security of Twogap smart contract.

In scope

  1. https://etherscan.io/address/0xf96aa656ec0e0ac163590db372b430cf3c0d61ca#code

Findings

In total, 2 issues were reported including:

  • 0 high severity issues.

  • 0 medium severity issues.

  • 0 owner privilegies issues.

  • 2 low severity issues.

Security issues

1. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here
  2. Lack of transaction handling mechanism issue. More details here

Recommendation

Add into a function transfer(address _to, ... ) following code:

require( _to != address(this) );

2. Extra functions

Severity: low

Description

Functions _burn and _burnFrom are internal functions and have no usage, so they could be deleted.

Conclusion

Smart contract contains only low severity issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment