Skip to content

Instantly share code, notes, and snippets.

@yuriy77k
Forked from danbogd/AuditchainToken_audit_report.md
Created February 26, 2019 19:48
Show Gist options
  • Save yuriy77k/c60dc5f1439c1cbebb20793db52339db to your computer and use it in GitHub Desktop.
Save yuriy77k/c60dc5f1439c1cbebb20793db52339db to your computer and use it in GitHub Desktop.

Auditchain Token audit report.

1. Summary

This document is a security audit report performed by danbogd, where Auditchain Token has been reviewed.

2. In scope

  • Locked.sol github commit hash 6ebb925a6f8bf9a744b2c6eedaf71bacf24ddf46.
  • MigrationAgent.sol github commit hash 6ebb925a6f8bf9a744b2c6eedaf71bacf24ddf46.
  • Token.sol github commit hash 6ebb925a6f8bf9a744b2c6eedaf71bacf24ddf46.

3. Findings

In total, 2 issues were reported including:

  • 2 low severity issues.

No critical security issues were found.

3.1. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here.

  2. Lack of transaction handling mechanism issue. WARNING! This is a very common issue and it already caused millions of dollars losses for lots of token users! More details here.

Recommendation

Add into a function transfer(address _to, ... ) following code:

require( _to != address(this) );

3.2. Missing event call.

Severity: low

Description

In the constructor is no events on the transfer of funds.

Code snippet

https://github.com/Vestcomp/TGE/blob/6ebb925a6f8bf9a744b2c6eedaf71bacf24ddf46/contracts/Token.sol#L42-L45

4. Conclusion

The review did not show any critical issues, but some low severity issues were found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment