Skip to content

Instantly share code, notes, and snippets.

@yuriy77k
Forked from MrCrambo/TRON_ TRONDapphub_report.md
Created April 24, 2019 13:46
Show Gist options
  • Save yuriy77k/ce2cca3ff243fb379be63ef9cb1f3f2c to your computer and use it in GitHub Desktop.
Save yuriy77k/ce2cca3ff243fb379be63ef9cb1f3f2c to your computer and use it in GitHub Desktop.

Summary

This is the report from a security audit performed on TRONDapphub by MrCrambo.

The audit focused primarily on the security of TRONDapphub smart contract.

In scope

  1. https://github.com/trondapphub/contracts/blob/3cf4e716c3e8cf2e4339657b1fbca51d9c19bc96/TDHtoken.sol

Findings

In total, 3 issues was reported including:

  • 0 high severity issues.

  • 0 medium severity issues.

  • 3 low severity issues.

Security issues

1. Known vulnerabilities of ERC-20 token

Severity: low

Description

As TRON works on Ethereum standards, then this issues is possible there:

  1. It is possible to double withdrawal attack. More details here
  2. Lack of transaction handling mechanism issue. More details here

Recommendation

Add into a function transfer(address _to, ... ) following code:

require( _to != address(this) );

2. Extra checking

Severity: low

Description

There is extra checking in function transferFrom for zero address, because it will be checkind in _transfer function.

3. Owner privilegies

Severity: low

Description

Owner can change burning and approveAndCall requirements, so users will not be available to call this functions.

Conclusion

Smart contract contains only low severity issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment