Skip to content

Instantly share code, notes, and snippets.

@yuriy77k
Forked from MrCrambo/ETH_LuckyStrike_v5_report.md
Created June 18, 2019 16:23
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save yuriy77k/e12af0290e90d575e1b59acac31c223f to your computer and use it in GitHub Desktop.
Save yuriy77k/e12af0290e90d575e1b59acac31c223f to your computer and use it in GitHub Desktop.

Summary

This is the report from a security audit performed on LuckyStrike v5 by MrCrambo.

The audit focused primarily on the security of LuckyStrike v5 smart contracts.

In scope

  1. https://ropsten.etherscan.io/address/0x1a77110391c07d3d67c8c55c6114a858cb45bb26#contracts
  2. https://ropsten.etherscan.io/address/0xc3e2b080aefc0d9d5b5e30614e892b5fd1276777#contracts

Findings

In total, 4 issues were reported including:

  • 0 high severity issues.

  • 0 medium severity issues.

  • 1 owner privilegies issues.

  • 2 low severity issues.

  • 1 notes.

Security issues

1. TODO comment left

Severity: note

Description

There is #TODO comments left in line 148 in token contract.

2. Minting more than hardCap

Severity: low

Description

There is still possibility of minting more than hardCap in function mint in line 339 in token contract.

3. Owner privilegies

Severity: owner privilegies

Description

There is still possibility that owner can change rates in function adjustAllocation line 1590 in game contract.

4. Wrong jackpot playing again

Severity: low

Description

At comment in line 2131 there is written to enabling playing jackpot again, but in next line it set to false in game contract.

Recommendation

Line 2132 should look like this

jackpotPlayIsRunning[jackpotType] = true;

Conclusion

There is only low severity issues in contracts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment