Skip to content

Instantly share code, notes, and snippets.

@yuriy77k
Forked from danbogd/POCgames_audit_report.md
Created October 23, 2018 07:31
Show Gist options
  • Save yuriy77k/f2379724799ab771db12b3f0a68f9caa to your computer and use it in GitHub Desktop.
Save yuriy77k/f2379724799ab771db12b3f0a68f9caa to your computer and use it in GitHub Desktop.

POCgames Audit Report.

1. Summary

This document is a security audit report performed by danbogd, where POCgames has been reviewed.

2. In scope

3. Findings

In total, 2 issues were reported including:

  • 2 low severity issues.

No critical security issues were found.

3.1. No checking for zero address.

Severity: low

Description

Functions member of FiftyFlip contract do not require the to address to be non null before transfer. Accidental token loss to address 0x0 can be applicable.

Code snippet

https://gist.github.com/yuriy77k/909d9541f30628d3a0e6c39af36a4cdf#file-fiftyflip-sol-L74 https://gist.github.com/yuriy77k/909d9541f30628d3a0e6c39af36a4cdf#file-fiftyflip-sol-L107 https://gist.github.com/yuriy77k/909d9541f30628d3a0e6c39af36a4cdf#file-fiftyflip-sol-L114

3.2. No protection from overflows/underflows.

Severity: low

Description

Use SafeMath for protection from overflows/underflows.

Code snippet

https://gist.github.com/yuriy77k/909d9541f30628d3a0e6c39af36a4cdf#file-fiftyflip-sol-L139 https://gist.github.com/yuriy77k/909d9541f30628d3a0e6c39af36a4cdf#file-fiftyflip-sol-L140 https://gist.github.com/yuriy77k/909d9541f30628d3a0e6c39af36a4cdf#file-fiftyflip-sol-L141 https://gist.github.com/yuriy77k/909d9541f30628d3a0e6c39af36a4cdf#file-fiftyflip-sol-L143 https://gist.github.com/yuriy77k/909d9541f30628d3a0e6c39af36a4cdf#file-fiftyflip-sol-L145 https://gist.github.com/yuriy77k/909d9541f30628d3a0e6c39af36a4cdf#file-fiftyflip-sol-L207 https://gist.github.com/yuriy77k/909d9541f30628d3a0e6c39af36a4cdf#file-fiftyflip-sol-L217

4. Conclusion

No critical vulnerabilities were detected, but we highly recommend to complete this bugs before use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment