Skip to content

Instantly share code, notes, and snippets.

@yuriy77k
Forked from MrCrambo/ETH_GenesisVision_report.md
Created May 20, 2019 16:23
Show Gist options
  • Save yuriy77k/f51540e6dd89019c991c85fbe829163d to your computer and use it in GitHub Desktop.
Save yuriy77k/f51540e6dd89019c991c85fbe829163d to your computer and use it in GitHub Desktop.

Summary

This is the report from a security audit performed on Genesis Vision by MrCrambo.

The audit focused primarily on the security of Genesis Vision smart contracts.

In scope

  1. https://github.com/GenesisVision/platform-contracts/blob/master/contracts/libs/Models.sol
  2. https://github.com/GenesisVision/platform-contracts/blob/master/contracts/GenesisVisionPlatform.sol
  3. https://github.com/GenesisVision/platform-contracts/blob/master/contracts/ManagerToken.sol
  4. https://github.com/GenesisVision/platform-contracts/blob/master/contracts/TradingHistoryStorage.sol

Findings

In total, 3 issues were reported including:

  • 0 high severity issues.

  • 0 medium severity issues.

  • 1 owner privilegies issues.

  • 2 low severity issues.

Security issues

1. Owner privilegies

Severity: owner privilegies

Description

  1. Owner can change total supply any time he wants.
  2. Owner can raise total supply any time he wants and add himself more tokens.

2. Zero address checking

Severity: low

Description

There are no zero address checking in setGenesisVisionAdmin, setGenesisVisionAdmin and transferManagerToken

3. Wrong total supply

Severity: low

Description

Total supply calculated without multiplayed decimals.

Conclusion

Smart contracts contain low severity issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment