Skip to content

Instantly share code, notes, and snippets.

Show Gist options
  • Save yuriy77k/f5baefc0963cc674897d5f81413fa605 to your computer and use it in GitHub Desktop.
Save yuriy77k/f5baefc0963cc674897d5f81413fa605 to your computer and use it in GitHub Desktop.

Maximine Coin audit report.

1. Summary

This document is a security audit report performed by danbogd, where Maximine Coin has been reviewed.

2. In scope

Сommit hash .

3. Findings

In total, 4 issues were reported including:

  • 0 medium severity issues
  • 3 low severity issues
  • 1 owner privileges (ability of owner to manipulate contract, may be risky for investors)..
  • 0 notes.

No critical security issues were found.

3.1. ERC20 Compliance.

Severity: low

Description

An event isn't emited when assigning the initial supply to the msg.sender.

Code snippet

Line 41.

balanceOf[msg.sender] = totalSupply;

3.2. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here.

  2. Lack of transaction handling mechanism issue. WARNING! This is a very common issue and it already caused millions of dollars losses for lots of token users! More details here.

Recommendation

Add into a function transfer(address _to, ... ) following code:

require( _to != address(this) );

3.3. Owner Privileges

Severity: owner previliges

Description

Contract owner allow himself to:

-block/unblock transfer operations of any user.

Line 86.

    function ban(address addr) public {
    require(msg.sender == admin);
    blacklist[addr] = true;
    } 

3.4. No checking for zero address

Severity: low

Description

Incoming _spender addresses should be checked for an empty value(0x0 address) to avoid loss of funds or blocking some functionality.

Code snippet

Line: 126.

    function approve(address _spender, uint256 _value) public
    returns (bool success) {
    require(!blacklist[msg.sender]);
    allowance[msg.sender][_spender] = _value;
    return true;
    }

4. Conclusion

The review did not show any critical issues, some of low severity issues were found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment