Skip to content

Instantly share code, notes, and snippets.

@yutannihilation

yutannihilation/ark_clippy_warnings.txt

Created July 9, 2024 01:43
Show Gist options
  • Save yutannihilation/991647186a8510f0bc0c7b8b34b45ee5 to your computer and use it in GitHub Desktop.
Save yutannihilation/991647186a8510f0bc0c7b8b34b45ee5 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
ark_clippy_warnings.txt
Checking stdext v0.1.0 (C:\Users\Yutani\Documents\GitHub\ark\crates\stdext)
warning: very complex type used. Consider factoring parts into `type` definitions
--> crates\stdext\src\event.rs:16:16
|
16 | listeners: Mutex<HashMap<i32, Box<dyn Fn(&T) + Send>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
warning: unneeded `return` statement
--> crates\stdext\src\event.rs:32:9
|
32 | return id;
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
32 - return id;
32 + id
|
warning: unneeded `return` statement
--> crates\stdext\src\result.rs:45:22
|
45 | Ok(_) => return,
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: replace `return` with a unit value
|
45 | Ok(_) => (),
| ~~
warning: unneeded `return` statement
--> crates\stdext\src\result.rs:52:22
|
52 | Ok(_) => return,
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: replace `return` with a unit value
|
52 | Ok(_) => (),
| ~~
warning: unneeded `return` statement
--> crates\stdext\src\result.rs:59:22
|
59 | Ok(_) => return,
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: replace `return` with a unit value
|
59 | Ok(_) => (),
| ~~
warning: `stdext` (lib) generated 5 warnings (run `cargo clippy --fix --lib -p stdext` to apply 4 suggestions)
Checking libr v0.1.0 (C:\Users\Yutani\Documents\GitHub\ark\crates\libr)
Compiling ark v0.1.114 (C:\Users\Yutani\Documents\GitHub\ark\crates\ark)
Checking amalthea v0.1.0 (C:\Users\Yutani\Documents\GitHub\ark\crates\amalthea)
Compiling harp-macros v0.1.0 (C:\Users\Yutani\Documents\GitHub\ark\crates\harp\harp-macros)
warning: calling `push_str()` using a single-character string literal
--> crates\harp\harp-macros\src\lib.rs:190:5
|
190 | name.push_str("\0");
| ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `name.push('\0')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
= note: `#[warn(clippy::single_char_add_str)]` on by default
warning: `harp-macros` (lib) generated 1 warning (run `cargo clippy --fix --lib -p harp-macros` to apply 1 suggestion)
warning: the borrowed expression implements the required traits
--> crates\ark\build.rs:17:15
|
17 | .args(&["rev-parse", "--short", "HEAD"])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rev-parse", "--short", "HEAD"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
warning: the borrowed expression implements the required traits
--> crates\ark\build.rs:26:15
|
26 | .args(&["branch", "--show-current"])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["branch", "--show-current"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\functions.rs:30:17
|
30 | pub unsafe fn $name($($pname: $pty), *) $(-> $ret)* {
| ^^^
|
::: crates\libr\src\r.rs:21:1
|
21 | / functions::generate! {
22 | | pub fn Rf_initialize_R(ac: std::ffi::c_int, av: *mut *mut std::ffi::c_char) -> std::ffi::c_int;
23 | |
24 | | pub fn run_Rmainloop();
... |
388 | | // pub fn free_R_HOME(s: *mut std::ffi::c_char);
389 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: `#[warn(clippy::missing_safety_doc)]` on by default
= note: this warning originates in the macro `functions::generate` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\functions.rs:30:17
|
30 | pub unsafe fn $name($($pname: $pty), *) $(-> $ret)* {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\libr\src\r.rs:21:1
|
21 | / functions::generate! {
22 | | pub fn Rf_initialize_R(ac: std::ffi::c_int, av: *mut *mut std::ffi::c_char) -> std::ffi::c_int;
23 | |
24 | | pub fn run_Rmainloop();
... |
388 | | // pub fn free_R_HOME(s: *mut std::ffi::c_char);
389 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: this warning originates in the macro `functions::generate` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\functions.rs:30:17
|
30 | pub unsafe fn $name($($pname: $pty), *) $(-> $ret)* {
| ^^^
|
::: crates\libr\src\r.rs:21:1
|
21 | / functions::generate! {
22 | | pub fn Rf_initialize_R(ac: std::ffi::c_int, av: *mut *mut std::ffi::c_char) -> std::ffi::c_int;
23 | |
24 | | pub fn run_Rmainloop();
... |
388 | | // pub fn free_R_HOME(s: *mut std::ffi::c_char);
389 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: this warning originates in the macro `functions::generate` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\functions.rs:45:21
|
45 | pub unsafe fn $name() -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\libr\src\r.rs:21:1
|
21 | / functions::generate! {
22 | | pub fn Rf_initialize_R(ac: std::ffi::c_int, av: *mut *mut std::ffi::c_char) -> std::ffi::c_int;
23 | |
24 | | pub fn run_Rmainloop();
... |
388 | | // pub fn free_R_HOME(s: *mut std::ffi::c_char);
389 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: this warning originates in the macro `functions::generate` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\functions_variadic.rs:32:17
|
32 | pub unsafe fn $name($($pname: $pty), *) $(-> $ret)* {
| ^^^
|
::: crates\libr\src\r.rs:391:1
|
391 | / functions_variadic::generate! {
392 | | pub fn Rf_error(arg1: *const std::ffi::c_char, ...) -> !;
393 | |
394 | | pub fn Rf_errorcall(arg1: SEXP, arg2: *const std::ffi::c_char, ...) -> !;
395 | |
396 | | pub fn Rprintf(x: *const std::ffi::c_char, ...);
397 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: this warning originates in the macro `functions_variadic::generate` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\functions_variadic.rs:32:17
|
32 | pub unsafe fn $name($($pname: $pty), *) $(-> $ret)* {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\libr\src\r.rs:391:1
|
391 | / functions_variadic::generate! {
392 | | pub fn Rf_error(arg1: *const std::ffi::c_char, ...) -> !;
393 | |
394 | | pub fn Rf_errorcall(arg1: SEXP, arg2: *const std::ffi::c_char, ...) -> !;
395 | |
396 | | pub fn Rprintf(x: *const std::ffi::c_char, ...);
397 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: this warning originates in the macro `functions_variadic::generate` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\functions_variadic.rs:47:21
|
47 | pub unsafe fn $name() -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\libr\src\r.rs:391:1
|
391 | / functions_variadic::generate! {
392 | | pub fn Rf_error(arg1: *const std::ffi::c_char, ...) -> !;
393 | |
394 | | pub fn Rf_errorcall(arg1: SEXP, arg2: *const std::ffi::c_char, ...) -> !;
395 | |
396 | | pub fn Rprintf(x: *const std::ffi::c_char, ...);
397 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: this warning originates in the macro `functions_variadic::generate` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\constant_globals.rs:44:21
|
44 | pub unsafe fn $name() -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\libr\src\r.rs:399:1
|
399 | / constant_globals::generate! {
400 | | #[doc = "IEEE NaN"]
401 | | #[default = 0.0]
402 | | pub static R_NaN: f64;
... |
626 | | pub static R_BlankScalarString: SEXP;
627 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: this warning originates in the macro `constant_globals::generate` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\mutable_globals.rs:30:21
|
30 | pub unsafe fn $name() -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\libr\src\r.rs:629:1
|
629 | / mutable_globals::generate! {
630 | | pub static mut R_Interactive: Rboolean;
631 | |
632 | | pub static mut R_interrupts_pending: std::ffi::c_int;
... |
721 | | pub static mut localeCP: std::ffi::c_uint;
722 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: this warning originates in the macro `mutable_globals::generate` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: transmute from a type (`u32`) to itself
--> crates\libr\src\sys\windows\types.rs:196:18
|
196 | unsafe { ::std::mem::transmute(self._bitfield_1.get(0usize, 16u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
= note: `#[warn(clippy::useless_transmute)]` on by default
warning: transmute from a type (`u32`) to itself
--> crates\libr\src\sys\windows\types.rs:201:28
|
201 | let val: u32 = ::std::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
warning: transmute from a type (`u32`) to itself
--> crates\libr\src\sys\windows\types.rs:223:44
|
223 | let NoRenviron: u32 = unsafe { ::std::mem::transmute(NoRenviron) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\functions.rs:30:17
|
30 | pub unsafe fn $name($($pname: $pty), *) $(-> $ret)* {
| ^^^
|
::: crates\libr\src\graphapp.rs:19:1
|
19 | / functions::generate! {
20 | | pub fn GA_initapp(arg1: std::ffi::c_int, arg2: *mut *mut std::ffi::c_char) -> std::ffi::c_int;
21 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: this warning originates in the macro `functions::generate` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\functions.rs:45:21
|
45 | pub unsafe fn $name() -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\libr\src\graphapp.rs:19:1
|
19 | / functions::generate! {
20 | | pub fn GA_initapp(arg1: std::ffi::c_int, arg2: *mut *mut std::ffi::c_char) -> std::ffi::c_int;
21 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: this warning originates in the macro `functions::generate` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\lib.rs:71:1
|
71 | / pub unsafe fn get<T>(x: *mut T) -> T
72 | | where
73 | | T: Copy,
| |____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unsafe function's docs are missing a `# Safety` section
--> crates\libr\src\lib.rs:79:1
|
79 | pub unsafe fn set<T>(x: *mut T, value: T) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: `harp-macros` (lib) generated 1 warning (1 duplicate)
warning: `libr` (lib) generated 369 warnings (353 duplicates)
Checking harp v0.1.0 (C:\Users\Yutani\Documents\GitHub\ark\crates\harp)
warning: `ark` (build script) generated 2 warnings
warning: `crate` references the macro call's crate
--> crates\harp\src\error.rs:213:9
|
213 | crate::error::Error::Anyhow {
| ^^^^^ help: to reference the macro definition's crate, use: `$crate`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def
= note: `#[warn(clippy::crate_in_macro_def)]` on by default
warning: constants have by default a `'static` lifetime
--> crates\harp\src\line_ending.rs:12:31
|
12 | pub const POSIX_LINE_ENDING: &'static str = "\n";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
warning: constants have by default a `'static` lifetime
--> crates\harp\src\line_ending.rs:13:33
|
13 | pub const WINDOWS_LINE_ENDING: &'static str = "\r\n";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
warning: this `if` statement can be collapsed
--> crates\harp\src\string.rs:34:5
|
34 | / if r_typeof(result) == EXPRSXP {
35 | | if Rf_xlength(result) != 0 {
36 | | let value = VECTOR_ELT(result, 0);
37 | | if r_typeof(value) == STRSXP {
... |
40 | | }
41 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
34 ~ if r_typeof(result) == EXPRSXP && Rf_xlength(result) != 0 {
35 + let value = VECTOR_ELT(result, 0);
36 + if r_typeof(value) == STRSXP {
37 + return RObject::view(value).to::<String>().ok();
38 + }
39 + }
|
warning: constants have by default a `'static` lifetime
--> crates\harp\src\sys\windows\line_ending.rs:10:32
|
10 | pub const NATIVE_LINE_ENDING: &'static str = WINDOWS_LINE_ENDING;
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
warning: this `else { if .. }` block can be collapsed
--> crates\harp\src\vector\formatted_vector.rs:122:20
|
122 | } else {
| ____________________^
123 | | if r_inherits(vector, "factor") {
124 | | Ok(Self::Factor {
125 | | vector: Factor::new_unchecked(vector),
... |
135 | | }
136 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
122 ~ } else if r_inherits(vector, "factor") {
123 + Ok(Self::Factor {
124 + vector: Factor::new_unchecked(vector),
125 + })
126 + } else {
127 + let formatted = r_format(vector)?;
128 +
129 + r_assert_type(formatted, &[STRSXP])?;
130 + Ok(Self::FormattedVector {
131 + vector: CharacterVector::new_unchecked(formatted),
132 + options: formatting_options.character,
133 + })
134 + }
|
warning: `crate` references the macro call's crate
--> crates\harp\src\lib.rs:97:25
|
97 | let rtype = crate::utils::r_typeof(sexp);
| ^^^^^ help: to reference the macro definition's crate, use: `$crate`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\attrib.rs:9:35
|
9 | let x = unsafe { RObject::new(x) };
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
= note: `#[deny(clippy::not_unsafe_ptr_arg_deref)]` on by default
warning: unneeded `return` statement
--> crates\harp\src\call.rs:65:14
|
65 | _ => return x.into(),
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
65 | _ => x.into(),
| ~~~~~~~~
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\environment.rs:115:53
|
115 | pub fn find(&self, name: impl Into<RSymbol>) -> harp::Result<SEXP> {
| ^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
= note: `#[warn(clippy::result_large_err)]` on by default
warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead
--> crates\harp\src\environment.rs:131:49
|
131 | EnvironmentFilter::ExcludeHidden => self
| _________________________________________________^
132 | | .iter()
133 | | .filter_map(|b| b.ok())
134 | | .filter(|b| !b.is_hidden())
135 | | .next()
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
= note: `#[warn(clippy::filter_next)]` on by default
help: try
|
131 ~ EnvironmentFilter::ExcludeHidden => self
132 + .iter()
133 + .filter_map(|b| b.ok()).find(|b| !b.is_hidden())
|
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\environment.rs:224:47
|
224 | pub fn is_active(&self, name: RSymbol) -> harp::Result<bool> {
| ^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\environment.rs:232:30
|
232 | pub fn as_list(&self) -> harp::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\environment_iter.rs:67:53
|
67 | pub fn new(env: &Environment, name: RSymbol) -> harp::Result<Self> {
| ^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\environment_iter.rs:114:52
|
114 | fn new_standard(name: RSymbol, value: SEXP) -> harp::Result<Self> {
| ^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: if let .. else expression looks like `matches!` macro
--> crates\harp\src\environment_iter.rs:127:9
|
127 | / if let BindingValue::Active { .. } = self.value {
128 | | true
129 | | } else {
130 | | false
131 | | }
| |_________^ help: try: `matches!(self.value, BindingValue::Active { .. })`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
= note: `#[warn(clippy::match_like_matches_macro)]` on by default
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\error.rs:230:65
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
...
230 | fn check(x: impl Into<libr::SEXP>, expected: libr::SEXPTYPE) -> crate::Result<()> {
| ^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\error.rs:242:47
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
...
242 | pub fn check_env(x: impl Into<libr::SEXP>) -> crate::Result<()> {
| ^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\eval.rs:28:62
|
28 | pub fn r_parse_eval0(code: &str, env: impl Into<RObject>) -> harp::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\eval.rs:35:64
|
35 | pub fn r_parse_eval(code: &str, options: RParseEvalOptions) -> harp::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:82:31
|
82 | pub fn call(&mut self) -> Result<RObject> {
| ^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:95:45
|
95 | pub fn call_in(&mut self, env: SEXP) -> Result<RObject> {
| ^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:104:43
|
104 | pub fn try_eval(expr: SEXP, env: SEXP) -> crate::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\exec.rs:105:49
|
105 | let mut res = try_catch(|| unsafe { Rf_eval(expr, env) }).map(RObject::from);
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\exec.rs:105:55
|
105 | let mut res = try_catch(|| unsafe { Rf_eval(expr, env) }).map(RObject::from);
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\exec.rs:108:43
|
108 | *code = Some(unsafe { r_stringify(expr, "\n")? });
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:114:50
|
114 | pub fn try_eval_silent(expr: SEXP, env: SEXP) -> crate::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:183:41
|
183 | pub fn try_catch<'env, F, T>(fun: F) -> harp::Result<T>
| ^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:325:46
|
325 | pub fn top_level_exec<'env, F, T>(fun: F) -> harp::Result<T>
| ^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: length comparison to zero
--> crates\harp\src\exec.rs:361:16
|
361 | if err_buf.len() > 0 {
| ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!err_buf.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
warning: useless conversion to the same type: `std::string::String`
--> crates\harp\src\exec.rs:366:26
|
366 | message: String::from(format!("Unexpected longjump{err_buf}")),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Unexpected longjump{err_buf}")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
warning: unneeded `return` statement
--> crates\harp\src\exec.rs:382:22
|
382 | Ok(value) => return value.to_string(),
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
382 | Ok(value) => value.to_string(),
| ~~~~~~~~~~~~~~~~~
warning: unneeded `return` statement
--> crates\harp\src\exec.rs:383:19
|
383 | Err(_) => return "".to_string(),
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
383 | Err(_) => "".to_string(),
| ~~~~~~~~~~~~~~
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\exec.rs:388:1
|
388 | pub unsafe fn r_parse_vector(code: &str) -> Result<ParseResult> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: `#[warn(clippy::missing_safety_doc)]` on by default
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:388:45
|
388 | pub unsafe fn r_parse_vector(code: &str) -> Result<ParseResult> {
| ^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:414:32
|
414 | pub fn r_source(file: &str) -> crate::Result<()> {
| ^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:418:46
|
418 | pub fn r_source_in(file: &str, env: SEXP) -> crate::Result<()> {
| ^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:427:36
|
427 | pub fn r_source_str(code: &str) -> crate::Result<()> {
| ^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:431:61
|
431 | pub fn r_source_str_in(code: &str, env: impl Into<SEXP>) -> crate::Result<()> {
| ^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:437:50
|
437 | pub fn r_source_exprs(exprs: impl Into<SEXP>) -> crate::Result<()> {
| ^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:441:75
|
441 | pub fn r_source_exprs_in(exprs: impl Into<SEXP>, env: impl Into<SEXP>) -> crate::Result<()> {
| ^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:457:37
|
457 | pub fn r_parse_exprs(code: &str) -> Result<RObject> {
| ^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: unneeded `return` statement
--> crates\harp\src\exec.rs:460:13
|
460 | return Ok(RObject::from(x));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
460 ~ Ok(RObject::from(x))
461 | },
...
467 | },
468 ~ }
|
warning: unneeded `return` statement
--> crates\harp\src\exec.rs:463:13
|
463 | / return Err(Error::ParseError {
464 | | code: code.to_string(),
465 | | message: String::from("Incomplete code"),
466 | | });
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
463 ~ Err(Error::ParseError {
464 + code: code.to_string(),
465 + message: String::from("Incomplete code"),
466 ~ })
467 | },
468 ~ }
|
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:472:50
|
472 | pub fn r_parse_exprs_with_srcrefs(code: &str) -> Result<RObject> {
| ^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:488:31
|
488 | pub fn r_parse(code: &str) -> Result<RObject> {
| ^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:508:39
|
508 | pub fn r_sandbox<'env, F, T>(f: F) -> Result<T>
| ^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\exec.rs:582:46
|
582 | pub fn r_check_stack(size: Option<usize>) -> Result<()> {
| ^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\external_ptr.rs:17:5
|
17 | pub unsafe fn new(object: &T) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\external_ptr.rs:30:5
|
30 | pub unsafe fn reference(pointer: SEXP) -> &'static T {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unneeded `return` statement
--> crates\harp\src\json.rs:150:36
|
150 | Some(value) => return Ok(Value::String(value)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
150 | Some(value) => Ok(Value::String(value)),
| ~~~~~~~~~~~~~~~~~~~~~~~~
warning: unnecessary `if let` since only the `Some` variant of the iterator element is used
--> crates\harp\src\json.rs:195:25
|
195 | for name in names {
| ^ ----- help: try: `names.iter().flatten()`
| _________________________|
| |
196 | | if let Some(name) = name {
197 | | if !name.is_empty() {
198 | | all_empty = false;
... |
201 | | }
202 | | }
| |_________________________^
|
help: ...and remove the `if let` statement in the for loop
--> crates\harp\src\json.rs:196:29
|
196 | / ... if let Some(name) = name {
197 | | ... if !name.is_empty() {
198 | | ... all_empty = false;
199 | | ... break;
200 | | ... }
201 | | ... }
| |_______________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
= note: `#[warn(clippy::manual_flatten)]` on by default
warning: calls to `push` immediately after creation
--> crates\harp\src\json.rs:248:45
|
248 | / ... let mut arr = Vec::<Value>::new();
249 | | ... arr.push(existing.clone());
250 | | ... arr.push(val);
| |____________________________________^ help: consider using the `vec![]` macro: `let arr = vec![..];`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
= note: `#[warn(clippy::vec_init_then_push)]` on by default
warning: unneeded `return` statement
--> crates\harp\src\json.rs:327:13
|
327 | return Ok(list);
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
327 - return Ok(list);
327 + Ok(list)
|
warning: unneeded `return` statement
--> crates\harp\src\library.rs:63:21
|
63 | Ok(true) => return path,
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
63 | Ok(true) => path,
| ~~~~
warning: importing legacy numeric constants
--> crates\harp\src\object.rs:10:5
|
10 | use std::i32;
| ^^^^^^^^
|
= help: remove this import
= note: then `i32::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
warning: unneeded `return` statement
--> crates\harp\src\object.rs:79:5
|
79 | return cell;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
79 - return cell;
79 + cell
|
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\object.rs:114:5
|
114 | unsafe fn elt(&self, index: T) -> crate::error::Result<RObject>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\object.rs:114:39
|
114 | unsafe fn elt(&self, index: T) -> crate::error::Result<RObject>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:155:25
|
155 | unsafe { Rf_xlength(x) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:159:27
|
159 | unsafe { Rf_getAttrib(x, R_DimSymbol) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:163:26
|
163 | unsafe { LOGICAL_ELT(x, i) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:166:26
|
166 | unsafe { INTEGER_ELT(x, i) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:169:23
|
169 | unsafe { REAL_ELT(x, i) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:172:26
|
172 | unsafe { COMPLEX_ELT(x, i) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:175:25
|
175 | unsafe { STRING_ELT(x, i) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:182:25
|
182 | unsafe { VECTOR_ELT(x, i) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:186:29
|
186 | unsafe { SET_VECTOR_ELT(x, i, value) };
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:186:35
|
186 | unsafe { SET_VECTOR_ELT(x, i, value) };
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:228:30
|
228 | unsafe { SET_LOGICAL_ELT(x, i, value) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:231:30
|
231 | unsafe { SET_INTEGER_ELT(x, i, value) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:234:27
|
234 | unsafe { SET_REAL_ELT(x, i, value) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:237:29
|
237 | unsafe { SET_STRING_ELT(x, i, value) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:237:35
|
237 | unsafe { SET_STRING_ELT(x, i, value) }
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:241:24
|
241 | SET_VECTOR_ELT(x, i, value);
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:241:30
|
241 | SET_VECTOR_ELT(x, i, value);
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:246:22
|
246 | unsafe { LOGICAL(x) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:249:22
|
249 | unsafe { INTEGER(x) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:252:19
|
252 | unsafe { REAL(x) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:277:18
|
277 | unsafe { CAR(x) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:280:18
|
280 | unsafe { TAG(x) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:283:18
|
283 | unsafe { CDR(x) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\object.rs:287:5
|
287 | pub unsafe fn new(data: SEXP) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\object.rs:309:5
|
309 | pub unsafe fn to<U: TryFrom<RObject, Error = crate::error::Error>>(self) -> Result<U, Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\object.rs:309:81
|
309 | pub unsafe fn to<U: TryFrom<RObject, Error = crate::error::Error>>(self) -> Result<U, Error> {
| ^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\object.rs:342:45
|
342 | pub fn get_string(&self, idx: isize) -> crate::error::Result<Option<String>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\object.rs:360:42
|
360 | pub fn get_i32(&self, idx: isize) -> crate::error::Result<Option<i32>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\object.rs:378:42
|
378 | pub fn get_f64(&self, idx: isize) -> crate::error::Result<Option<f64>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\object.rs:397:43
|
397 | pub fn get_bool(&self, idx: isize) -> crate::error::Result<Option<bool>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\object.rs:416:45
|
416 | pub fn vector_elt(&self, idx: isize) -> crate::error::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:448:24
|
448 | Rf_protect(value);
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:449:54
|
449 | Rf_setAttrib(self.sexp, r_symbol!(name), value);
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\object.rs:500:31
|
500 | unsafe { RObject::new(value) }
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: unneeded `return` statement
--> crates\harp\src\object.rs:514:13
|
514 | return RObject::new(value);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
514 - return RObject::new(value);
514 + RObject::new(value)
|
warning: unneeded `return` statement
--> crates\harp\src\object.rs:523:13
|
523 | return RObject::new(value);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
523 - return RObject::new(value);
523 + RObject::new(value)
|
warning: unneeded `return` statement
--> crates\harp\src\object.rs:541:13
|
541 | return Ok(RObject::new(value));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
541 - return Ok(RObject::new(value));
541 + Ok(RObject::new(value))
|
warning: unneeded `return` statement
--> crates\harp\src\object.rs:550:13
|
550 | return RObject::new(value);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
550 - return RObject::new(value);
550 + RObject::new(value)
|
warning: unneeded `return` statement
--> crates\harp\src\object.rs:566:13
|
566 | return RObject::new(vector);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
566 - return RObject::new(vector);
566 + RObject::new(vector)
|
warning: unneeded `return` statement
--> crates\harp\src\object.rs:589:13
|
589 | return vector;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
589 - return vector;
589 + vector
|
warning: the loop variable `idx` is used to index `values`
--> crates\harp\src\object.rs:581:24
|
581 | for idx in 0..values.len() {
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator and enumerate()
|
581 | for (idx, <item>) in values.iter().enumerate() {
| ~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~
warning: unneeded `return` statement
--> crates\harp\src\object.rs:601:13
|
601 | return vector;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
601 - return vector;
601 + vector
|
warning: the loop variable `idx` is used to index `values`
--> crates\harp\src\object.rs:598:24
|
598 | for idx in 0..values.len() {
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
598 | for (idx, <item>) in values.iter().enumerate() {
| ~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~
warning: unneeded `return` statement
--> crates\harp\src\object.rs:835:13
|
835 | return Ok(result);
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
835 - return Ok(result);
835 + Ok(result)
|
warning: unneeded `return` statement
--> crates\harp\src\object.rs:851:13
|
851 | return Ok(result);
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
851 - return Ok(result);
851 + Ok(result)
|
warning: casting to the same type is unnecessary (`isize` -> `isize`)
--> crates\harp\src\object.rs:849:46
|
849 | result.push(value.get_string(i as isize)?);
| ^^^^^^^^^^ help: try: `i`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
warning: unneeded `return` statement
--> crates\harp\src\object.rs:875:13
|
875 | return Ok(result);
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
875 - return Ok(result);
875 + Ok(result)
|
warning: unneeded `return` statement
--> crates\harp\src\object.rs:893:13
|
893 | return Ok(result);
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
893 - return Ok(result);
893 + Ok(result)
|
warning: unneeded `return` statement
--> crates\harp\src\object.rs:913:13
|
913 | return Ok(out);
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
913 - return Ok(out);
913 + Ok(out)
|
warning: the loop variable `i` is used to index `value`
--> crates\harp\src\object.rs:909:22
|
909 | for i in 0..n {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
909 | for (i, <item>) in value.iter().enumerate().take(n) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
warning: unneeded `return` statement
--> crates\harp\src\object.rs:935:9
|
935 | return Ok(out);
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
935 - return Ok(out);
935 + Ok(out)
|
warning: the loop variable `i` is used to index `value`
--> crates\harp\src\object.rs:929:18
|
929 | for i in 0..n {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
929 | for (i, <item>) in value.iter().enumerate().take(n) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
warning: unneeded `return` statement
--> crates\harp\src\object.rs:957:13
|
957 | return Ok(out);
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
957 - return Ok(out);
957 + Ok(out)
|
warning: the loop variable `i` is used to index `value`
--> crates\harp\src\object.rs:949:22
|
949 | for i in 0..n {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
949 | for (i, <item>) in value.iter().enumerate().take(n) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
warning: use of `offset` with a `usize` casted to an `isize`
--> crates\harp\src\object.rs:954:18
|
954 | *(v_out.offset(i as isize)) = x;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `v_out.add(i)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
= note: `#[warn(clippy::ptr_offset_with_cast)]` on by default
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\object.rs:1047:45
|
1047 | pub fn r_null_or_try_into<T>(x: RObject) -> harp::Result<Option<T>>
| ^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\protect.rs:22:5
|
22 | pub unsafe fn new() -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\protect.rs:27:5
|
27 | pub unsafe fn add(&mut self, object: SEXP) -> SEXP {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unneeded `return` statement
--> crates\harp\src\protect.rs:29:9
|
29 | return Rf_protect(object);
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
29 - return Rf_protect(object);
29 + Rf_protect(object)
|
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\r_version.rs:23:1
|
23 | pub unsafe fn r_version() -> &'static Version {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\raii.rs:54:39
|
54 | let old_value = libr::get(variable);
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\raii.rs:55:23
|
55 | libr::set(variable, new_value);
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: you should consider adding a `Default` implementation for `RLocalSandbox`
--> crates\harp\src\raii.rs:124:5
|
124 | / pub fn new() -> Self {
125 | | Self {
126 | | _interrupts_scope: RLocalInterruptsSuspended::new(true),
127 | | _polled_events_scope: crate::sys::polled_events::RLocalPolledEventsSuspended::new(true),
128 | | }
129 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
123 + impl Default for RLocalSandbox {
124 + fn default() -> Self {
125 + Self::new()
126 + }
127 + }
|
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\routines.rs:18:1
|
18 | pub unsafe fn add(def: R_CallMethodDef) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\routines.rs:22:1
|
22 | pub unsafe fn r_register_routines() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\session.rs:31:23
|
31 | pub fn r_n_frame() -> crate::Result<i32> {
| ^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\session.rs:41:25
|
41 | pub fn r_sys_calls() -> crate::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: question mark operator is useless here
--> crates\harp\src\session.rs:45:9
|
45 | / Ok(harp::try_eval_silent(
46 | | SYS_CALLS_CALL.unwrap_unchecked(),
47 | | R_BaseEnv,
48 | | )?)
| |___________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
= note: `#[warn(clippy::needless_question_mark)]` on by default
help: try removing question mark and `Ok()`
|
45 ~ harp::try_eval_silent(
46 + SYS_CALLS_CALL.unwrap_unchecked(),
47 + R_BaseEnv,
48 + )
|
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\session.rs:52:26
|
52 | pub fn r_sys_frames() -> crate::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: question mark operator is useless here
--> crates\harp\src\session.rs:56:9
|
56 | / Ok(harp::try_eval_silent(
57 | | SYS_FRAMES_CALL.unwrap_unchecked(),
58 | | R_BaseEnv,
59 | | )?)
| |___________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
help: try removing question mark and `Ok()`
|
56 ~ harp::try_eval_silent(
57 + SYS_FRAMES_CALL.unwrap_unchecked(),
58 + R_BaseEnv,
59 + )
|
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\session.rs:63:29
|
63 | pub fn r_sys_functions() -> crate::Result<SEXP> {
| ^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\session.rs:94:43
|
94 | pub fn r_sys_frame(n: std::ffi::c_int) -> crate::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: question mark operator is useless here
--> crates\harp\src\session.rs:99:9
|
99 | Ok(harp::try_eval_silent(call, R_BaseEnv)?)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `harp::try_eval_silent(call, R_BaseEnv)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\session.rs:103:42
|
103 | pub fn r_sys_call(n: std::ffi::c_int) -> crate::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: question mark operator is useless here
--> crates\harp\src\session.rs:108:9
|
108 | Ok(harp::try_eval_silent(call, R_BaseEnv)?)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `harp::try_eval_silent(call, R_BaseEnv)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\session.rs:117:35
|
117 | let browsed = unsafe { RDEBUG(env) };
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\session.rs:138:46
|
138 | pub fn r_format_traceback(calls: RObject) -> crate::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\string.rs:24:1
|
24 | pub unsafe fn r_string_decode(code: &str) -> Option<String> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\string.rs:47:50
|
47 | unsafe { r_typeof(x) == STRSXP && Rf_xlength(x) == 1 && x != R_NaString }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\symbol.rs:38:31
|
38 | pub fn new(sexp: SEXP) -> Result<Self> {
| ^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates\harp\src\sys\windows\library.rs:29:44
|
29 | let r_path = find_r_shared_library(&path, "R");
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates\harp\src\sys\windows\library.rs:40:53
|
40 | let r_graphapp_path = find_r_shared_library(&path, "Rgraphapp");
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates\harp\src\sys\windows\library.rs:43:51
|
43 | let r_lapack_path = find_r_shared_library(&path, "Rlapack");
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates\harp\src\sys\windows\library.rs:46:50
|
46 | let r_iconv_path = find_r_shared_library(&path, "Riconv");
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates\harp\src\sys\windows\library.rs:49:49
|
49 | let r_blas_path = find_r_shared_library(&path, "Rblas");
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
warning: returning the result of a `let` binding from a block
--> crates\harp\src\sys\windows\library.rs:89:5
|
87 | let library = library.map(|library| library.into());
| ---------------------------------------------------- unnecessary `let` binding
88 |
89 | library
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
87 ~
88 |
89 ~ library.map(|library| library.into())
|
warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
--> crates\harp\src\sys\windows\library.rs:92:43
|
92 | pub fn find_r_shared_library_folder(path: &PathBuf) -> PathBuf {
| ^^^^^^^^ help: change this to: `&Path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\table.rs:70:55
|
70 | let col_names = ColumnNames::new(Rf_getAttrib(x, R_NamesSymbol));
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\table.rs:114:33
|
114 | let dims = Rf_getAttrib(x, R_DimSymbol);
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\table.rs:139:53
|
139 | Some(CharacterVector::new_unchecked(names))
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: length comparison to zero
--> crates\harp\src\table.rs:150:20
|
150 | if name.len() > 0 {
| ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!name.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
warning: casting raw pointers to the same type and constness is unnecessary (`*mut *mut i8` -> `*mut *mut i8`)
--> crates\harp\src\test.rs:82:13
|
82 | arguments.as_mut_ptr() as *mut *mut c_char,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `arguments.as_mut_ptr()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
warning: redundant slicing of the whole range
--> crates\harp\src\traits\slice.rs:26:9
|
26 | &self[..]
| ^^^^^^^^^ help: use the original value instead: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
= note: `#[warn(clippy::redundant_slicing)]` on by default
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:125:57
|
125 | pub fn r_assert_type(object: SEXP, expected: &[u32]) -> Result<u32> {
| ^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:135:1
|
135 | pub unsafe fn r_assert_capacity(object: SEXP, required: usize) -> Result<usize> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:135:67
|
135 | pub unsafe fn r_assert_capacity(object: SEXP, required: usize) -> Result<usize> {
| ^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:144:58
|
144 | pub fn r_assert_length(object: SEXP, expected: usize) -> Result<usize> {
| ^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:145:38
|
145 | let actual = unsafe { Rf_xlength(object) as usize };
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:179:34
|
179 | let class = Rf_getAttrib(value, R_ClassSymbol);
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:191:26
|
191 | unsafe { Rf_isMatrix(value) == Rboolean_TRUE }
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:196:50
|
196 | let classes = RObject::from(Rf_getAttrib(value, R_ClassSymbol));
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:210:51
|
210 | pub fn r_chr_get_owned_utf8(x: SEXP, i: isize) -> Result<String> {
| ^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:211:45
|
211 | unsafe { r_str_to_owned_utf8(STRING_ELT(x, i)) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:219:40
|
219 | pub fn r_str_to_owned_utf8(x: SEXP) -> Result<String> {
| ^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:243:38
|
243 | let x = Rf_translateCharUTF8(x);
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: returning the result of a `let` binding from a block
--> crates\harp\src\utils.rs:251:9
|
249 | let x = x.to_string();
| ---------------------- unnecessary `let` binding
250 |
251 | x
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
help: return the expression directly
|
249 ~
250 |
251 ~ x.to_string()
|
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:255:45
|
255 | pub fn pairlist_size(mut pairlist: SEXP) -> Result<isize> {
| ^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:261:28
|
261 | pairlist = CDR(pairlist);
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: manual implementation of an assign operation
--> crates\harp\src\utils.rs:262:13
|
262 | n = n + 1;
| ^^^^^^^^^ help: replace it with: `n += 1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `#[warn(clippy::assign_op_pattern)]` on by default
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:276:43
|
276 | let levels = Rf_getAttrib(value, R_LevelsSymbol);
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:295:45
|
295 | let dim = RObject::new(Rf_getAttrib(value, R_DimSymbol));
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:298:38
|
298 | format!("{}", Rf_xlength(value))
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:307:57
|
307 | let serialized_klass = unsafe { ATTRIB(ALTREP_CLASS(object)) };
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: useless conversion to the same type: `*mut libr::SEXPREC`
--> crates\harp\src\utils.rs:318:18
|
318 | let object = object.into();
| ^^^^^^^^^^^^^ help: consider removing `.into()`: `object`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:336:26
|
336 | unsafe { Rf_inherits(object, class.as_ptr()) != 0 }
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:343:1
|
343 | pub unsafe fn r_formals(object: SEXP) -> Result<Vec<RArgument>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:343:42
|
343 | pub unsafe fn r_formals(object: SEXP) -> Result<Vec<RArgument>> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:372:1
|
372 | pub unsafe fn r_envir_name(envir: SEXP) -> Result<String> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:372:44
|
372 | pub unsafe fn r_envir_name(envir: SEXP) -> Result<String> {
| ^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:396:51
|
396 | let value = Rf_findVar(r_symbol!(symbol), envir);
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:406:1
|
406 | pub unsafe fn r_envir_set(symbol: &str, value: SEXP, envir: SEXP) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:410:1
|
410 | pub unsafe fn r_envir_remove(symbol: &str, envir: SEXP) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:426:39
|
426 | let names = unsafe { Rf_getAttrib(x, R_NamesSymbol) };
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:470:1
|
470 | pub unsafe fn r_stringify(object: SEXP, delimiter: &str) -> Result<String> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:470:61
|
470 | pub unsafe fn r_stringify(object: SEXP, delimiter: &str) -> Result<String> {
| ^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:491:1
|
491 | pub unsafe fn r_inspect(object: SEXP) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:519:22
|
519 | unsafe { PRVALUE(x) != R_UnboundValue }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:523:22
|
523 | unsafe { PRVALUE(x) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:528:28
|
528 | unsafe { R_PromiseExpr(x) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:531:1
|
531 | pub unsafe fn r_promise_force(x: SEXP) -> harp::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:531:43
|
531 | pub unsafe fn r_promise_force(x: SEXP) -> harp::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:536:50
|
536 | pub fn r_promise_force_with_rollback(x: SEXP) -> harp::Result<RObject> {
| ^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:541:48
|
541 | let out = harp::try_eval_silent(PRCODE(x), PRENV(x))?;
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:541:58
|
541 | let out = harp::try_eval_silent(PRCODE(x), PRENV(x))?;
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:542:21
|
542 | SET_PRVALUE(x, out.sexp);
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:547:1
|
547 | pub unsafe fn r_promise_is_lazy_load_binding(x: SEXP) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:574:29
|
574 | unsafe { R_BytecodeExpr(x) }
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:579:28
|
579 | unsafe { R_lsInternal3(env, Rboolean_TRUE, Rboolean_FALSE) }
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:583:39
|
583 | unsafe { libr::R_existsVarInFrame(env, sym) == libr::Rboolean_TRUE }
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:583:44
|
583 | unsafe { libr::R_existsVarInFrame(env, sym) == libr::Rboolean_TRUE }
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:592:57
|
592 | pub fn r_env_binding_is_active(env: SEXP, sym: SEXP) -> harp::Result<bool> {
| ^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:600:39
|
600 | Ok(unsafe { R_BindingIsActive(sym, env) == Rboolean_TRUE })
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\utils.rs:600:44
|
600 | Ok(unsafe { R_BindingIsActive(sym, env) == Rboolean_TRUE })
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:604:1
|
604 | pub unsafe fn r_env_is_pkg_env(env: SEXP) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:608:1
|
608 | pub unsafe fn r_pkg_env_name(env: SEXP) -> SEXP {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:625:1
|
625 | pub unsafe fn r_env_is_ns_env(env: SEXP) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\utils.rs:631:1
|
631 | pub unsafe fn r_ns_env_name(env: SEXP) -> SEXP {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unneeded `return` statement
--> crates\harp\src\utils.rs:663:5
|
663 | return false;
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
663 - return false;
663 + false
|
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\lib.rs:179:30
|
179 | libr::SET_TAG(value, $name);
| ^^^^^
|
::: crates\harp\src\utils.rs:674:20
|
674 | let call = r_lang!(OPTIONS_FN.unwrap_unchecked(), !!sym = value);
| ----------------------------------------------------- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
= note: this error originates in the macro `$crate::r_pairlist` which comes from the expansion of the macro `r_lang` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: length comparison to zero
--> crates\harp\src\utils.rs:720:19
|
720 | let path = if path.len() == 0 {
| ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `path.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\utils.rs:752:29
|
752 | pub fn r_format(x: SEXP) -> Result<SEXP> {
| ^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: calling `push_str()` using a single-character string literal
--> crates\harp\src\vec_format.rs:215:9
|
215 | out.push_str("+");
| ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('+')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
= note: `#[warn(clippy::single_char_add_str)]` on by default
warning: calling `push_str()` using a single-character string literal
--> crates\harp\src\vec_format.rs:220:5
|
220 | out.push_str("i");
| ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('i')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
warning: calling `push_str()` using a single-character string literal
--> crates\harp\src\vec_format.rs:232:9
|
232 | out.push_str("\"");
| ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `out.push('"')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\character_vector.rs:23:1
|
23 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
= note: this error originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: manual implementation of an assign operation
--> crates\harp\src\vector\character_vector.rs:23:1
|
23 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: this warning originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\factor.rs:22:1
|
22 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
= note: this error originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: manual implementation of an assign operation
--> crates\harp\src\vector\factor.rs:22:1
|
22 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: this warning originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: use of `offset` with a `usize` casted to an `isize`
--> crates\harp\src\vector\factor.rs:54:14
|
54 | *(dataptr.offset(index as isize)) = *value.as_ref();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dataptr.add(index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\integer_vector.rs:19:1
|
19 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
= note: this error originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: manual implementation of an assign operation
--> crates\harp\src\vector\integer_vector.rs:19:1
|
19 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: this warning originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: use of `offset` with a `usize` casted to an `isize`
--> crates\harp\src\vector\integer_vector.rs:49:14
|
49 | *(dataptr.offset(index as isize)) = *value.as_ref();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dataptr.add(index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\logical_vector.rs:19:1
|
19 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
= note: this error originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: manual implementation of an assign operation
--> crates\harp\src\vector\logical_vector.rs:19:1
|
19 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: this warning originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: use of `offset` with a `usize` casted to an `isize`
--> crates\harp\src\vector\logical_vector.rs:49:14
|
49 | *(dataptr.offset(index as isize)) = *value.as_ref();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dataptr.add(index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\numeric_vector.rs:19:1
|
19 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
= note: this error originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: manual implementation of an assign operation
--> crates\harp\src\vector\numeric_vector.rs:19:1
|
19 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: this warning originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: use of `offset` with a `usize` casted to an `isize`
--> crates\harp\src\vector\numeric_vector.rs:49:14
|
49 | *(dataptr.offset(index as isize)) = *value.as_ref();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dataptr.add(index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\complex_vector.rs:32:1
|
32 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
= note: this error originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: manual implementation of an assign operation
--> crates\harp\src\vector\complex_vector.rs:32:1
|
32 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: this warning originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: use of `offset` with a `usize` casted to an `isize`
--> crates\harp\src\vector\complex_vector.rs:62:14
|
62 | *(dataptr.offset(index as isize)) = *value.as_ref();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dataptr.add(index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> crates\harp\src\vector\complex_vector.rs:85:30
|
85 | format!("{}+{}i", x.r.to_string(), x.i.to_string())
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> crates\harp\src\vector\complex_vector.rs:85:47
|
85 | format!("{}+{}i", x.r.to_string(), x.i.to_string())
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\raw_vector.rs:18:1
|
18 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
= note: this error originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: manual implementation of an assign operation
--> crates\harp\src\vector\raw_vector.rs:18:1
|
18 | #[harp_macros::vector]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: this warning originates in the attribute macro `harp_macros::vector` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: use of `offset` with a `usize` casted to an `isize`
--> crates\harp\src\vector\raw_vector.rs:48:14
|
48 | *(dataptr.offset(index as isize)) = *value.as_ref();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dataptr.add(index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\vector\formatted_vector.rs:86:33
|
86 | pub fn new(vector: SEXP) -> Result<Self> {
| ^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\vector\formatted_vector.rs:93:10
|
93 | ) -> Result<Self> {
| ^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\formatted_vector.rs:95:38
|
95 | let class = Rf_getAttrib(vector, R_ClassSymbol);
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\formatted_vector.rs:99:58
|
99 | vector: RawVector::new_unchecked(vector),
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\formatted_vector.rs:102:62
|
102 | vector: LogicalVector::new_unchecked(vector),
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\formatted_vector.rs:105:62
|
105 | vector: IntegerVector::new_unchecked(vector),
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\formatted_vector.rs:108:62
|
108 | vector: NumericVector::new_unchecked(vector),
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\formatted_vector.rs:111:64
|
111 | vector: CharacterVector::new_unchecked(vector),
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\formatted_vector.rs:115:62
|
115 | vector: ComplexVector::new_unchecked(vector),
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\formatted_vector.rs:125:55
|
125 | vector: Factor::new_unchecked(vector),
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: enum `FormattedVector` has a public `len` method, but no `is_empty` method
--> crates\harp\src\vector\formatted_vector.rs:171:5
|
171 | pub fn len(&self) -> isize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `#[warn(clippy::len_without_is_empty)]` on by default
warning: manual implementation of an assign operation
--> crates\harp\src\vector\formatted_vector.rs:213:13
|
213 | self.index = self.index + 1;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
error: this public function might dereference a raw pointer but is not marked `unsafe`
--> crates\harp\src\vector\names.rs:24:51
|
24 | let names = RObject::new(Rf_getAttrib(x, R_NamesSymbol));
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
warning: length comparison to zero
--> crates\harp\src\vector\names.rs:49:24
|
49 | if name.len() == 0 {
| ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
warning: trait `Vector` has a `len` method but no (possibly inherited) `is_empty` method
--> crates\harp\src\vector\mod.rs:40:1
|
40 | / pub trait Vector {
41 | | type Type;
42 | | type Item: ?Sized;
43 | | const SEXPTYPE: u32;
... |
110 | | }
111 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\vector\mod.rs:47:5
|
47 | unsafe fn new_unchecked(object: impl Into<SEXP>) -> Self;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\vector\mod.rs:61:36
|
61 | fn get(&self, index: isize) -> Result<Option<Self::Type>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\vector\mod.rs:69:42
|
69 | fn get_value(&self, index: isize) -> Result<Self::Type> {
| ^^^^^^^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\vector\mod.rs:76:5
|
76 | / unsafe fn new(object: impl Into<SEXP>) -> Result<Self>
77 | | where
78 | | Self: Sized,
| |____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: the `Err`-variant returned from this function is very large
--> crates\harp\src\vector\mod.rs:76:47
|
76 | unsafe fn new(object: impl Into<SEXP>) -> Result<Self>
| ^^^^^^^^^^^^
|
::: crates\harp\src\error.rs:25:5
|
25 | / TryCatchError {
26 | | code: Option<String>,
27 | | message: String,
28 | | class: Option<Vec<String>>,
29 | | r_trace: String,
30 | | rust_trace: Option<Backtrace>,
31 | | },
| |_____- the largest variant contains at least 144 bytes
|
= help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\vector\mod.rs:85:5
|
85 | / unsafe fn with_length(size: usize) -> Self
86 | | where
87 | | Self: Sized,
| |____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\vector\mod.rs:93:5
|
93 | / unsafe fn create<T>(data: T) -> Self
94 | | where
95 | | T: IntoIterator,
96 | | <T as IntoIterator>::IntoIter: ExactSizeIterator,
97 | | <T as IntoIterator>::Item: AsRef<Self::Item>;
| |_____________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: unsafe function's docs are missing a `# Safety` section
--> crates\harp\src\vector\mod.rs:99:5
|
99 | unsafe fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
warning: `harp` (lib) generated 178 warnings
error: could not compile `harp` (lib) due to 80 previous errors; 178 warnings emitted
warning: build failed, waiting for other jobs to finish...
warning: unneeded `return` statement
--> crates\amalthea\src\comm\comm_manager.rs:57:9
|
57 | return comm_changed_rx;
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
57 - return comm_changed_rx;
57 + comm_changed_rx
|
warning: this function has too many arguments (8/7)
--> crates\amalthea\src\kernel.rs:102:5
|
102 | / pub fn connect(
103 | | &mut self,
104 | | shell_handler: Arc<Mutex<dyn ShellHandler>>,
105 | | control_handler: Arc<Mutex<dyn ControlHandler>>,
... |
118 | | stdin_reply_tx: Sender<crate::Result<InputReply>>,
119 | | ) -> Result<(), Error> {
| |__________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
warning: match expression looks like `matches!` macro
--> crates\amalthea\src\kernel.rs:390:13
|
390 | / match stdin_socket.socket.poll(zmq::POLLIN, 0) {
391 | | Ok(n) if n > 0 => true,
392 | | _ => false,
393 | | }
| |_____________^ help: try: `matches!(stdin_socket.socket.poll(zmq::POLLIN, 0), Ok(n) if n > 0)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
= note: `#[warn(clippy::match_like_matches_macro)]` on by default
warning: manual implementation of `Option::map`
--> crates\amalthea\src\kernel_dirs.rs:24:12
|
24 | } else if let Some(userpath) = jupyter_xdg_dir() {
| ____________^
25 | | Some(userpath)
26 | | } else {
27 | | None
28 | | }
| |_____^ help: try: `{ jupyter_xdg_dir().map(|userpath| userpath) }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
warning: manual implementation of `Option::map`
--> crates\amalthea\src\kernel_dirs.rs:35:5
|
35 | / if let Some(path) = dirs::data_dir() {
36 | | Some(path.join("jupyter"))
37 | | } else {
38 | | None
39 | | }
| |_____^ help: try: `dirs::data_dir().map(|path| path.join("jupyter"))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
warning: unneeded `return` statement
--> crates\amalthea\src\kernel_spec.rs:42:9
|
42 | return Err(Error::NoInstallDir);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
42 - return Err(Error::NoInstallDir);
42 + Err(Error::NoInstallDir)
|
warning: unneeded `return` statement
--> crates\amalthea\src\kernel_spec.rs:60:29
|
60 | ... return Err(Error::WriteSpecFailed(err));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
60 ~ Err(Error::WriteSpecFailed(err))
61 | } else {
...
65 | Err(err) => return Err(Error::CreateSpecFailed(err)),
66 ~ }
|
warning: unneeded `return` statement
--> crates\amalthea\src\kernel_spec.rs:62:29
|
62 | ... return Ok(dest);
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
62 ~ Ok(dest)
63 | }
64 | },
65 | Err(err) => return Err(Error::CreateSpecFailed(err)),
66 ~ }
|
warning: unneeded `return` statement
--> crates\amalthea\src\kernel_spec.rs:65:33
|
65 | Err(err) => return Err(Error::CreateSpecFailed(err)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
65 ~ Err(err) => Err(Error::CreateSpecFailed(err)),
66 ~ }
|
warning: unneeded `return` statement
--> crates\amalthea\src\kernel_spec.rs:69:17
|
69 | return Err(Error::JsonSerializeSpecFailed(err));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
69 - return Err(Error::JsonSerializeSpecFailed(err));
69 + Err(Error::JsonSerializeSpecFailed(err))
|
warning: unneeded `return` statement
--> crates\amalthea\src\socket\control.rs:119:9
|
119 | return result;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
119 - return result;
119 + result
|
warning: using `clone` on type `Duration` which implements the `Copy` trait
--> crates\amalthea\src\socket\iopub.rs:113:30
|
113 | let flush_interval = StreamBuffer::interval().clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*StreamBuffer::interval()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
warning: unneeded `return` statement
--> crates\amalthea\src\socket\iopub.rs:326:9
|
326 | / return StreamBuffer {
327 | | name,
328 | | buffer: Vec::new(),
329 | | };
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
326 ~ StreamBuffer {
327 + name,
328 + buffer: Vec::new(),
329 ~ }
|
warning: using `clone` on type `Stream` which implements the `Copy` trait
--> crates\amalthea\src\socket\iopub.rs:345:19
|
345 | name: self.name.clone(),
| ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
warning: returning the result of a `let` binding from a block
--> crates\amalthea\src\socket\shell.rs:236:17
|
235 | let r = req.send_reply(reply, &self.socket);
| -------------------------------------------- unnecessary `let` binding
236 | r
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
235 ~
236 ~ req.send_reply(reply, &self.socket)
|
warning: module has the same name as its containing module
--> crates\amalthea\src\socket\mod.rs:13:1
|
13 | pub mod socket;
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
warning: unneeded `return` statement
--> crates\amalthea\src\wire\jupyter_message.rs:224:9
|
224 | return Err(Error::UnknownMessageType(kind));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
224 - return Err(Error::UnknownMessageType(kind));
224 + Err(Error::UnknownMessageType(kind))
|
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates\amalthea\src\wire\jupyter_message.rs:298:20
|
298 | reply.send(&socket)
| ^^^^^^^ help: change this to: `socket`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates\amalthea\src\wire\jupyter_message.rs:308:20
|
308 | reply.send(&socket)
| ^^^^^^^ help: change this to: `socket`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
warning: the borrowed expression implements the required traits
--> crates\amalthea\src\wire\wire_message.rs:149:41
|
149 | let decoded = match hex::decode(&data) {
| ^^^^^ help: change this to: `data`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates\amalthea\src\wire\wire_message.rs:163:35
|
163 | hmac_validator.update(&buf);
| ^^^^ help: change this to: `buf`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates\amalthea\src\wire\wire_message.rs:178:45
|
178 | let str = match std::str::from_utf8(&buf) {
| ^^^^ help: change this to: `buf`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates\amalthea\src\wire\wire_message.rs:224:32
|
224 | sig.update(&part);
| ^^^^^ help: change this to: `part`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
warning: useless conversion to the same type: `std::string::String`
--> crates\amalthea\src\wire\wire_message.rs:277:28
|
277 | return String::from(format!("comm_msg/{comm_id}/{comm_msg_type}"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("comm_msg/{comm_id}/{comm_msg_type}")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
warning: useless conversion to the same type: `std::string::String`
--> crates\amalthea\src\wire\wire_message.rs:283:32
|
283 | return String::from(format!("status/{execution_state}"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("status/{execution_state}")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates\amalthea\src\wire\wire_message.rs:303:43
|
303 | return Self::comm_msg_id_type(&id);
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
warning: unneeded `return` statement
--> crates\amalthea\src\wire\wire_message.rs:327:9
|
327 | return id.to_string();
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
327 - return id.to_string();
327 + id.to_string()
|
warning: `amalthea` (lib) generated 27 warnings (run `cargo clippy --fix --lib -p amalthea` to apply 24 suggestions)
Raw
summary.txt
❯ grep -o -E 'https://.*index.html#.+' tmp.txt | sort | uniq -c
10 https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
2 https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
1 https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
1 https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
2 https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def
1 https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
1 https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
2 https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
4 https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
3 https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
1 https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
2 https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
2 https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
43 https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
1 https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
11 https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
3 https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
4 https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
5 https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
39 https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
1 https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
80 https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
1 https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
7 https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
1 https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
3 https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
61 https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
4 https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
2 https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
1 https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
1 https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
2 https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
4 https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
3 https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
1 https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment