Skip to content

Instantly share code, notes, and snippets.

@zewa666
Created January 24, 2018 17:07
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save zewa666/f936db5803df06707e6b7487e3bf3856 to your computer and use it in GitHub Desktop.
Save zewa666/f936db5803df06707e6b7487e3bf3856 to your computer and use it in GitHub Desktop.
Patched changes for nested translations
diff --git a/translation-errors/src/app.html b/translation-errors/src/app.html
index 652a131..4325f84 100644
--- a/translation-errors/src/app.html
+++ b/translation-errors/src/app.html
@@ -5,11 +5,10 @@
</select>
<h2>This paragraph does not update when locale changes</h2>
- <p t="[html]tracking-report.span9" t-params.bind="{rowNumber: report.rowNumber, sick: report.sick, dead: report.dead, reason: trSicknessReason(report.reason)}">
+ <p t="[html]tracking-report.span8" t-params.bind="{rowNumber: report.rowNumber, sick: report.sick, dead: report.dead}">
</p>
<h2 class="mt-5">This paragraph updates, but returns unescaped report.reason</h2>
- <p>
- ${"tracking-report.span9" & t: {rowNumber: item.rowNumber, sick: report.sick, dead: report.dead, reason: trSicknessReason(report.reason)}}.
+ <p innerhtml.bind="'tracking-report.span9' & t: {rowNumber: report.rowNumber, sick: report.sick, dead: report.dead, reason: trSicknessReason(report.reason)}"></p>
</p>
</template>
diff --git a/translation-errors/src/app.ts b/translation-errors/src/app.ts
index fba89f0..1350734 100644
--- a/translation-errors/src/app.ts
+++ b/translation-errors/src/app.ts
@@ -35,7 +35,7 @@ export class App {
public trSicknessReason(sicknessReason: IListItem) {
const reason = this.sicknessReasons.find(c => c.id === sicknessReason.id);
-
+ console.log("foo);");
return this.trDictionaryTranslation(reason).toLowerCase();
}
diff --git a/translation-errors/src/locales/en/translation.json b/translation-errors/src/locales/en/translation.json
index 760378c..b89683e 100644
--- a/translation-errors/src/locales/en/translation.json
+++ b/translation-errors/src/locales/en/translation.json
@@ -1,5 +1,7 @@
{
"tracking-report": {
- "span9": "In row {{rowNumber}}, there were {{sick}} sick and {{dead}} dead plants due to <strong>{{reason}}</strong>"
+ "span9": "In row {{rowNumber}}, there were {{sick}} sick and {{dead}} dead plants due to <strong>{{reason}}</strong>",
+ "span8": "In row {{rowNumber}}, there were {{sick}} sick and {{dead}} dead plants due to <strong>$t(tracking-report.reason)</strong>",
+ "reason": "Lack of nitrogen"
}
}
diff --git a/translation-errors/src/locales/fr/translation.json b/translation-errors/src/locales/fr/translation.json
index 0ad5a48..8bff224 100644
--- a/translation-errors/src/locales/fr/translation.json
+++ b/translation-errors/src/locales/fr/translation.json
@@ -1,5 +1,7 @@
{
"tracking-report": {
- "span9": "Dans la rangée {{rowNumber}}, il y avait {{sick}} plantes malades et {{dead}} morts à cause de <strong>{{reason}}</strong>"
+ "span9": "Dans la rangée {{rowNumber}}, il y avait {{sick}} plantes malades et {{dead}} morts à cause de <strong>{{reason}}</strong>",
+ "span8": "Dans la rangée {{rowNumber}}, il y avait {{sick}} plantes malades et {{dead}} morts à cause de <strong>$t(tracking-report.reason)</strong>",
+ "reason": "Manque d'Azote"
}
}
diff --git a/translation-errors/src/locales/pt/translation.json b/translation-errors/src/locales/pt/translation.json
index aed0a82..0b63a38 100644
--- a/translation-errors/src/locales/pt/translation.json
+++ b/translation-errors/src/locales/pt/translation.json
@@ -1,5 +1,7 @@
{
"tracking-report": {
- "span9": "Na fila {{rowNumber}} - havia {{sick}} plantas doentes e {{dead}} mortos devido a <strong>{{reason}}</strong>"
+ "span9": "Na fila {{rowNumber}} - havia {{sick}} plantas doentes e {{dead}} mortos devido a <strong>{{reason}}</strong>",
+ "span8": "Na fila {{rowNumber}} - havia {{sick}} plantas doentes e {{dead}} mortos devido a <strong>$t(tracking-report.reason)</strong>",
+ "reason": "Falta de nitrogenio"
}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment