Skip to content

Instantly share code, notes, and snippets.

@zhukovsd

zhukovsd/@Super_star_for_IT Hangman in Kotlin review notes.md Secret

Last active September 7, 2023 07:48
Show Gist options
  • Save zhukovsd/4c1c09da0357b921b522365ebd628203 to your computer and use it in GitHub Desktop.
Save zhukovsd/4c1c09da0357b921b522365ebd628203 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
@Super_star_for_IT Hangman in Kotlin review notes.md

https://github.com/belgrano82/Hangman-in-Kotlin

  • Gradle config required fixing - Could not read 'https://api.adoptopenjdk.net/v3/binary/latest/8/ga/mac/aarch64/jdk/hotspot/normal/adoptopenjdk' as it does not exist

Code

  • GameLoop needs to create Dictionary
  • MaskedWord does not store state
  • when(true)?
  • if (mistakes == 6) break
  • game loop method too long
  • extra while?
  • empty input causes an exception

Small things

  • isRussianLetter can be static
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment