Skip to content

Instantly share code, notes, and snippets.

@zoepage
Created August 24, 2016 12:52
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save zoepage/d6041c7cdb6d1ee7474d4bd5c1c3ccb6 to your computer and use it in GitHub Desktop.
Save zoepage/d6041c7cdb6d1ee7474d4bd5c1c3ccb6 to your computer and use it in GitHub Desktop.
# Currently blocking
Google Fonts
-----
the [script to add fonts](https://gist.github.com/mousemke/80df3ee66973fae8171ad748a21d5e2e) is actually written, but what fonts are we using / allowing? where are they being set? where is the info coming from?
--> we are loading all of the font names for the dropdown menue
when google fonts are blocked, (adblock, ghostery, etc) we need a fallback to a good system font stack.
--> selina preps fallback list
which fonts do we allow? with a curated list we can actually decide the appropriate fallback fonts, but if all are alowed there is no way we can know which fonts will be a similar fallback
--> just google fonts
check font scales vs base unit
--> should fit
2 images or products without the other
------
we can currently use 1 image and 1 product, but what if it isn't that straight forward. What if we need 2 images and no products? what if we need 2 products and no images? What if [insert future scenario here]? We need the flexibility to handle multiples at a time. However, that may make us need to re-examine how we calculate dimentions. We currently have no ability to calculate the space that multiple images together will take up (including gutters, etc), which meand we will have to see what's in the story, then render parts, then decide the part of the schema after that.
problems to solve:
+ determine how many images and products there are and which use cases we're talking about
+ 2 images / no products
+ 0 images / up to 2 products
+ determine the size of the combined image and / or products section
+ right now it takes the raw image height and width. this will not be possible.
+ images will have to be normalized for size, combined with margins, then fed back to the LayoutSchema
--> TBA / FR
intro text
----
we already break off the first paragraph as the intro. This seems much cleaner than breaking off an arbitrary amount of words. Not sure where to push on this
+ [introText](https://github.com/styladev/layoutEngine/blob/master/app/utils/storyConverter.js#L20)
+ [feed-intro-text-should-be-35-85-words](https://trello.com/c/IGJtrpDW/11-feed-intro-text-should-be-35-85-words)
related stories
------
this works but the widget needs to be updated to work with the new feed
+ [PR](https://github.com/styladev/layoutEngine/pull/43)
+ [add-related-stories-widget](https://trello.com/c/CiAsQ1rV/6-stp-add-related-stories-widget)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment