- Make sure you are aware of the problem/feature.
- Don't be rude, be polite.
- Give suggestions and make clear why do you think you suggestion is better than the current approach.
- Don't point out just the bad things, tell about what do you think is great as well.
- Make it part of your daily workflow. (use github notifications)
- http://www.dein.fr/2015-02-18-maslows-pyramid-of-code-review.html
-
-
Save NKjoep/3638b443d92cec1c8fab22998d9263cf to your computer and use it in GitHub Desktop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment