Skip to content

Instantly share code, notes, and snippets.

@RoastedRowlet

RoastedRowlet/augmentation-log-issues.md

Forked from ljosberinn/augmentation-log-issues.md
Last active November 27, 2023 17:30
Show Gist options
  • Save RoastedRowlet/e467b23ef05ba98b53ab8edab6cc4357 to your computer and use it in GitHub Desktop.
Save RoastedRowlet/e467b23ef05ba98b53ab8edab6cc4357 to your computer and use it in GitHub Desktop.
Download ZIP
Augmentation Log Issues
Raw
augmentation-log-issues.md

This list is continously updated whenever we confirm findings.

Log hooks are provided by Blizzard. WCL cannot fix it.

Maintained by the WCL Team. If you have any question, additions or updates, please reach out on our Discord or dm me (xepher1s). Thanks to all the folks helping spotting these and reporting them.

Last updated: Nov 27. Click for an overview of changes

FAQ

What does this mean for me as affected spec that gets buffed or as Augmentation Evoker?

Basically, this inflates the buffed players throughput. Not all of what they owe to the buffing Evoker gets reassigned because the combat log simply doesn't tell us.

As example, one week they may get buffed by 2 Evokers and will have a good parse as result. The next week, they perform at around the same level, but don't get buffed at all. Their resulting performance will be (possibly significantly) worse because they are competing with players that may have dedicated Evokers buffing them specifically or accidentally, and of course their past self.

Why is this problematic? Depending on the degree of lack of reattribution, both parties have a significantly harder time to evaluate their performance:

  • the Evokers throughput is combined into other players throughput making it harder to tell who is a good target to buff & when & why
  • other players throughput is inflated making it harder for them to e.g. compare cooldown windows

Depending on factors such as tuning, raid composition and individual player skill it may however be the better play to intentionally buff badly reattributing specs. After all, what matters is that you contribute to downing that boss.

How to Spot a Lack of Reattribution
  • obviously the first step is to make sure the player received any buffs. theres multiple ways to do so but the easiest is to just hover a players throughput column and see whether it has a tooltip:

image

  • if not, then this player was not buffed at all.
  • if so, click the buffed player and hover the DPS column. for a reattributing ability, it should look similar to this depending on how frequently they were buffed:

image

  • an ability not reattributing simply wont have this tooltip

image

  • now this is a bit more tricky. each ability that reattributes should have a reattributing event basically directly after the initial event. there may be minor delay but usually they are share the same timestamp.

  • do note that certain things are expected to not reattribute, most notably all non-class/spec specific spells shouldn't, e.g. trinkets or embellishments

Reattribution problems

What is reattribution and how does it work?

Reattribution is what we call the process of reassigning throughput from a buffed player to the implicit origin, the buffing Evoker.

Blizzard themselves are providing the tools for this via the combat log file. Addons in game have also access to a combat log, but it sees different things than what's in the file. Addons however have no access to the file, which is why addons cannot reattribute ingame.

How does it work?

The process is relatively simple, but this is technical so buckle up. The combat log is effectively just a text file, each line is an event and events come in different sizes and shapes, for example SPELL_DAMAGE or ENCOUNTER_START.

Let's start with an unbuffed player and how a simplified combat log could look for them:

1, SPELL_DAMAGE, Vollmer-Ragnaros, 120, 20, 1

which translates to:

timestamp: 1
type: SPELL_DAMAGE
player: Vollmer-Ragnaros
damage done: 120
mitigated: 20
ability id: 1

In above example, Vollmer used ability 1 (melee) to do 120 damage of which 20 were mitigated, so 100 effective damage.

If Vollmer would've been buffed, it'd look like this:

1, SPELL_DAMAGE, Vollmer-Ragnaros, 138, 23, 1
1, SPELL_DAMAGE_SUPPORT, Xephyris-Blackrock, Vollmer-Ragnaros, 18, 3, 395152

which translates to:

timestamp: 1
type: SPELL_DAMAGE_SUPPORT
player: Xephyris-Blackrock
buffed player: Vollmer-Ragnaros
damage done: 18
mitigated: 3
ability id: 395152

which states that Xephyris did 18 damage via the spell 395152 (Ebon Might), which in turn means, these 18 should be deducated from Vollmer (138 - 18 => 120 like before).

The ongoing reattribution issues have multiple facettes:

  • events missing entirely: a specific spell scales with main stat but simply doesn't result in _SUPPORT events
    • there's subcases of spells that should conditionally reattribute but currently don't. e.g. shadow priest will do more damage via Shadowy Apparitions via a talent because of procs from crit. some of these crits will be due to Prescience. Thus some Shadowy Apparitions damage should be reattributed. This is likely not as straight forward as just main stat scaling and also probably within the margin of error in the grand scope.
  • events missing for a specific buff: a specific spells scales with main stat and should reattribute e.g. Ebon Might, but doesn't. the spell properly reattributes for Prescience however
  • events sometimes missing, e.g. under specific circumstances: a specific spell doesn't reattribute all the time but should, e.g. fully absorbed hits don't reattribute currently (see below)
  • events claiming too much: a specific spell claims very obviously too much, e.g. 100% of the origin events value
  • events claiming too little: a specific spell claims very obviously too little, e.g. negative values
  • events effectively empty: a specific spell (sometimes) simply has no value. not 0, just no value at all
  • events sent when they shouldn't: the player isn't buffed anymore and hasn't been for a considerable time so it can't be projectiles being fired when a buff was still present

General bugs

Empty Support Events

https://www.warcraftlogs.com/reports/X2yBtArq6RbVkD1Z#fight=5&type=damage-done&start=1285631&end=1285631&view=events

Note how these:

image

are not only empty but also, the hunter does not have Shifting Sands from these evokers at the time:

image

Abilities not reattributing anything

We'll try to provide examples for each but this list grew over a couple of months so bear with us while we don't have examples for all.

Racials

Warrior

  • Finishing Wound (id 426284)

Rogue

  • Blade Flurry (id 22482)
  • Shadow Blades (id 279043)
  • Soulreave (id 409605) and Soulrip (id 409604) -- both components of Aberrus T30 so not terribly important at this point
  • Sanguine Blades (id 423193)
  • Poisoned Edges (id 409483)
  • Caustic Splatter (id 421979)
  • Sudden Demise (id 343769)

Hunter

  • Beast Cleave (id 118459) reattributes since Nov 22
  • Kill Cleave reattributes since Nov 22

Demon Hunter

Warlock

Shaman

  • Lightning Rod
  • Earthquake

Druid

Monk

  • Boneduest Brew (id 325217)
  • Charred Passions (id 386959)

Mage

  • Glacial Blast (id 424120) -- should NOT reattribute Prescience but EM and SS

Other

  • Timestrike (id 419737) does not reattribute anything

Abilities not reattributing Ebon Might

Warrior

  • Fatal Mark (id 383706)

Shaman

Hunter

Demon Hunter

  • Sigil of Flame DoT fixed on or before Nov 16

Death Knight

  • Death Coil DoT

Abilities not reattributing Shifting Sands

Paladin

Druid

  • Feral Frenzy (id 274838) is not reattributing its bleed. the initial hit works. it's a bit harder to spot but note how after each non-tick event, an Ebon Might reattribution event is present for the same millisecond, but for the ticks, there's none. also note that it's not possible to limit reattribution to a specific ability, so its showing other damage reattribution in here too, meaning that the next Ebon Might event that is delayed by e.g. 50 milliseconds at 01:48.488 is from another damage source. the matching EM event should be at 01:48.434 like Shifting Sands and Prescience are.
  • Brambles (id 203958)

Special cases

Priest

  • Prescience does not work with Shadowy Apparitions or Tormented Spriits

Warlock

  • Prescience does not seem to increase Chaos Bolt damage

Hunter

  • Master Marksman(id 269576) seems to be underattributing heavily; example log, only 297/6282 (~4.7%) are reattributed

Druid

  • Ebon Might in a rare case is heavily over attributing resto druid's healing. Looks like ebon might just reports that ebon might is healing just as much as the original heal on all HoT ticks. Initial heal for regrowth/swiftmend seem fine. example log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment