Skip to content

Instantly share code, notes, and snippets.

@ljosberinn
Last active May 8, 2024 21:02
Show Gist options
  • Star 1 You must be signed in to star a gist
  • Fork 1 You must be signed in to fork a gist
  • Save ljosberinn/a2f08a53cfe8632a18350eea44e9da3e to your computer and use it in GitHub Desktop.
Save ljosberinn/a2f08a53cfe8632a18350eea44e9da3e to your computer and use it in GitHub Desktop.
Augmentation Log Issues

This list is continously updated whenever we confirm findings.

Log hooks are provided by Blizzard. WCL cannot fix it.

Maintained by the WCL Team. If you have any question, additions or updates, please reach out on our Discord or dm me (xepher1s). Thanks to all the folks helping spotting these and reporting them.

Last updated: May 8. Click for an overview of changes

FAQ

What does this mean for me as affected spec that gets buffed or as Augmentation Evoker?

Basically, this inflates the buffed players throughput. Not all of what they owe to the buffing Evoker gets reassigned because the combat log simply doesn't tell us.

As example, one week they may get buffed by 2 Evokers and will have a good parse as result. The next week, they perform at around the same level, but don't get buffed at all. Their resulting performance will be (possibly significantly) worse because they are competing with players that may have dedicated Evokers buffing them specifically or accidentally, and of course their past self.

Why is this problematic? Depending on the degree of lack of reattribution, both parties have a significantly harder time to evaluate their performance:

  • the Evokers throughput is combined into other players throughput making it harder to tell who is a good target to buff & when & why
  • other players throughput is inflated making it harder for them to e.g. compare cooldown windows

Depending on factors such as tuning, raid composition and individual player skill it may however be the better play to intentionally buff badly reattributing specs. After all, what matters is that you contribute to downing that boss.

How to Spot a Lack of Reattribution
  • obviously the first step is to make sure the player received any buffs. theres multiple ways to do so but the easiest is to just hover a players throughput column and see whether it has a tooltip:

image

  • if not, then this player was not buffed at all.
  • if so, click the buffed player and hover the DPS column. for a reattributing ability, it should look similar to this depending on how frequently they were buffed:

image

  • an ability not reattributing simply wont have this tooltip

image

  • now this is a bit more tricky. each ability that reattributes should have a reattributing event basically directly or very close after the initial event. there may be minor delay but usually they are share the same timestamp.

  • do note that certain things are expected to not reattribute:

    • embellishments and trinkets don't scale with main stat, so no Ebon Might reattribution
    • abilities that are guaranteed to crit e.g. during Combustion or Lava Burst should not reattribute Prescience

Reattribution problems

What is reattribution and how does it work?

Reattribution is what we call the process of reassigning throughput from a buffed player to the implicit origin, the buffing Evoker.

Blizzard themselves are providing the tools for this via the combat log file. Addons in game have also access to a combat log, but it sees different things than what's in the file. Addons however have no access to the file, which is why addons cannot reattribute ingame.

How does it work?

The process is relatively simple, but this is technical so buckle up. The combat log is effectively just a text file, each line is an event and events come in different sizes and shapes, for example SPELL_DAMAGE or ENCOUNTER_START.

Let's start with an unbuffed player and how a simplified combat log could look for them:

1, SPELL_DAMAGE, Vollmer-Ragnaros, 120, 20, 1

which translates to:

timestamp: 1
type: SPELL_DAMAGE
player: Vollmer-Ragnaros
damage done: 120
mitigated: 20
ability id: 1

In above example, Vollmer used ability 1 (melee) to do 120 damage of which 20 were mitigated, so 100 effective damage.

If Vollmer would've been buffed, it'd look like this:

1, SPELL_DAMAGE, Vollmer-Ragnaros, 138, 23, 1
1, SPELL_DAMAGE_SUPPORT, Xephyris-Blackrock, Vollmer-Ragnaros, 18, 3, 395152

which translates to:

timestamp: 1
type: SPELL_DAMAGE_SUPPORT
player: Xephyris-Blackrock
buffed player: Vollmer-Ragnaros
damage done: 18
mitigated: 3
ability id: 395152

which states that Xephyris did 18 damage via the spell 395152 (Ebon Might), which in turn means, these 18 should be deducated from Vollmer (138 - 18 => 120 like before).

The ongoing reattribution issues have multiple facettes:

  • events missing entirely: a specific spell scales with main stat but simply doesn't result in _SUPPORT events
    • there's subcases of spells that should conditionally reattribute but currently don't. e.g. shadow priest will do more damage via Shadowy Apparitions via a talent because of procs from crit. some of these crits will be due to Prescience. Thus some Shadowy Apparitions damage should be reattributed. This is likely not as straight forward as just main stat scaling and also probably within the margin of error in the grand scope.
  • events missing for a specific buff: a specific spells scales with main stat and should reattribute e.g. Ebon Might, but doesn't. the spell properly reattributes for Prescience however
  • events sometimes missing, e.g. under specific circumstances: a specific spell doesn't reattribute all the time but should, e.g. fully absorbed hits don't reattribute currently (see below)
  • events claiming too much: a specific spell claims very obviously too much, e.g. 100% of the origin events value
  • events claiming too little: a specific spell claims very obviously too little, e.g. negative values
  • events effectively empty: a specific spell (sometimes) simply has no value. not 0, just no value at all
  • events sent when they shouldn't: the player isn't buffed anymore and hasn't been for a considerable time so it can't be projectiles being fired when a buff was still present

General bugs

Full Absorbs do not reattribute fixed as of Patch 10.2.7

Negative Reattribution

Friendly Fire can reattribute

Healing Reattribution is often broken for any hot

Reattribution does not factor in throughput-increasing non-player originating auras

  • player buffs and debuffs increasing throughput such as orbs on Smolderon, P2 of last boss Throne of the Tides, P2 of last boss Black Rook Hold are not factored into reattribution events of Shifting Sands, meaning too little throughput is subtracted from buffed targets

Empty Support Events

https://www.warcraftlogs.com/reports/X2yBtArq6RbVkD1Z#fight=5&type=damage-done&start=1285631&end=1285631&view=events

Note how these:

image

are not only empty but also, the hunter does not have Shifting Sands from these evokers at the time:

image

Other

  • Prescience sometimes claims the entire damage of the origin ability for a short period of time
  • Breath of Eons sometimes doesn't extend Ebon Might fixed Nov 29
  • Prescience can claim damage even if the origin damage wasn't actually a crit. Discovered Dec 15, but present since July 25. example false positive! this is intentional for special cases such as a crit triggering Blade Flurry/Ignite/Caustic Splatter/Sanguine Blades-like abilities that don't crit. Prescience will then tax appropriately, but as non-crit

Abilities not reattributing anything

We'll try to provide examples for each but this list grew over a couple of months so bear with us while we don't have examples for all.

Racials

Warrior

  • Finishing Wound (id 426284)

Rogue

  • Blade Flurry (id 22482) reattributes as of Dec 13
  • Shadow Blades (id 279043) reattributes as of Dec 13
  • Soulreave (id 409605) and Soulrip (id 409604) -- both components of Aberrus T30 so not terribly important at this point
  • Sanguine Blades (id 423193) reattributes as of Dec 13
  • Poisoned Edges (id 409483)
  • Caustic Splatter (id 421979) reattributes as of Nov 29
  • Sudden Demise (id 343769)
  • Envenomous Explosion (id 426581) reattributes as of Nov 29
  • Shadow Eviscerate (id 424491) reattributes as of Jan 23 (probably fixed with 10.2.5)

Hunter

  • Beast Cleave (id 118459) reattributes since Nov 22
  • Kill Cleave reattributes since Nov 22

Demon Hunter

  • Soulscar (id 390181)
  • Ragefire (id 390197)
  • Chaotic Disposition (id 428493) has been reworked into a buff instead
  • The Hunt (id 370971) - healing
  • Charred Warblades (id 213011) - healing

Warlock

Shaman

  • Lightning Rod
  • Ancestral Guidance (id 114911)

Druid

  • Frenzied Assault (id 391140) partially fixed in the week of April 14. The buff source is logging incorrectly, so it appears as if the druid was buffing themselves with whichever Aug buffs they were buffed at the time.
  • Burning Frenzy (id 422779) partially fixed in the week of April 14. The buff source is logging incorrectly, so it appears as if the druid was buffing themselves with whichever Aug buffs they were buffed at the time.
  • Tear (id 391356)

Monk

  • Boneduest Brew (id 325217)
  • Charred Passions (id 386959)
  • Charred Dreams (id 425299)
  • melee hits as Mistweaver
  • note that these below may be reattributing Shifting Sands and it's based on a key log where naturally no sands were on the mw
  • Ancient Teachings (ids 388024, 388025)
  • Chi Harmony (id 423458)
  • Ancient Protection (id 429271)
  • Soothing Mist (id 115175)

Mage

  • Glacial Blast (id 424120) -- should NOT reattribute Prescience but Ebon Might and Shifting Sands

Priest

  • melee as disc priest -- for completeness sake I suppose...
  • Vampiric Embrace (id 15290) - healing
  • Devouring Plague (id 335467) - healing
  • Vampiric Touch (id 34914) - healing
  • Mindgames (ids 375902, 375904) - healing
  • Halo (id 390971) - healing
  • Binding Heal (id 368276)
  • Sanctuary (id 208771)

Shaman

  • Lava Slag (id 427729) T31 4pc
  • melee for Elemental -- for completeness sake

Paladin

  • Cleansing Flame (ids 425261, 425262) T31 4pc
  • Shield of Vengeance (id 184689) -- unsure if this should reattribtue Ebon Might, but it certainly scales with vers and should reattribute Shifting Sands
  • Blessed Hammer (id 229976) doesn't reattribute healing
  • Bulwark of Order (id 209388)

Other

  • Timestrike (id 419737) does not reattribute anything
  • Leech is not reattributing anything but is arguably low priority

Abilities not reattributing Ebon Might

Warrior

  • Fatal Mark (id 383706)

Shaman

Hunter

  • Kill Command (id 83381)
    • Kill Command sourced to BM / Survival hunter reattribute since Nov 21
    • Kill Command sourced to Dire Beasts reattributes since Nov 29
  • Claw fixed on or before Nov 21
  • Kill Cleave can stop reattributing Ebon Might for the remainder of a key (and presumably similarily in raid until zoning out) if the main pet dies and gets rezzed
  • bm hunters can underattribute regardless of above fixes when the main pet loses its internal reattribution status somehow
    • sounds obscure but the devs are aware

Druid

  • Tear Open Wounds (id 391786) -- also does not reattribute Shifting Sands, see below
  • Tear (id 391356) -- also does not reattribute Shifting Sands, see below

Demon Hunter

  • Sigil of Flame DoT fixed on or before Nov 16

Death Knight

  • Death Coil DoT

Warlock

  • Soul Cleave (id 387502) via Fel Guard

Paladin

  • melee as holy paladin. note this is different to melee from mistweaver which indeed does not reattribute anything, while hpal reattributes Shifting Sands and Prescience

Shaman

  • Earthquake (id 77478)

Rogue

  • Shadow Rupture (id 424493) only reattributes Prescience

Warrior

  • Fervid Bite (id 425534) only reattributes Prescience, see below

Abilities not reattributing Shifting Sands

Paladin

Warrior

  • Fervid Bite (id 425534) only reattributes Prescience, see above

Druid

  • Feral Frenzy (id 274838) is not reattributing its bleed. the initial hit works. it's a bit harder to spot but note how after each non-tick event, an Ebon Might reattribution event is present for the same millisecond, but for the ticks, there's none. also note that it's not possible to limit reattribution to a specific ability, so its showing other damage reattribution in here too, meaning that the next Ebon Might event that is delayed by e.g. 50 milliseconds at 01:48.488 is from another damage source. the matching EM event should be at 01:48.434 like Shifting Sands and Prescience are. reattributing presumably since 10.2.5
  • Brambles (id 203958)
  • Tear Open Wounds (id 391786) -- also does not reattribute Ebon Might, see above
  • Tear (id 391356) -- also does not reattribute Ebon Might, see above

Rogue

  • Shadow Rupture (id 424493) only reattributes Prescience, see above

Hunter

  • there seem to be general reattribution problems for BM hunters with SS.
    • in this log, Havoc and BM have roughly the same uptime (9% difference)
    • yet Havoc - which at this time is still heavily underattributing due to Ragefire and Soulscar not reattributing anything - gains 22.98k dps from SS, while the Hunter gains only 14.23k (~38% difference)
    • both do gain roughly the same from Ebon Might: Hunter 14.91k <-> Havoc 15.66k
    • note that the culprit seem to be pet-sourced abilities. reattribution for damage sourced to the hunter has usually Shifting Sands dominating, but for pets its always behind Ebon Might

Special cases

Priest

  • Prescience does not work with Shadowy Apparitions or Tormented Spriits

Warlock

  • Prescience does not seem to increase Chaos Bolt damage

Hunter

  • Master Marksman(id 269576) seems to be underattributing heavily; example log, only 297/6282 (~4.7%) are reattributed

Death Knight

  • Gargoyle Strike (id 51963) seems to be unterattributing Shifting Sands heavily:

    • Ebon Might takes 7.2%
    • Shifting Sands takes 1.3%
    • Prescience takes 4.1%

    image

@RoastedRowlet
Copy link

RoastedRowlet commented Nov 27, 2023

I added a section in my fork for resto druid in the special cases.

https://gist.github.com/RoastedRowlet/e467b23ef05ba98b53ab8edab6cc4357#druid-2

might be worth to add. (cant pull request a gist)

@ljosberinn
Copy link
Author

ljosberinn commented Nov 27, 2023

hi @RoastedRowlet this is already present under General Bugs - 2nd to last point. its not only resto, its all hots. thank you for keeping an eye out however and keep it coming :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment