Sequoia

Why Is It Bad To Export Functions Exclusively For Testing?

ℹ️ Summary: Test the destination, not the route.

We have a module that doubles numbers. It does this by bit-shifting the supplied number once left.

// double.js

// exported to allow testing...

Sequoia

Version 4

Type: Bug 🐞 || Feature 🚀

• 🏷 JIRA Ticket: EXP-
• 🚩 Feature Flag:

🌞 From a high level, what is this PR for?

(one sentence summary)

Sequoia

// Key Value Server
package main

import (
	"fmt"
	"log"
	"net/http"
	"encoding/json"
	"sync"
	"strings"

Sequoia

#include <unistd.h>
#include <node.h>
#include <string.h>
#include <v8.h>

using namespace v8;

unsigned long long count = 0;

// native blocking/compute intensive function

Sequoia

import Promise from 'bluebird';
import {readFiles} from 'node-dir';
import {l} from './util';

/**
 * @param {String} root path
 * @param {Object} options see: https://www.npmjs.com/package/node-dir
 * @return {Promise<String[]>}
 */
export default function getFiles(root, options){

Sequoia

const Rx = require('rxjs');
const debug = require('debug');

const chokidar = require('chokidar');
const dirWatcher = chokidar.watch('./_data/*.md');

const readFile = require('fs').readFile;
const readFileAsObservable = Rx.Observable.bindNodeCallback(readFile);

const newFiles     = Rx.Observable.fromEvent(dirWatcher, 'add');

Sequoia

{
  "$schema" : "http://json-schema.org/draft-04/schema#",
  "id": "https://gist.githubusercontent.com/Sequoia/d86032bff4413759c2f27e9cf852817b/raw/demo-schema.json",
  "title": "More than one type",
  "description": "This schema has a single property with multiple types",
  "definitions" : {
    "specialString" : {
      "type" : "string",
      "description": "(3) The String One!",
      "enum" : ["yes", "no", "maybe"]

Sequoia

Sequoia

I'm working with Leaflet.js & Leaflet-Editable.js there are a lot places where I need to respond to clicks on, creation of, etc. different types of map features differently. This function allows me to eschew if,else,if,else blocks for these cases.

Example:

Before

if(is(L.Marker, feature)){
  setMarkerStyleActive(feature);
} else if(is(L.Polyline, feature)){
  setPolylineStyleActive(feature);

Sequoia

  /**
  * @return {Promise}
  * @fulfill {Array} [{HomeActivityEvent}] array of digest sent events
  */
  Agent.sendDigestToClients = function(id){
    let recordid;
    return Agent.findById(id)
      .then(function(agent){
        recordid = agent.id;
        return agent;