Skip to content

Instantly share code, notes, and snippets.

@SethTisue
Last active April 23, 2020 04:28
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save SethTisue/16a53b061754dd0f0073193263b6ba2b to your computer and use it in GitHub Desktop.
Save SethTisue/16a53b061754dd0f0073193263b6ba2b to your computer and use it in GitHub Desktop.
@joroKr21
Copy link

Plug many variance holes (pos and neg)

The "(pos and neg)" part doesn't sound great but I'm not sure how to express that there are fixes both in code that should have compiled and in code that should not have compiled. Or if that needs to be expressed at all.

I think it's better to say briefly what has been fixed:

Plug many variance holes (in higher-kinded types, refined types and private inner classes)

I have edited the PR title accordingly.

@SethTisue
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment