Skip to content

Instantly share code, notes, and snippets.

Aaron Jensen aaronjensen

Block or report user

Report or block aaronjensen

Hide content and notifications from this user.

Learn more about blocking users

Contact Support about this user’s behavior.

Learn more about reporting abuse

Report abuse
View GitHub Profile
View v3-drawing.patch
From a55e5259341e054023727de4dc86b77c7a7d5db6 Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Mon, 29 Oct 2018 15:37:35 +0000
Subject: [PATCH v3] Fix more drawing bugs in NS port (bug#32932)
* src/nsterm.m (ns_row_rect): New function.
(ns_clip_to_row): Remove function.
(ns_copy_bits): Fix mistake.
(ns_shift_glyphs_for_insert): Mark the frame as dirty instead of
directly copying.
View new-drawing.patch
From 60e87aa179c31ee9045ab0bd473e4b69c3d3f984 Mon Sep 17 00:00:00 2001
From: Aaron Jensen <aaronjensen@gmail.com>
Date: Mon, 19 Nov 2018 18:14:36 -0800
Subject: [PATCH] New drawing
---
src/nsterm.h | 5 +-
src/nsterm.m | 859 +++++++++++++++++++++++++++------------------------
2 files changed, 456 insertions(+), 408 deletions(-)
View display-fix.patch
* src/nsterm.m (ns_row_rect): New function.
(ns_clip_to_row): Remove function.
(ns_copy_bits): Fix mistake.
(ns_draw_fringe_bitmap): Stop using ns_clip_to_row.
(ns_draw_window_cursor): Stop using ns_clip_to_row and perform a
display when not in redisplay.
(ns_update_window_begin): Remove redundant code that never executes.
([EmacsView drawRect:]): Show the rectangle being exposed in NSTRACE.
* src/xdisp.c (expose_window_tree) [HAVE_NS]:
(expose_frame) [HAVE_NS]: Redraw even if the frame is garbaged.
View Fix.patch
From 9800764c5ea1448d1a4f1bd785e98ad94a940e12 Mon Sep 17 00:00:00 2001
From: Aaron Jensen <aaronjensen@gmail.com>
Date: Mon, 5 Nov 2018 08:09:31 -0800
Subject: [PATCH] Fix
---
src/nsterm.m | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/src/nsterm.m b/src/nsterm.m
View 0001-Fix-more-drawing-bugs-in-NS-port-bug-32932.patch
From 95160c34b4f41e867761f29239db02e8e7232bbe Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Mon, 29 Oct 2018 15:37:35 +0000
Subject: [PATCH] Fix more drawing bugs in NS port (bug#32932)
* src/nsterm.m (ns_row_rect): New function.
(ns_clip_to_row): Remove function.
(ns_copy_bits): Fix mistake.
(ns_draw_fringe_bitmap): Stop using ns_clip_to_row.
(ns_draw_window_cursor): Stop using ns_clip_to_row and move
View fix-ns-drawing-issues.patch
From 9feb8c763c6bde3f21d4e4638fe9618d4c54474f Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Sun, 14 Oct 2018 19:12:00 +0100
Subject: [PATCH] Fix some NS drawing issues (bug#32932)
* src/nsterm.m (ns_clip_to_rect):
(ns_reset_clipping): Remove gsaved variable and associated code.
(ns_flush_display): Remove function.
(ns_copy_bits): use translateRectsNeedingDisplayInRect:by: to copy any
pending drawing actions along with the image.
View remove-clear-frame.patch
---
src/nsterm.m | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/nsterm.m b/src/nsterm.m
index f910d606a6..a300c72f56 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -8162,7 +8162,7 @@ - (void)drawRect: (NSRect)rect
if (!emacsframe || !emacsframe->output_data.ns)
View nsterm-fix.patch
---
src/nsterm.m | 41 +++++++++++++++--------------------------
1 file changed, 15 insertions(+), 26 deletions(-)
diff --git a/src/nsterm.m b/src/nsterm.m
index 1ef7f5ab51..f910d606a6 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -279,7 +279,6 @@ - (NSColor *)colorUsingDefaultColorSpace
View fix-colour-list2.patch
* src/nsterm.m (ns_term_init): Use writeToFile or writeToURL as
required.
---
I believe this should fix the colour list error.
src/nsterm.m | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/src/nsterm.m b/src/nsterm.m
index 954020dcde..d92d6c3244 100644
View drawrect.patch
>From 9196236afa609a77d294ef9a77b05518c6fb031f Mon Sep 17 00:00:00 2001
From: Alan Third <address@hidden>
Date: Sat, 4 Aug 2018 11:08:23 +0100
Subject: [PATCH] Make all NS drawing be done from drawRect
See bug#31904 and bug#32812.
* src/nsterm.m (ns_update_begin): Don't lock focus, only clip if there
is already a view focused.
(ns_update_end): Don't mess with view focusing any more.
You can’t perform that action at this time.