Last active
October 15, 2015 22:02
-
-
Save akutz/ec2f97c033f20a3ed0bc to your computer and use it in GitHub Desktop.
golint rexray
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[0]akutz@pax:rexray$ git b | |
feature/admin-mod-unix | |
[0]akutz@pax:rexray$ golint github.com/emccode/rexray/... | |
[0]akutz@pax:rexray$ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[0]akutz@pax:rexray$ git b | |
master | |
[0]akutz@pax:rexray$ golint github.com/emccode/rexray/... | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray.go:3:8: a blank import should be only in a main or test package, or have a comment justifying it | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:50:2: struct field RackspaceAuthUrl should be RackspaceAuthURL | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:51:2: struct field RackspaceUserId should be RackspaceUserID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:53:2: struct field RackspaceTenantId should be RackspaceTenantID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:55:2: struct field RackspaceDomainId should be RackspaceDomainID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:58:2: struct field OpenstackAuthUrl should be OpenstackAuthURL | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:59:2: struct field OpenstackUserId should be OpenstackUserID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:61:2: struct field OpenstackTenantId should be OpenstackTenantID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:63:2: struct field OpenstackDomainId should be OpenstackDomainID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:72:2: struct field ScaleIoSystemId should be ScaleIoSystemID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:74:2: struct field ScaleIoProtectionDomainId should be ScaleIoProtectionDomainID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:76:2: struct field ScaleIoStoragePoolId should be ScaleIoStoragePoolID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:87:6: exported type JsonMarshalStrategy should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:87:6: type JsonMarshalStrategy should be JSONMarshalStrategy | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:90:2: const JsonMarshalSecure should be JSONMarshalSecure | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:90:2: exported const JsonMarshalSecure should have comment (or a comment on this block) or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:91:2: const JsonMarshalPlainText should be JSONMarshalPlainText | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:121:1: exported function NewConfig should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:170:1: exported method Config.JsonMarshalStrategy should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:170:18: func JsonMarshalStrategy should be JSONMarshalStrategy | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:174:1: exported method Config.SetJsonMarshalStrategy should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:174:18: func SetJsonMarshalStrategy should be SetJSONMarshalStrategy | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:178:1: exported method Config.Copy should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:189:1: exported function FromJson should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:189:6: func FromJson should be FromJSON | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:198:1: exported method Config.ToJson should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:198:18: func ToJson should be ToJSON | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:206:1: exported method Config.ToSecureJson should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:206:18: func ToSecureJson should be ToSecureJSON | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:214:1: comment on exported method Config.MarshalJSON should be of the form "MarshalJSON ..." | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:232:1: exported method Config.ReadConfig should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:246:11: should omit 2nd value from range; this loop is equivalent to `for key := range ...` | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:254:1: exported method Config.ReadConfigFile should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:270:1: exported method Config.EnvVars should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config.go:279:1: exported method Config.Sync should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keymap.go:11:6: exported type ConfigKey should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keymap.go:11:6: type name will be used as config.ConfigKey by other packages, and that stutters; consider calling this Key | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keymap.go:18:6: exported type ConfigKeyMap should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keymap.go:18:6: type name will be used as config.ConfigKeyMap by other packages, and that stutters; consider calling this KeyMap | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keymap.go:20:6: exported type SetVapFun should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:3:7: exported const Host should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:4:7: exported const LogLevel should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:5:7: exported const StorageDrivers should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:6:7: exported const VolumeDrivers should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:7:7: exported const OsDrivers should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:8:7: exported const MinVolSize should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:9:7: exported const RemoteManagement should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:11:7: exported const DockerVolumeType should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:12:7: exported const DockerIops should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:13:7: exported const DockerSize should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:14:7: exported const DockerAvailabilityZone should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:16:7: exported const AwsAccessKey should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:17:7: exported const AwsSecretKey should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:18:7: exported const AwsRegion should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:20:7: const RackspaceAuthUrl should be RackspaceAuthURL | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:20:7: exported const RackspaceAuthUrl should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:21:7: const RackspaceUserId should be RackspaceUserID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:21:7: exported const RackspaceUserId should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:22:7: exported const RackspaceUserName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:23:7: exported const RackspacePassword should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:24:7: const RackspaceTenantId should be RackspaceTenantID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:24:7: exported const RackspaceTenantId should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:25:7: exported const RackspaceTenantName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:26:7: const RackspaceDomainId should be RackspaceDomainID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:26:7: exported const RackspaceDomainId should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:27:7: exported const RackspaceDomainName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:29:7: const OpenstackAuthUrl should be OpenstackAuthURL | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:29:7: exported const OpenstackAuthUrl should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:30:7: const OpenstackUserId should be OpenstackUserID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:30:7: exported const OpenstackUserId should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:31:7: exported const OpenstackUserName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:32:7: exported const OpenstackPassword should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:33:7: const OpenstackTenantId should be OpenstackTenantID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:33:7: exported const OpenstackTenantId should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:34:7: exported const OpenstackTenantName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:35:7: const OpenstackDomainId should be OpenstackDomainID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:35:7: exported const OpenstackDomainId should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:36:7: exported const OpenstackDomainName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:37:7: exported const OpenstackRegionName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:38:7: exported const OpenstackAvailabilityZoneName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:40:7: exported const ScaleIoEndpoint should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:41:7: exported const ScaleIoInsecure should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:42:7: exported const ScaleIoUseCerts should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:43:7: exported const ScaleIoUserName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:44:7: exported const ScaleIoPassword should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:45:7: const ScaleIoSystemId should be ScaleIoSystemID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:45:7: exported const ScaleIoSystemId should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:46:7: exported const ScaleIoSystemName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:47:7: const ScaleIoProtectionDomainId should be ScaleIoProtectionDomainID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:47:7: exported const ScaleIoProtectionDomainId should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:48:7: exported const ScaleIoProtectionDomainName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:49:7: const ScaleIoStoragePoolId should be ScaleIoStoragePoolID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:49:7: exported const ScaleIoStoragePoolId should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:50:7: exported const ScaleIoStoragePoolName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:52:7: exported const XtremIoEndpoint should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:53:7: exported const XtremIoUserName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:54:7: exported const XtremIoPassword should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:55:7: exported const XtremIoInsecure should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:56:7: exported const XtremIoDeviceMapper should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:57:7: exported const XtremIoMultipath should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_keys.go:58:7: exported const XtremIoRemoteManagement should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_test.go:24:6: var strJson should be strJSON | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_test.go:51:6: var strJson should be strJSON | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_test.go:85:2: var strJson should be strJSON | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_test.go:114:2: var strJson should be strJSON | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/config/config_test.go:375:5: var secureJsonConfig should be secureJSONConfig | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/daemon.go:12:1: exported function Start should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/daemon_modules.go:6:2: a blank import should be only in a main or test package, or have a comment justifying it | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:43:2: var nextModTypeId should be nextModTypeID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:44:2: var nextModInstanceId should be nextModInstanceID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:53:1: exported function GetModOptVal should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:56:9: if block ends with a return statement, so drop this else and outdent its block | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:61:6: exported type ModuleConfig should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:61:6: type name will be used as module.ModuleConfig by other packages, and that stutters; consider calling this Config | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:66:6: exported type ModuleType should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:66:6: type name will be used as module.ModuleType by other packages, and that stutters; consider calling this Type | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:67:2: struct field Id should be ID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:74:6: exported type ModuleInstance should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:74:6: type name will be used as module.ModuleInstance by other packages, and that stutters; consider calling this Instance | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:75:2: struct field Id should be ID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:77:2: struct field TypeId should be TypeID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:92:1: exported function ModuleTypes should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:92:6: func name will be used as module.ModuleTypes by other packages, and that stutters; consider calling this Types | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:110:1: exported function ModuleInstances should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:110:6: func name will be used as module.ModuleInstances by other packages, and that stutters; consider calling this Instances | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:128:1: exported function InitializeDefaultModules should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:151:1: exported function InitializeModule should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:152:2: func parameter modTypeId should be modTypeID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:171:2: var modInstId should be modInstID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:195:1: exported function RegisterModule should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:203:2: var modTypeId should be modTypeID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:215:1: exported function StartDefaultModules should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:219:10: should omit 2nd value from range; this loop is equivalent to `for id := range ...` | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:229:1: exported function GetModuleInstance should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:229:24: func parameter modInstId should be modInstID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:243:1: exported function StartModule should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/module.go:243:18: func parameter modInstId should be modInstID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin-html.go:3:7: const HtmlIndex should be HTMLIndex | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin-html.go:3:7: exported const HtmlIndex should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin-images.go:3:7: exported const ImageRexRayBannerLogo should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin-scripts.go:3:7: exported const ScriptJQuery should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin-styles.go:3:7: exported const StyleMain should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:21:7: don't use ALL_CAPS in Go names; use CamelCase | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:21:7: exported const MOD_PORT should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:22:7: don't use ALL_CAPS in Go names; use CamelCase | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:22:7: exported const MOD_NAME should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:23:7: don't use ALL_CAPS in Go names; use CamelCase | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:23:7: exported const MOD_DESC should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:25:6: exported type Module should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:32:6: exported type JsonError should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:32:6: type JsonError should be JSONError | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:45:1: exported function Init should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:54:1: exported method Module.Id should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:54:20: func Id should be ID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:118:2: can probably use "var mods []*module.ModuleType" instead | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:138:2: can probably use "var mods []*module.ModuleInstance" instead | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:158:2: var typeId should be typeID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:160:2: var cfgJson should be cfgJSON | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:190:2: var typeIdInt should be typeIDInt | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:190:13: var typeIdIntErr should be typeIDIntErr | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:197:2: var typeIdInt32 should be typeIDInt32 | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:224:10: if block ends with a return statement, so drop this else and outdent its block | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:323:1: exported method Module.Start should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:373:1: exported method Module.Stop should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:377:1: exported method Module.Name should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:381:1: exported method Module.Description should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/admin/admin.go:385:1: exported method Module.Address should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:24:7: don't use ALL_CAPS in Go names; use CamelCase | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:24:7: exported const MOD_ADDR should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:25:7: don't use ALL_CAPS in Go names; use CamelCase | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:25:7: exported const MOD_PORT should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:26:7: don't use ALL_CAPS in Go names; use CamelCase | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:26:7: exported const MOD_NAME should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:27:7: don't use ALL_CAPS in Go names; use CamelCase | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:27:7: exported const MOD_DESC should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:29:7: don't use ALL_CAPS in Go names; use CamelCase | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:29:7: exported const MOD_OPTS_STORAGE_ADAPTER should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:31:6: exported type Module should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:62:9: if block ends with a return statement, so drop this else and outdent its block | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:69:1: exported method Module.Id should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:69:20: func Id should be ID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:73:1: exported function Init should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:109:2: exported var ErrMissingHost should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:120:1: exported method Module.Start should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:130:10: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:135:10: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:198:1: exported method Module.Stop should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:202:1: exported method Module.Name should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:206:1: exported method Module.Description should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/remotevolumedriver/remvoldriver.go:210:1: exported method Module.Address should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:25:7: don't use ALL_CAPS in Go names; use CamelCase | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:25:7: exported const MOD_ADDR should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:26:7: don't use ALL_CAPS in Go names; use CamelCase | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:26:7: exported const MOD_PORT should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:27:7: don't use ALL_CAPS in Go names; use CamelCase | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:27:7: exported const MOD_NAME should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:28:7: don't use ALL_CAPS in Go names; use CamelCase | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:28:7: exported const MOD_DESC should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:30:6: exported type Module should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:57:1: exported method Module.Id should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:57:20: func Id should be ID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:61:1: exported function Init should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:99:2: exported var ErrMissingHost should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:109:1: exported method Module.Start should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:119:10: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:124:10: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:187:1: exported method Module.Stop should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:191:1: exported method Module.Name should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:195:1: exported method Module.Description should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/daemon/module/docker/volumedriver/voldriver.go:199:1: exported method Module.Address should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/errors/errors.go:7:6: exported type Error should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/errors/errors.go:11:6: exported type Fields should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/errors/errors.go:17:1: exported method Error.PlayGolf should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/errors/errors.go:21:1: exported method Error.GolfExportedFields should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/errors/errors.go:25:1: exported function New should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/errors/errors.go:29:1: exported function Newf should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/errors/errors.go:33:1: exported function WithError should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/errors/errors.go:37:1: exported function WithField should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/errors/errors.go:41:1: exported function WithFieldE should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/errors/errors.go:45:1: exported function WithFields should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/errors/errors.go:49:1: exported function WithFieldsE should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/driver.go:10:2: exported var ErrDriverInstanceDiscovery should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/driver.go:13:6: exported type Driver should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/os.go:13:6: exported type InitFunc should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/os.go:19:1: exported function Register should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/os.go:23:6: exported type OSDriverManager should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/os.go:23:6: type name will be used as os.OSDriverManager by other packages, and that stutters; consider calling this DriverManager | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/os.go:28:1: exported function NewOSDriverManager should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/os.go:42:1: exported method OSDriverManager.IsDrivers should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/os.go:77:1: exported method OSDriverManager.GetMounts should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/os.go:94:1: exported method OSDriverManager.Mounted should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/os.go:104:1: exported method OSDriverManager.Unmount should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/os.go:114:1: exported method OSDriverManager.Mount should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/os.go:127:1: exported method OSDriverManager.Format should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/linux/os.go:18:7: exported const ProviderName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/linux/os.go:25:2: exported var ErrUnknownOS should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/linux/os.go:29:6: exported type Driver should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/linux/os.go:33:1: exported function Init should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/linux/os.go:38:9: if block ends with a return statement, so drop this else and outdent its block | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/linux/os.go:43:1: exported method Driver.Name should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/linux/os.go:47:1: exported method Driver.GetMounts should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/linux/os.go:69:1: exported method Driver.Mounted should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/linux/os.go:73:1: exported method Driver.Unmount should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/os/linux/os.go:77:1: exported method Driver.Mount should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/commands.go:224:3: var modTypeIdStr should be modTypeIDStr | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/commands.go:228:3: var cfgJson should be cfgJSON | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/commands.go:228:12: var cfgJsonErr should be cfgJSONErr | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/installer.go:158:1: exported function GetInitSystemCmd should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/installer.go:171:1: exported function GetInitSystemType should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/installer.go:329:7: exported const UnitFileTemplate should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/installer.go:377:7: exported const InitScriptTemplate should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/rexray.go:7:2: a blank import should be only in a main or test package, or have a comment justifying it | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/rexray.go:21:2: exported const NoColor should have comment (or a comment on this block) or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/rexray.go:53:2: exported var IOPS should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/rexray.go:67:2: var moduleTypeId should be moduleTypeID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/rexray.go:68:2: var moduleInstanceId should be moduleInstanceID | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/rexray.go:74:6: exported type HelpFlagPanic should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/rexray.go:75:6: exported type PrintedErrorPanic should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/rexray.go:76:6: exported type SubCommandPanic should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/service.go:14:2: a blank import should be only in a main or test package, or have a comment justifying it | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/service.go:116:2: can probably use "var initErrors []error" instead | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/service.go:250:7: const RexRayLogoAscii should be RexRayLogoASCII | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/service.go:250:7: exported const RexRayLogoAscii should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/usage.go:139:7: exported const UsageTemplate should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/rexray/cli/term/terminal_bsd.go:9:6: exported type Termios should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/driver.go:3:6: exported type BlockDevice should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/driver.go:13:6: exported type Instance should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/driver.go:20:6: exported type Snapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/driver.go:30:6: exported type Volume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/driver.go:42:6: exported type VolumeAttachment should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/driver.go:49:6: exported type Driver should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:21:6: exported type StorageDriverManager should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:21:6: type name will be used as storage.StorageDriverManager by other packages, and that stutters; consider calling this DriverManager | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:26:6: exported type InitFunc should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:28:1: exported function Register should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:32:1: exported method StorageDriverManager.GetDriverNames should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:36:1: exported function GetDriverNames should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:76:2: exported var ErrDriverBlockDeviceDiscovery should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:83:1: exported function NewStorageDriverManager should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:100:1: exported method StorageDriverManager.IsDrivers should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:125:1: exported method StorageDriverManager.GetInstance should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:140:1: exported method StorageDriverManager.GetVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:158:1: exported method StorageDriverManager.GetSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:176:1: exported method StorageDriverManager.CreateSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:190:1: exported method StorageDriverManager.RemoveSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:203:1: exported method StorageDriverManager.CreateVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:229:1: exported method StorageDriverManager.RemoveVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:242:1: exported method StorageDriverManager.AttachVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:264:1: exported method StorageDriverManager.DetachVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:286:1: exported method StorageDriverManager.GetVolumeAttach should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/storage.go:301:1: exported method StorageDriverManager.CopySnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:22:7: exported const ProviderName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:24:6: exported type Driver should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:31:2: exported var ErrMissingVolumeID should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:58:1: exported function Init should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:107:1: exported method Driver.GetVolumeMapping should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:183:1: exported method Driver.GetInstance should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:211:1: exported method Driver.CreateSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:267:1: exported method Driver.GetSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:292:1: exported method Driver.RemoveSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:302:1: exported method Driver.GetDeviceNextAvailable should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:346:22: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:362:1: exported method Driver.CreateVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:477:1: exported method Driver.GetVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:515:1: exported method Driver.GetVolumeAttach should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:616:1: exported method Driver.RemoveVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:630:1: exported method Driver.AttachVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:662:1: exported method Driver.DetachVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/ec2/storage.go:684:1: exported method Driver.CopySnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:27:7: exported const ProviderName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:33:6: exported type Driver should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:94:1: exported function Init should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:190:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:200:1: exported method Driver.GetInstance should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:200:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:217:1: exported method Driver.GetVolumeMapping should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:217:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:243:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:302:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:355:1: exported method Driver.GetVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:355:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:395:1: exported method Driver.GetVolumeAttach should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:395:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:426:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:464:1: exported method Driver.GetSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:464:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:492:1: exported method Driver.CreateSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:492:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:539:1: exported method Driver.RemoveSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:539:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:551:1: exported method Driver.CreateVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:551:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:701:1: exported method Driver.RemoveVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:701:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:717:1: exported method Driver.GetDeviceNextAvailable should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:717:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:778:1: exported method Driver.AttachVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:778:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:820:1: exported method Driver.DetachVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:820:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:855:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:878:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:902:1: exported method Driver.CopySnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/openstack/storage.go:902:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:25:7: exported const ProviderName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:31:6: exported type Driver should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:99:1: exported function Init should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:177:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:187:1: exported method Driver.GetInstance should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:187:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:204:1: exported method Driver.GetVolumeMapping should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:204:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:230:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:266:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:319:1: exported method Driver.GetVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:319:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:359:1: exported method Driver.GetVolumeAttach should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:359:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:390:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:428:1: exported method Driver.GetSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:428:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:456:1: exported method Driver.CreateSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:456:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:503:1: exported method Driver.RemoveSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:503:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:515:1: exported method Driver.CreateVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:515:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:661:1: exported method Driver.RemoveVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:661:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:677:1: exported method Driver.GetDeviceNextAvailable should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:677:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:738:1: exported method Driver.AttachVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:738:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:780:1: exported method Driver.DetachVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:780:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:815:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:838:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:862:1: exported method Driver.CopySnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/rackspace/storage.go:862:1: receiver name driver should be consistent with previous receiver name d for Driver | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:16:7: exported const ProviderName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:18:6: exported type Driver should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:49:1: exported function Init should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:142:1: exported method Driver.GetInstance should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:172:1: exported method Driver.GetVolumeMapping should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:207:1: exported method Driver.GetVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:263:1: exported method Driver.GetVolumeAttach should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:294:1: exported method Driver.GetSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:327:1: exported method Driver.CreateSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:389:1: exported method Driver.CreateVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:408:1: exported method Driver.RemoveVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:435:1: exported method Driver.RemoveSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:444:1: exported method Driver.GetDeviceNextAvailable should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:448:1: exported method Driver.AttachVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:504:1: exported method Driver.DetachVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/scaleio/storage.go:546:1: exported method Driver.CopySnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:23:7: exported const ProviderName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:25:6: exported type Driver should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:37:2: exported var ErrMissingVolumeID should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:103:1: exported function Init should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:205:9: if block ends with a return statement, so drop this else and outdent its block | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:218:9: if block ends with a return statement, so drop this else and outdent its block | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:297:1: exported method Driver.GetInstance should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:315:1: exported method Driver.GetVolumeMapping should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:376:1: exported method Driver.GetVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:430:1: exported method Driver.CreateVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:479:1: exported method Driver.RemoveVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:582:1: exported method Driver.CreateSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:608:1: exported method Driver.RemoveSnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:617:1: exported method Driver.GetVolumeAttach should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:688:1: exported method Driver.AttachVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:769:1: exported method Driver.DetachVolume should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:811:1: exported method Driver.CopySnapshot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/storage/xtremio/storage.go:815:1: exported method Driver.GetDeviceNextAvailable should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:24:2: exported const LogDirPathSuffix should have comment (or a comment on this block) or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:80:1: exported function GetPrefix should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:84:1: exported function Prefix should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:92:1: exported function IsPrefixed should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:96:1: exported function HomeDir should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:110:1: exported function StringInSlice should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:119:1: exported function Install should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:123:1: exported function InstallChownRoot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:131:1: exported function InstallDirChownRoot should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:135:1: exported function EtcDirPath should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:143:1: exported function RunDirPath should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:151:1: exported function LogDirPath should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:159:1: exported function LibDirPath should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:167:1: exported function LibFilePath should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:171:1: exported function BinDirPath should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:179:1: exported function PidFilePath should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:186:1: exported function BinFilePath should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:193:1: exported function EtcFilePath should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:197:1: exported function LogFilePath should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:201:1: exported function LogFile should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:206:1: exported function StdOutAndLogFile should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:214:1: exported function WriteStringToFile should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:226:1: exported function ReadFileToString should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:242:1: exported function WritePidFile should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:251:1: exported function ReadPidFile should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:266:1: exported function IsDirEmpty should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:280:1: exported function LineReader should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:302:1: exported function FileExists should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:309:1: exported function FileExistsInPath should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:314:1: exported function GetPathParts should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:325:1: exported function GetThisPathParts should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:333:1: exported function RandomString should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/util/util.go:388:1: exported function PrintVersion should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/version_info/version_info.go:1:1: don't use an underscore in package name | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/version_info/version_info.go:9:2: exported var SemVer should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/version_info/version_info.go:31:1: exported function EpochToRfc1123 should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/driver.go:3:6: exported type VolumeOpts should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/driver.go:3:6: type name will be used as volume.VolumeOpts by other packages, and that stutters; consider calling this Opts | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/driver.go:5:6: exported type Driver should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:15:6: exported type InitFunc should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:23:1: exported function Register should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:27:6: exported type VolumeDriverManager should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:27:6: type name will be used as volume.VolumeDriverManager by other packages, and that stutters; consider calling this DriverManager | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:31:1: exported function NewVolumeDriverManager should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:50:1: exported method VolumeDriverManager.IsDrivers should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:88:1: exported method VolumeDriverManager.Mount should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:101:1: exported method VolumeDriverManager.Unmount should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:112:1: exported method VolumeDriverManager.Path should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:123:1: exported method VolumeDriverManager.Create should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:134:1: exported method VolumeDriverManager.Remove should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:144:1: exported method VolumeDriverManager.Attach should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:155:1: exported method VolumeDriverManager.Detach should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/volume.go:166:1: exported method VolumeDriverManager.NetworkName should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/docker/volume.go:18:2: exported const ProviderName should have comment (or a comment on this block) or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/docker/volume.go:22:6: exported type Driver should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/docker/volume.go:38:1: exported function Init should have comment or be unexported | |
/Users/akutz/Projects/go/src/github.com/emccode/rexray/volume/docker/volume.go:491:1: comment on exported method Driver.Detach should be of the form "Detach ..." | |
[0]akutz@pax:rexray$ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment