Code review practices
The following is meant to be a set of guidelines, not dogma. Use your best judgement. The goal is threefold, to have a practice for engineers to learn about what we collectively care about. To maintain quality of the code base as well as knowledge sharing about our systems.
Role of the author
- Create PR, make sure to include JIRA ticket if such exists in the description or title of PR
- Assign 2 developers as minimum but can include the whole team if the author feels it's needed.
- Answer any questions the reviewer has.
- Push changes after review is done as a new commit and make sure reviewer and yourself are satisfied with the change.