Last active
February 9, 2017 19:30
-
-
Save astrofrog/5d4760f3702ebd324855f85f43207bc0 to your computer and use it in GitHub Desktop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For the Gaussian1D case, the following definition does not make sense (i.e., setting
stddev
to a unit that is incompatible withmean
) but it is allowed, only to cause other exceptions to be raised on evaluation:While I understand that compound model is future work, we also have to be careful such that massive refactoring won't be required in the future in order to make units work with them. In real life, most of us deal with compound models, so if we want to advertise that units are possible in models, we also have to make sure they will indeed be possible for compound models (albeit not implemented in this PR).
Currently:
or