Skip to content

Instantly share code, notes, and snippets.

Embed
What would you like to do?
Electron Release workflow for GitHub Actions
name: Electron CD
on: [push]
jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [macOS-10.14, windows-2016, ubuntu-18.04]
steps:
- name: Context
env:
GITHUB_CONTEXT: ${{ toJson(github) }}
run: echo "$GITHUB_CONTEXT"
- uses: actions/checkout@v1
with:
fetch-depth: 1
- name: Use Node.js 10.x
uses: actions/setup-node@v1
with:
node-version: 10.x
- name: yarn install
run: |
yarn install
- name: Publish
run: |
yarn run dist
- name: Cleanup artifacts
run: |
npx rimraf "dist/!(*.exe|*.deb|*.AppImage|*.dmg)"
- name: Upload artifacts
uses: actions/upload-artifact@v1
with:
name: ${{ matrix.os }}
path: dist
- name: Release
uses: softprops/action-gh-release@v1
if: startsWith(github.ref, 'refs/tags/')
with:
files: "dist/**"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@NoelDavies

This comment has been minimized.

Copy link

@NoelDavies NoelDavies commented Nov 6, 2019

I get this - So annoying

Cleanup artifacts0s
##[error]Process completed with exit code 1.
Run npx rimraf "dist/!(*.exe|*.deb|*.AppImage|*.dmg)"
  npx rimraf "dist/!(*.exe|*.deb|*.AppImage|*.dmg)"
  shell: C:\Program Files\PowerShell\6\pwsh.EXE -command ". '{0}'"
'*.deb' is not recognized as an internal or external command,
operable program or batch file.
##[error]Process completed with exit code 1.

anybody found a fix?

@vipzero

This comment has been minimized.

Copy link

@vipzero vipzero commented Nov 17, 2019

I get this - So annoying

Cleanup artifacts0s
##[error]Process completed with exit code 1.
Run npx rimraf "dist/!(*.exe|*.deb|*.AppImage|*.dmg)"
  npx rimraf "dist/!(*.exe|*.deb|*.AppImage|*.dmg)"
  shell: C:\Program Files\PowerShell\6\pwsh.EXE -command ". '{0}'"
'*.deb' is not recognized as an internal or external command,
operable program or batch file.
##[error]Process completed with exit code 1.

anybody found a fix?

me too

@vipzero

This comment has been minimized.

Copy link

@vipzero vipzero commented Nov 19, 2019

It works. Avoid using | operator at windows(powershell)

...

    strategy:
      matrix:
        os: [ubuntu-latest, windows-latest, macOS-latest]
...

      - name: Cleanup artifacts
        if: matrix.os != 'windows-latest'
        run: |
          mkdir artifacts
          mv "dist/(*.exe,*.deb,*.AppImage,*.dmg)" artifacts || true
      - name: Cleanup artifacts Win
        if: matrix.os == 'windows-latest'
        run: |
          mkdir artifacts
          mv dist/*.exe artifacts
      - name: Upload artifacts
        uses: actions/upload-artifact@v1
        with:
          name: ${{matrix.os}}
          path: artifacts
      - name: Release
        uses: softprops/action-gh-release@v1
        if: startsWith(github.ref, 'refs/tags/')
        with:
          files: "artifacts/**"
        env:
          GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
@NoelDavies

This comment has been minimized.

Copy link

@NoelDavies NoelDavies commented Nov 19, 2019

I ended up doing 2 different flows dependant on OS. I'll have a look at the latest one and see how that fairs.

@brunolaranjeira

This comment has been minimized.

Copy link

@brunolaranjeira brunolaranjeira commented Nov 20, 2019

Thanks @vipzero, that worked like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment