Skip to content

Instantly share code, notes, and snippets.

Show Gist options
  • Save benesch/fc3091aa4ca5ea9c7effcbc41dbd1c2b to your computer and use it in GitHub Desktop.
Save benesch/fc3091aa4ca5ea9c7effcbc41dbd1c2b to your computer and use it in GitHub Desktop.
--- a/src/github.com/cockroachdb/cockroach/Makefile
+++ b/src/github.com/cockroachdb/cockroach/Makefile
@@ -110,7 +110,7 @@ short: build testshort checkshort
buildoss: BUILDTARGET = ./pkg/cmd/cockroach-oss
-build buildoss: BUILDMODE = build -i -o cockroach$(SUFFIX)$(shell $(XGO) env GOEXE)
+build buildoss: BUILDMODE = build -i -o cockroach$(SUFFIX)$$($(XGO) env GOEXE)
# The build.utcTime format must remain in sync with TimeFormat in pkg/build/info.go.
build buildoss install: override LINKFLAGS += \
diff --git a/build/common.mk b/build/common.mk
index 009290b2e..be12c628c 100644
--- a/src/github.com/cockroachdb/cockroach/build/common.mk
+++ b/src/github.com/cockroachdb/cockroach/build/common.mk
@@ -170,7 +170,7 @@ ifneq ($(GIT_DIR),)
git submodule update --init
endif
@$(GO_INSTALL) -v $(PKG_ROOT)/cmd/{metacheck,ncpus,returncheck} \
- $(shell $(GO) list -tags glide -f '{{join .Imports "\n"}}' $(REPO_ROOT)/build)
+ $$($(GO) list -tags glide -f '{{join .Imports "\n"}}' $(REPO_ROOT)/build)
touch $@
# Make doesn't expose a list of the variables declared in a given file, so we
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment