Skip to content

Instantly share code, notes, and snippets.

@bradfa
Last active April 26, 2024 11:09
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save bradfa/c00cde113ccf8a86a4db8a89201e4545 to your computer and use it in GitHub Desktop.
Save bradfa/c00cde113ccf8a86a4db8a89201e4545 to your computer and use it in GitHub Desktop.
curl-for-win improvements needed

The list of debian/ubuntu prereq packages is incomplete, you at least need to add:

  • python3-pip
  • curl
  • time
  • cmake
  • g++-mingw-w64

You also need both i386 and amd64 arches setup in dpkg so the proper packages for both arches are pulled in by apt, such as for wine and mingw.

There appears to be no error catching between each sub-script execution, so for instance if building of zlib fails it keeps going and you notice the issue when curl building fails for finding zlib things (headers/libs). It'd be better if it would just stop right when the failure happens so the user can see the error.

The curl-for-win project doesn't have any ability to open "issues" on github.

@vszakats
Copy link

vszakats commented Apr 26, 2024

It's been a long while, but I think all of these has been addressed since. (curl isn't installed as a prereq, though it seems to be present on the platforms tested.)

@bradfa
Copy link
Author

bradfa commented Apr 26, 2024

It's been a long while, but I think all of these has been addressed since. (curl isn't installed as a prereq, though it seems to be present on the platforms tested.)

Good to hear! Thanks for the feedback! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment