Skip to content

Instantly share code, notes, and snippets.

@burkeholland
Last active September 13, 2019 13:12
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save burkeholland/dcfe77e281a2d69a0fdf596fb0c6582a to your computer and use it in GitHub Desktop.
Save burkeholland/dcfe77e281a2d69a0fdf596fb0c6582a to your computer and use it in GitHub Desktop.
Learn Review Guidelines

General PR guidance:

  • All Azure Learn content is in learn-pr. Anyone in the Microsoft Docs organization can create PRs there. You are welcome to create PRs at any time for fixes, small recommendations, etc.
  • Please work through Nick/Barry before investing time in proposing major changes or writing something new. We have processes on our side for big stuff, although I will handle most of it so you can focus on fixing stuff you want to fix.
  • If you are making changes across more than one or two files, please consider forking, fetching and making changes locally (instead of using the web editor) so you don’t end up with a separate PR for each individual file.
  • Consider Nick your liaison for getting stuff merged. Just @ me in your PR comments (@nickwalkmsft). Ping me any time if you want to chat.

Design doc review:

  • I will work with Burke to advertise what’s available for review and provide direct links.
  • To comment on a design doc, just open a PR and put all of your comments and proposed changes directly in the file. You can use the GitHub web editor for this if you want. Please tag comments with your initials or alias, just so I can see where multiple people are commenting. Other than that I’m not too worried about delimiting comments, inline vs. at the bottom etc., just use your best judgement. The design docs are just markdown and have no build requirements, so I’m fine merging in messes of comments then going through and working them in. Your PRs and commit history can be used as a record of your contribution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment