Skip to content

Instantly share code, notes, and snippets.

@celeron55 celeron55/3084.diff Secret
Last active Jan 1, 2016

Embed
What would you like to do?
diff --git a/src/filesys.cpp b/src/filesys.cpp
index 4cefdb8..5388c9d 100644
--- a/src/filesys.cpp
+++ b/src/filesys.cpp
@@ -693,13 +693,22 @@ bool safeWriteToFile(const std::string &path, const std::string &content)
os.flush();
os.close();
if (os.fail()) {
+ // Remove the temporary file because writing it failed and it's useless.
remove(tmp_file.c_str());
return false;
}
- // Copy file
+ // Move the finished temporary file over the real file
+#ifdef _WIN32
+ // On POSIX compliant systems rename() is specified to be able to swap the
+ // file in place of the destination file, making this a truly error-proof
+ // transaction.
+ // However, on Windows, the target file has to be removed first.
remove(path.c_str());
+#endif
if(rename(tmp_file.c_str(), path.c_str())) {
+ // Remove the temporary file because moving it over the target file
+ // failed.
remove(tmp_file.c_str());
return false;
} else {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.