Skip to content

Instantly share code, notes, and snippets.

@daisukenishino2

daisukenishino2/Summary.txt

Last active April 15, 2019 04:34
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save daisukenishino2/204f16d612831421ab7451861a29c001 to your computer and use it in GitHub Desktop.
Save daisukenishino2/204f16d612831421ab7451861a29c001 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
Summary.txt
MultiPurposeAuthSite is implemented webauthn using fido2-net-lib.
And, summarized the feedback in this page.
@daisukenishino2
Copy link
Author

daisukenishino2 commented Apr 15, 2019 •
edited

Summary

Analysis target

Analysis result

Implementation result

Library

This library is cross-compiled to .NET Framework(4.7) and .NET Core(2.0)

ASP.NET

this library works correctly on the .NET Framework (4.7) and .NET Core (2.0) runtimes.

ASP.NET

https://github.com/OpenTouryoProject/MultiPurposeAuthSite/tree/develop/root/programs/MultiPurposeAuthSite

ASP.NET Core

https://github.com/OpenTouryoProject/MultiPurposeAuthSite/tree/develop/root/programs/MultiPurposeAuthSiteCore

Test code

Execution result

@daisukenishino2
Copy link
Author

daisukenishino2 commented Apr 15, 2019 •
edited

Feedback

js/webauthn.js

ArrayBuffer and Uint8Array

The methods of navigator.credentials can take 2 arguments type of ArrayBuffer and Uint8Array.
Therefore, using the coerceToArrayBuffer method for all operations is easier to understand.

2 js files are not used.

https://github.com/abergs/fido2-net-lib/blob/1.0.0-preview/Fido2Demo/wwwroot/js/

  • base64.js
  • cbor.js

Controller.cs

Server Requirements and Transport Binding Profile

I think, it is better that the Controller.cs to compliance with "Server Requirements and Transport Binding Profile".

MDSAccessKey

I want explanation about how to use MDS AccessKey.

DevelopmentInMemoryStore

I think it is better to add an interface of storage that will be inherited by DevelopmentInMemoryStore. This is like the UserStore class of ASP.NET Identity. But, In this case, I think that the storage API only needs parameter of the StoredCredential poco class, User poco class is not needed. because, User poco class is already provided in almost cases. If you pass User poco class to storage API, I think that it is better to make it a Generic type parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment