Last active
April 15, 2019 04:34
-
-
Save daisukenishino2/204f16d612831421ab7451861a29c001 to your computer and use it in GitHub Desktop.
Feedback to https://github.com/abergs/fido2-net-lib.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MultiPurposeAuthSite is implemented webauthn using fido2-net-lib. | |
And, summarized the feedback in this page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feedback
js/webauthn.js
ArrayBuffer and Uint8Array
The methods of navigator.credentials can take 2 arguments type of ArrayBuffer and Uint8Array.
Therefore, using the coerceToArrayBuffer method for all operations is easier to understand.
2 js files are not used.
https://github.com/abergs/fido2-net-lib/blob/1.0.0-preview/Fido2Demo/wwwroot/js/
Controller.cs
Server Requirements and Transport Binding Profile
I think, it is better that the Controller.cs to compliance with "Server Requirements and Transport Binding Profile".
MDSAccessKey
I want explanation about how to use MDS AccessKey.
DevelopmentInMemoryStore
I think it is better to add an interface of storage that will be inherited by DevelopmentInMemoryStore. This is like the UserStore class of ASP.NET Identity. But, In this case, I think that the storage API only needs parameter of the StoredCredential poco class, User poco class is not needed. because, User poco class is already provided in almost cases. If you pass User poco class to storage API, I think that it is better to make it a Generic type parameter.