David Ostrovsky davido
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $ buck build chrome | |
| Watchman not found, please install when using buckd. | |
| See https://github.com/facebook/watchman for details. | |
| (brew install --HEAD watchman on OS X) | |
| [-] PARSING BUILD FILES...FINISHED 1,1s | |
| [+] BUILDING...20,0s | |
| |=> IDLE | |
| |=> IDLE | |
| |=> IDLE | |
| |=> IDLE |
davido
/ gist:8891691
Created
February 8, 2014 23:06
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/AutoRegisterScript.java b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/AutoRegisterScript.java | |
| index 4daf196..39fffca 100644 | |
| --- a/gerrit-server/src/main/java/com/google/gerrit/server/plugins/AutoRegisterScript.java | |
| +++ b/gerrit-server/src/main/java/com/google/gerrit/server/plugins/AutoRegisterScript.java | |
| @@ -34,7 +34,7 @@ import java.lang.reflect.ParameterizedType; | |
| import java.util.Map; | |
| import java.util.Set; | |
| -class AutoRegisterScript { | |
| +public class AutoRegisterScript { |
davido
/ gist:8330750
Created
January 9, 2014 07:40
Removing notes.load() function let all tests still pass
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/ApprovalsUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/ApprovalsUtil.java | |
| index dd2c32b..b2d144b 100644 | |
| --- a/gerrit-server/src/main/java/com/google/gerrit/server/ApprovalsUtil.java | |
| +++ b/gerrit-server/src/main/java/com/google/gerrit/server/ApprovalsUtil.java | |
| @@ -113,7 +113,7 @@ public class ApprovalsUtil { | |
| if (!migration.readPatchSetApprovals()) { | |
| return getReviewers(db.patchSetApprovals().byChange(notes.getChangeId())); | |
| } | |
| - return notes.load().getReviewers(); | |
| + return notes.getReviewers(); |
davido
/ gist:8061413
Last active
December 31, 2015 23:39
make singleusergroup plugin to compile aganst 2.8 stable
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/pom.xml b/pom.xml | |
| index 7336fbe..53d0088 100644 | |
| --- a/pom.xml | |
| +++ b/pom.xml | |
| @@ -26,7 +26,7 @@ limitations under the License. | |
| <properties> | |
| <Gerrit-ApiType>plugin</Gerrit-ApiType> | |
| - <Gerrit-ApiVersion>2.9-SNAPSHOT</Gerrit-ApiVersion> | |
| + <Gerrit-ApiVersion>2.8</Gerrit-ApiVersion> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| davido@wizball:~/projects/gerrit3 ((v2.8))$ buck build gerrit | |
| [-] PARSING BUILD FILES...FINISHED 0.9s | |
| [+] BUILDING...0.2s | |
| |=> //lib/jgit:ewah__download_bin... 0.0s (running genrule[0.0s]) | |
| |=> //lib:LICENSE-postgresql... 0.0s (running genrule[0.0s]) | |
| |=> //gerrit-war:webapp_assets... 0.0s (running genrule[0.0s]) | |
| |=> //lib/gwt:user__download_bin... 0.0s (running genrule[0.0s]) | |
| |=> //gerrit-extension-api:client... 0.2s (running javac[0.1s]) | |
| |=> //gerrit-util-ssl:ssl... 0.1s (running javac[0.1s]) | |
| |=> //lib/jgit:jgit__download_bin... 0.0s (running genrule[0.0s]) |
davido
/ gist:7813954
Created
December 5, 2013 21:10
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [2013-12-05 23:08:49,034] ERROR com.google.gerrit.server.index.ChangeBatchIndexer : Failed to index project All-Projects | |
| java.util.concurrent.ExecutionException: com.google.inject.ProvisionException: Guice provision errors: | |
| 1) Automatic ReviewDb only available in request scope | |
| at com.google.gerrit.server.util.ThreadLocalRequestContext$1.provideReviewDb(ThreadLocalRequestContext.java:70) | |
| while locating com.google.gerrit.reviewdb.server.ReviewDb | |
| 1 error | |
| at java.util.concurrent.FutureTask.report(FutureTask.java:122) | |
| at java.util.concurrent.FutureTask.get(FutureTask.java:188) |
davido
/ gist:7267297
Created
November 1, 2013 15:41
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| davido@linux-ucwl:~/projects/ia2/main/winaccessibility$ cd .. | |
| davido@linux-ucwl:~/projects/ia2/main$ find winaccessibility -name "*.idl" | |
| winaccessibility/source/UAccCOMIDL/AccessibleValue.idl | |
| winaccessibility/source/UAccCOMIDL/AccessibleText.idl | |
| winaccessibility/source/UAccCOMIDL/AccessibleKeyBinding.idl | |
| winaccessibility/source/UAccCOMIDL/IA2CommonTypes.idl | |
| winaccessibility/source/UAccCOMIDL/Charset.idl | |
| winaccessibility/source/UAccCOMIDL/AccessibleAction.idl | |
| winaccessibility/source/UAccCOMIDL/AccessibleStates.idl | |
| winaccessibility/source/UAccCOMIDL/AccessibleHyperlink.idl |