Skip to content

Instantly share code, notes, and snippets.

@davido
Created January 9, 2014 07:40
Show Gist options
  • Save davido/8330750 to your computer and use it in GitHub Desktop.
Save davido/8330750 to your computer and use it in GitHub Desktop.
Removing notes.load() function let all tests still pass
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/ApprovalsUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/ApprovalsUtil.java
index dd2c32b..b2d144b 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/ApprovalsUtil.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/ApprovalsUtil.java
@@ -113,7 +113,7 @@ public class ApprovalsUtil {
if (!migration.readPatchSetApprovals()) {
return getReviewers(db.patchSetApprovals().byChange(notes.getChangeId()));
}
- return notes.load().getReviewers();
+ return notes.getReviewers();
}
/**
@@ -256,7 +256,7 @@ public class ApprovalsUtil {
}
return result.build();
}
- return notes.load().getApprovals();
+ return notes.getApprovals();
}
public List<PatchSetApproval> byPatchSet(ReviewDb db, ChangeNotes notes,
@@ -264,7 +264,7 @@ public class ApprovalsUtil {
if (!migration.readPatchSetApprovals()) {
return sortApprovals(db.patchSetApprovals().byPatchSet(psId));
}
- return notes.load().getApprovals().get(psId);
+ return notes.getApprovals().get(psId);
}
public List<PatchSetApproval> byPatchSetUser(ReviewDb db,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment