Skip to content

Instantly share code, notes, and snippets.

@devarsht

devarsht/v10_range_diff

Created May 30, 2024 16:32
Show Gist options
  • Save devarsht/b446acee460b8c65fb577d06b7bbc1da to your computer and use it in GitHub Desktop.
Save devarsht/b446acee460b8c65fb577d06b7bbc1da to your computer and use it in GitHub Desktop.
Download ZIP
v10_range_diff.txt
Raw
v10_range_diff
1: 392da640fd05 ! 1: 4d7e0c418e13 media: dt-bindings: Add Imagination E5010 JPEG Encoder
@@ Commit message
Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
+ V10:
+ - No change
V9:
- No change
V8:
2: bc42c53ea7d1 ! 2: 1b44597c1dd5 media: imagination: Add E5010 JPEG Encoder driver
@@ Commit message
Co-developed-by: David Huang <d-huang@ti.com>
Signed-off-by: David Huang <d-huang@ti.com>
Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
+ Reviewed-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
---
+ V10:
+ - No change
+
V9:
- - Remove extra byte from header data
+ - Remove extra filler header data
V8:
- No change
@@ Commit message
https://lore.kernel.org/all/20240510083257.1274730-1-devarsht@ti.com/
V8:
https://lore.kernel.org/all/20240517172849.781910-1-devarsht@ti.com/
- Reviewed-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
## MAINTAINERS ##
@@ MAINTAINERS: F: drivers/auxdisplay/img-ascii-lcd.c
3: 0b27b382c907 ! 3: 4b85582c7fe2 media: v4l2-jpeg: Export reference quantization and huffman tables
@@ Commit message
Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
+ V10: Add description for new macros introduced in this patchset
V1->V9: No change (Patch introduced in V7)
## drivers/media/v4l2-core/v4l2-jpeg.c ##
@@ include/media/v4l2-jpeg.h
#define V4L2_JPEG_MAX_COMPONENTS 4
#define V4L2_JPEG_MAX_TABLES 4
++/*
++ * Prefixes used to generate huffman table class and destination identifiers as
++ * described below:
++ *
++ * V4L2_JPEG_LUM_HT | V4L2_JPEG_DC_HT : Prefix for Luma DC coefficients
++ * huffman table
++ * V4L2_JPEG_LUM_HT | V4L2_JPEG_AC_HT : Prefix for Luma AC coefficients
++ * huffman table
++ * V4L2_JPEG_CHR_HT | V4L2_JPEG_DC_HT : Prefix for Chroma DC coefficients
++ * huffman table
++ * V4L2_JPEG_CHR_HT | V4L2_JPEG_AC_HT : Prefix for Chroma AC coefficients
++ * huffman table
++ */
+#define V4L2_JPEG_LUM_HT 0x00
+#define V4L2_JPEG_CHR_HT 0x01
+#define V4L2_JPEG_DC_HT 0x00
+#define V4L2_JPEG_AC_HT 0x10
++
++/* Length of reference huffman tables as provided in Table K.3 of ITU-T.81 */
+#define V4L2_JPEG_REF_HT_AC_LEN 178
+#define V4L2_JPEG_REF_HT_DC_LEN 28
++
++/* Array size for 8x8 block of samples or DCT coefficient */
+#define V4L2_JPEG_PIXELS_IN_BLOCK 64
/**
4: abe86dfcd668 ! 4: 7d8f4a4f4789 media: imagination: Use exported tables from v4l2-jpeg core
@@ Commit message
Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
+ V10: No change
V1->V9 (No change, patch introduced in V7)
## drivers/media/platform/imagination/e5010-jpeg-enc.c ##
5: b2e615e84136 ! 5: 60de6087b2d7 media: verisilcon : Use exported tables from v4l2-jpeg for hantro codec
@@ Metadata
Author: Devarsh Thakkar <devarsht@ti.com>
## Commit message ##
- media: verisilcon : Use exported tables from v4l2-jpeg for hantro codec
+ media: verisilicon : Use exported tables from v4l2-jpeg for hantro codec
Use v4l2-jpeg core API to import reference quantization and huffman tables
used for JPEG Encoding.
@@ Commit message
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
---
+ V10: Fix typo in commit message title
V9: No change
V8: Add Reviewed-by and Acked-by tags
V1->V6 (No change, patch introduced in V7)
6: 4b44aed8564f ! 6: 6c04888ef735 math.h: Add macros for rounding to closest value
@@ Commit message
[1]:
https://elixir.bootlin.com/linux/v6.8.9/source/drivers/gpu/ipu-v3/ipu-image-convert.c#L480
+ V10:
+ - Update example comment to fix formatting issues as observed with html docs
+
V9:
- No change
@@ include/linux/math.h
+/**
+ * round_closest_up - round closest to be multiple of specified value (which is
+ * power of 2) with preference to rounding up
-+
+ * @x: the value to round
+ * @y: multiple to round closest to (must be a power of 2)
+ *
@@ include/linux/math.h
+ * roundclosest().
+ *
+ * Examples :
-+ * round_closest_up(17, 4) = 16
-+ * round_closest_up(15, 4) = 16
-+ * round_closest_up(14, 4) = 16
++ *
++ * round_closest_up(17, 4) = 16
++ *
++ * round_closest_up(15, 4) = 16
++ *
++ * round_closest_up(14, 4) = 16
+ */
+#define round_closest_up(x, y) round_down((x) + (y) / 2, (y))
+
+/**
+ * round_closest_down - round closest to be multiple of specified value (which
+ * is power of 2) with preference to rounding down
-+ *
+ * @x: the value to round
+ * @y: multiple to round closest to (must be a power of 2)
+ *
@@ include/linux/math.h
+ * To perform arbitrary rounding to closest value (not multiple of 2), use
+ * roundclosest().
+ *
-+ * Examples :
-+ * round_closest_down(17, 4) = 16
-+ * round_closest_down(15, 4) = 16
-+ * round_closest_down(14, 4) = 12
++ * Examples:
++ *
++ * round_closest_down(17, 4) = 16
++ *
++ * round_closest_down(15, 4) = 16
++ *
++ * round_closest_down(14, 4) = 12
+ */
+#define round_closest_down(x, y) round_up((x) - (y) / 2, (y))
+
@@ include/linux/math.h
+ * using the faster round_closest_up() or round_closest_down().
+ *
+ * Examples :
-+ * roundclosest(21, 5) = 20
-+ * roundclosest(19, 5) = 20
-+ * roundclosest(17, 5) = 15
++ *
++ * roundclosest(21, 5) = 20
++ *
++ * roundclosest(19, 5) = 20
++ *
++ * roundclosest(17, 5) = 15
+ */
+#define roundclosest(x, y) rounddown((x) + (y) / 2, (y))
+
-: ------------ > 7: dfae32ad9207 Documentation: core-api: Add math.h macros and functions
7: 220a46d03e4a ! 8: 6a68af7198da lib: add basic KUnit test for lib/math
@@ Commit message
Signed-off-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: David Gow <davidgow@google.com>
- [devarsht: Rebase to 6.9, remove kernel.h and change license to GPL]
+ [devarsht: Rebase to 6.9, remove kernel.h, update Kconfig and change license to GPL]
+ Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
+ Changes since v9:
+ * Added Kconfig dependency for KUNIT
+
Changes since v8:
* Remove unrequired header file linux/kernel.h
@@ Commit message
* related: commit 1f0e943df68a ("Documentation: kunit: provide guidance
for testing many inputs") was merged explaining the patterns shown here.
* there's an in-flight patch to update it for parameterized testing.
- Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
## lib/math/Kconfig ##
@@ lib/math/Kconfig: config PRIME_NUMBERS
@@ lib/math/Kconfig: config PRIME_NUMBERS
+
+config MATH_KUNIT_TEST
+ tristate "KUnit test for math helper functions"
++ depends on KUNIT
++ default KUNIT_ALL_TESTS
++
+ help
+ This builds unit test for math helper functions as defined in lib/math
+ and math.h.
8: 63243d31a3bf ! 9: d40193b2ed26 lib: math_kunit: Add tests for new macros related to rounding to nearest value
@@ Commit message
Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
- V1->V9 (No change, patch introduced in V8)
+ V1->V10 (No change, patch introduced in V8)
## lib/math/math_kunit.c ##
@@ lib/math/math_kunit.c: static void round_down_test(struct kunit *test)
9: b8fd83252173 ! 10: f8d6211fec4c media: imagination: Round to closest multiple for cropping region
@@ Commit message
Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
- V9: No change
- V8: Update commit message with specification reference
+ V10: No change
+ V9: No change
+ V8: Update commit message with specification reference
V1->V7 (No change, patch introduced in V7)
## drivers/media/platform/imagination/e5010-jpeg-enc.c ##
-: ------------ > 11: 16238ee6a33e gpu: ipu-v3: Use generic macro for rounding closest to specified value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment