Awesome use of control characters to clear the terminal and reset the cursor postion. I was never doing that stuff in these classes. My programs always just printed out stuff over and over and over. So, pro stuff right there!
Bring the main method up so it is the first method to appear in the file.
Make more methods to encapsulate different parts of the main method. Think of the main method more as a table of contents than paragraphs of code explaining the program.
In your ProfileController you have a strange type for booleans.
You should prefer to use lower-case boolean when you make a
single boolean variable. You should only use upper-case Boolean
when you’re identifying the type of something in a generic class
between diamonds <Boolean>.
Boolean found = false;
Boolean endFound = false;
res/xml/file_paths.xml
<?xml version="1.0" encoding="utf-8"?>
<paths xmlns:android="http://schemas.android.com/apk/res/android">
<external-path name="my_images" path="Android/data/com.example.moonmayor.firebasephotos/files/Pictures" />
</paths>AndroidManifest.xml
| # Replace github usernames once with all students in class | |
| # force the class to all have the same name for their repos per assignment | |
| # pass the name of the repo to `d1cloner` to clone it for all the class. | |
| # This makes one directory for the assignment, with subdirectories of | |
| # students names with each students cloned repo. Make sure the students | |
| # merge their changes back to master so you have easy access. | |
| # | |
| # d1cloner data-structures-and-algorithms | |
| function d1cloner() { | |
| mkdir $1 |
Total points: 10/10
Overall nice work. Good tests! Happy to see you writing code to verify your understanding of BCrypt.
You should add the loggedin property to the session when someone successfully signs
up for a new account. Right now you redirect someone to the "you logged in" page when
they sign up, but they're not really logged in. Accessing the secret page causes the
app to crash because there's no loggedin property set in the session.
Web applications are complex. When you build one where should you begin? The trick is to start with something tangible that you can observe and manipulate and constantly improve in small steps from there. Do not become over-zealous and try to build too many things at once. Like stacking rocks along a river you should make sure a new rock balances on all others without your hands before trying to stack the next rock.
When your building a web application start with your server. Configure your
Total points: 2/10
-1 point: missing Main.java file described in lab writeup. -1 point: zero tests -2 points: missing overall interactive input/output program. -2 points: CaesarShiftCipher not implemented -2 points: KeywordCipher not implemented
There should be a seperation between the objects you create and a program that
Total points: 8/10
-1 point: missing Main.java file described in lab writeup.
-1 point: zero tests
There should be a seperation between the objects you create and a program that
uses those objects. Each of the cipher files should just have code that encodes
and decodes text. The Main.java should be there to accomplish the task of
being a program that collects user input, creates cipher objects and
Total points: 8/10.
-1 point class inheritance doesn't override encode and decode.
-1 point no real tests implemented.
Nice project structure especially with separating out the src and test
directories. It's true that most Java projects do their structure like that,
but I just haven't bothered with it yet as I've been using the auto-generated
IntelliJ code. Eventually we'll get to some tooling that will set things like
this up correctly automatically.
Total: 3 points. None of the ciphers are implemented, class properties and methods placed inside classes incorrectly and non-functionally, no tests.
Hm, I've never seen InaccessibleObjectException before. Where did you get the
idea to use this? Also, I don't see anything inside the try block that would
possible cause an exception. Checking an int with == and printing things are
basically impossible to fail.
I looked it up and it looks like a Java 9 thing. You'll have to show me how it