Skip to content

Instantly share code, notes, and snippets.

@geluso

geluso/05-cipher-grading-d.md

Created July 18, 2018 19:53
Show Gist options
  • Save geluso/900a412fce5898045552cd6ce41c2490 to your computer and use it in GitHub Desktop.
Save geluso/900a412fce5898045552cd6ce41c2490 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
05-cipher-grading-d.md

Total points: 2/10

Overall Structure

-1 point: missing Main.java file described in lab writeup. -1 point: zero tests -2 points: missing overall interactive input/output program. -2 points: CaesarShiftCipher not implemented -2 points: KeywordCipher not implemented

There should be a seperation between the objects you create and a program that uses those objects. Each of the cipher files should just have code that encodes and decodes text. The Main.java should be there to accomplish the task of being a program that collects user input, creates cipher objects and manipulates them.

Hey, cool use of Character.isLetter(payload.charAt(i)! Our reference solution has a .indexOf check against a manually-defined alphabet string. I did not know Character.isLetter was a function!

Great job extending the ciphers and overriding the encode and decode methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment