Skip to content

Instantly share code, notes, and snippets.

View janimattiellonen's full-sized avatar

Janimatti Ellonen janimattiellonen

View GitHub Profile
@janimattiellonen
janimattiellonen / gist:115777ee8687ebb47b5c
Created March 2, 2016 09:03
A list of things you could check yourself before anyone else reviews your code
A list of things you could check yourself before anyone else reviews your code:
- all files must have an empty newline at OEF (use .editorconfig for that)
- check for proper indentation (smarty indentations are often wrong after copy-paste)
- remove unnecessary newlines
- check that docblocks are valid and up-to-date
- remove unnecessary if ($foo == true). if ($foo) should be enough
- check that no merge conflict markers (>>>>>>>) are left behind
- check for unused variables
- extract long ifs to own method if possible