Skip to content

Instantly share code, notes, and snippets.

@janimattiellonen
Created March 2, 2016 09:03
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save janimattiellonen/115777ee8687ebb47b5c to your computer and use it in GitHub Desktop.
Save janimattiellonen/115777ee8687ebb47b5c to your computer and use it in GitHub Desktop.
A list of things you could check yourself before anyone else reviews your code
A list of things you could check yourself before anyone else reviews your code:
- all files must have an empty newline at OEF (use .editorconfig for that)
- check for proper indentation (smarty indentations are often wrong after copy-paste)
- remove unnecessary newlines
- check that docblocks are valid and up-to-date
- remove unnecessary if ($foo == true). if ($foo) should be enough
- check that no merge conflict markers (>>>>>>>) are left behind
- check for unused variables
- extract long ifs to own method if possible
- prefer '' over ""
- remove commented code
- .prop('disabled', true) instead of .attr('disabled', 'disabled')
- run unit tests
- run acceptance tests
- run jshint
- run severity tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment