Skip to content

Instantly share code, notes, and snippets.

@jinder1s
Created January 10, 2022 20:47
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save jinder1s/72d2bc3ce41f28dcf767c1ef3478cf19 to your computer and use it in GitHub Desktop.
Save jinder1s/72d2bc3ce41f28dcf767c1ef3478cf19 to your computer and use it in GitHub Desktop.
- What is your thought on the scope of event_type in openedx_events/signal.py

https://github.com/eduNEXT/openedx-events/blob/main/openedx_events/learning/signals.py#L31

  • Could a single attrs class have multiple event types?
  • One of the reasons behind implementation of the attrs class in openedx_events was ability to reuse in different contexts. As such, we are planning on using those attrs classes to specify events for kafka.

    Should we be using the signal classes in signal.py or are the classes in signal.py specifically for django signals?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment