With v0.121.2:
| EN
-------------------+-----
Pages | 8
Paginator pages | 0
Non-page files | 0
Static files | 1
Processed images | 0
Aliases | 0
Sitemaps | 1
Cleaned | 0
With PR #11830:
| EN
-------------------+-----
Pages | 10
Paginator pages | 0
Non-page files | 0
Static files | 0
Processed images | 0
Aliases | 0
Cleaned | 0
On a few occassions I was not able to kill the server with Ctrl+C on the first try, and after several times it stopped with this message:
Error: context deadline exceeded
I've a resources.GetRemote call that's currently returning a bad request (400) error, and at the moment that is expected (the provider site is having issues). I expected the hugo server to terminate after throwing the error, but I have to Ctrl+C to stop the server. With v0.121.2 the server terminates immediately. This is an intermittent problem, and I have not been able to create a mimimal failing example yet.
✔️ Regarding gohugoio/hugo#11453...
I have no problem with the implementation, but I mistakenly thought it was limited to de-duplicating processed images. Of all the changes in this PR, I suspect this one will generate the most noise.
To get out in front the change, I will add "portability" examples to the docs for both link and image render hooks, both of which are required for multilingual sites with resources shared between languages. The need for an image render hook is obvious, but a link render hook is also required (e.g., link to PDF that is a page resource).
Regarding existing render hooks in the wild... most of what I've seen doesn't focus on portability. Many, but not all, of the image render hooks that I've seen already capture the image as a resource, but that's not the case for the vast majority of link render hooks. Theme authors may need to update their hooks, and site authors may need to either create or override existing hooks.