リファクタリング https://twitter.com/yuki_python/status/1192132849077342208/photo/1

refact.md

Original

function nativeApLoginStart() {
  var c = installVersionCheck(false);
  var d = c[1];
  var a = c[0];
  if (d === "" || a === "") {
    var f = $("#browserType").val();
    var e = $("#osType").val();
    if ("Win" === e && "IE" === f) {
      $("#ieInstallDialog").dialog("open");
    } else {
      if ("Win" === e && "Edge" === f) {
        $("#edgeInstallDialog").dialog("open");
      } else {
        if ("Win" === e && "Chrome" === f) {
          $("#chromeInstallDialog").dialog("open");
        } else {
          if ("Win" === e && "Firefox" === f) {
            $("#firefoxInstallDialog").dialog("open");
          } else {
            if ("Mac" === e && "Safari" === f) {
              $("#safariInstallDialog").dialog("open");
            } else {
              if ("Mac" === e && "Chrome" === f) {
                $("#chromeInstallDialog").dialog("open");
              } else {
                if ("Mac" === e && "Firefox" === f) {
                  $("#firefoxInstallDialog").dialog("open");
                }
              }
            }
          }
        }
      }
    }
    return;
  }
}

My refactoring

const nativeApLoginStart = () => {
  const [what, theFuck] = installVersionCheck(false);
  if (what === "" || theFuck === "") {
    const targetPlatform = document.getElementById("#osType").value;
    const targetBrowser = document.getElementById("#browserType").value;
    [
      { platform: "Win", browser: "IE", alias: "ie" },
      { platform: "Win", browser: "Edge", alias: "edge" },
      { platform: "Win", browser: "Chrome", alias: "chrome" },
      { platform: "Win", browser: "Firefox", alias: "firefox" },
      { platform: "Mac", browser: "Safari", alias: "safari" },
      { platform: "Mac", browser: "Chrome", alias: "chrome" },
      { platform: "Mac", browser: "Firefox", alias: "firefox" }
    ].forEach(([platform, browser, alias]) => {
      if (targetPlatform === platform && targetBrowser === browser)
        $(document.getElementById(`${alias}InstallDialog`)).dialog("open");
    });
  }
};