Some todos I can think off: | |
- [ ] Make Modal prettier and accessible using Artur's research | |
- [ ] Convert `GoogleDrive` to adhere to `Dummy`'s format, so it'sare compatible with the new Modal | |
- [ ] Convert `DragDrop` to adhere to `Dummy`'s format, so it'sare compatible with the new Modal | |
- [ ] Make `ProgressBar` work with the new Modal | |
- [ ] Rename FakeModal to Modal, deprecating our old one | |
- [ ] Make the Modal look like Harry's sketchup | |
- [ ] ? |
- Make sure modal renders under one dom node?
✅
- Think about whether it’s better to use :after on body or a separate div for dimming effect? I guess it’s better not to touch body for React future reasons?
makes sense (not touching body) (but saying this with little confidence as I'm a bit out my comfort zone)
- Should Modal be aware of progressbars and spinners, is it a separate method, not prepareTarget?
The way I thought of it, we'd have if (caller.type === 'acquire') {this} if (caller.type === 'progress') {that}
in the prepareTarget
Think about whether it’s better to use :after on body or a separate div for dimming effect? I guess it’s better not to touch body for React future reasons?
I haven't heard about using :after on the body as the approach for an overlay dimming effect, but I think that would be problematic since the modal lives within the body
tag as well. It would dim over every single thing within the body. I think the approach uploadcare
uses is to put the modal within the overlay element itself, so:
<div class="Uppy-overlay">
<div class="Uppy-modal">
....
</div>
</div>
Then that could all be within a React component with a shouldComponentUpdate()
that always returns false, I'd say?
The way I thought of it, we'd have if (caller.type === 'acquire') {this} if (caller.type === 'progress') {that} in the prepareTarget
👍modal within the overlay element itself, Then that could all be within a React component with a shouldComponentUpdate() that always returns false
👍
Great.
Some thoughts:
:after
onbody
or a separate div for dimming effect? I guess it’s better not to touch body for React future reasons?prepareTarget
?