Last active
February 21, 2016 15:16
-
-
Save kvz/e9f5b113f07763e49161 to your computer and use it in GitHub Desktop.
todays-modal-todos.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some todos I can think off: | |
- [ ] Make Modal prettier and accessible using Artur's research | |
- [ ] Convert `GoogleDrive` to adhere to `Dummy`'s format, so it'sare compatible with the new Modal | |
- [ ] Convert `DragDrop` to adhere to `Dummy`'s format, so it'sare compatible with the new Modal | |
- [ ] Make `ProgressBar` work with the new Modal | |
- [ ] Rename FakeModal to Modal, deprecating our old one | |
- [ ] Make the Modal look like Harry's sketchup | |
- [ ] ? |
The way I thought of it, we'd have if (caller.type === 'acquire') {this} if (caller.type === 'progress') {that} in the prepareTarget
👍modal within the overlay element itself, Then that could all be within a React component with a shouldComponentUpdate() that always returns false
👍
Great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I haven't heard about using :after on the body as the approach for an overlay dimming effect, but I think that would be problematic since the modal lives within the
body
tag as well. It would dim over every single thing within the body. I think the approachuploadcare
uses is to put the modal within the overlay element itself, so:Then that could all be within a React component with a
shouldComponentUpdate()
that always returns false, I'd say?