Skip to content

Instantly share code, notes, and snippets.

@kypflug
Last active May 26, 2016 17:09
  • Star 1 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
Star You must be signed in to star a gist
Save kypflug/f486046ba87076088742212316d0df7d to your computer and use it in GitHub Desktop.
Making a request for a JSON resource with XHR
var xhr = new XMLHttpRequest();
xhr.open('GET', url);
xhr.responseType = 'json';
xhr.onload = function() {
console.log(xhr.response);
};
xhr.onerror = function() {
console.log("Houston, we've got a problem.");
};
xhr.send();
@tabatkins
Copy link

It was a trivial example. Now do two fetches, with a "both successful" callback and a "something failed" callback.

The point isn't necessarily that it's less code (tho it is, as you conceded), it's that the entire model is simpler.

@WebReflection
Copy link

WebReflection commented May 25, 2016

Simpler, sure ... and now abort a fetch ... or show me a download/upload progress .... uh wait ....

My point is that LOC as first reason to ditch anything is a very poor argument.

The two APIs do different things. Comparing them to sell Fetch is silly because fetch lacks of few things already very simple through XHR and vice-versa, XHR doesn't expose streams so it's inferior.

These are informative points. Showing extra empty lines to demonstrate how much less LOC we have now?

Meh ¯\_(ツ)_/¯

@felquis
Copy link

felquis commented May 26, 2016

Meh ¯\_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment