Create a gist now

Instantly share code, notes, and snippets.

What would you like to do?
Golang landmines

There are three easy to make mistakes in go. I present them here in the way they are often found in the wild, not in the way that is easiest to understand.

All three of these mistakes have been made in Kubernetes code, getting past code review at least once each that I know of.

  1. Loop variables are scoped outside the loop.

What do these lines do? Make predictions and then scroll down.

func print(pi *int) { fmt.Println(*pi) }

for i := 0; i < 10; i++ {
  defer fmt.Println(i)
  defer func(){ fmt.Println(i) }()
  defer func(i int){ fmt.Println(i) }(i)
  defer print(&i)
  go fmt.Println(i)
  go func(){ fmt.Println(i) }()
}

Answers:

func print(pi *int) { fmt.Println(*pi) }

for i := 0; i < 10; i++ {
  defer fmt.Println(i) // OK; prints 9 ... 0
  defer func(){ fmt.Println(i) }() // WRONG; prints "10" 10 times
  defer func(i int){ fmt.Println(i) }(i) // OK
  defer print(&i) // WRONG; prints "10" 10 times
  go fmt.Println(i) // OK; prints 0 ... 9 in unpredictable order
  go func(){ fmt.Println(i) }() // WRONG; totally unpredictable.
}

for key, value := range myMap {
  // Same for key & value as i!
}

Everyone expects these values to be scoped inside the loop, but go reuses the same memory location for every iteration. This means that you must never let the address of key, value, or i above escape the loop. An anonymous func() { /* do something with i */ } (a "closure") is a subtle way of taking a variable's address

  1. Nil interface is not the same as having a nil pointer in the interface.
type Cat interface {
  Meow()
}

type Tabby struct {}
func (*Tabby) Meow() { fmt.Println("meow") }

func GetACat() Cat {
  var myTabby *Tabby = nil
  // Oops, we forgot to set myTabby to a real value
  return myTabby
}

func TestGetACat(t *testing.T) {
  if GetACat() == nil {
    t.Errorf("Forgot to return a real cat!")
  }
}

Guess what? The above test will NOT detect the nil pointer! This is because the interface serves as a pointer, so GetACat effectively returns a pointer to a nil pointer. Never do the thing that GetACat does, and you (and your coworkers) will be much happier. It is very easy to do this with error values. http://golang.org/doc/faq#nil_error

  1. Shadowing considered harmful to your sanity.
var ErrDidNotWork = errors.New("did not work")

func DoTheThing(reallyDoIt bool) (err error) {
  if reallyDoIt {
    result, err := tryTheThing()
    if err != nil || result != "it worked" {
      err = ErrDidNotWork
    }
  }
  return err
}

The above function will always return a nil error, because the inner err variable "shadows" the function scope variable. Adding a var result string and not using := would fix this.

gholt commented Mar 17, 2016

This is a fun one too; at least for me, it wasn't immediately obvious:

package main

import "fmt"

type T struct {
    ID int
}

func (t *T) PrintID() {
    fmt.Println(t.ID)
}

func F1() {
    ts := []T{{1}, {2}, {3}}
    for _, t := range ts {
        defer t.PrintID()
    }
}

func F2() {
    ts := []*T{&T{1}, &T{2}, &T{3}}
    for _, t := range ts {
        defer t.PrintID()
    }
}

func main() {
    fmt.Println("F1()")
    F1()
    fmt.Println()
    fmt.Println("F2()")
    F2()
}

@gholt:
That is interesting. Could you please explain (or share any link that explains) why we get the output we do with your code snippet? A go rookie here trying to learn. Thank you!

For posterity, here's that code in the Playground: http://play.golang.org/p/51kKuyjox6

@helpmelearn: It's because t.PrintID() is equivalent to

f := (*T).PrintID
f(t)

or, more compactly

(*T).PrintID(t)

which is similar to the first case in the original post, "defer fmt.Println(i) // OK; prints 9 ... 0". (Here's the new code in the Playground.)

In other words, a method call is equivalent to a regular function call with the receiver passed as an argument. Since the argument is evaluated at the time the defer statement is invoked, you get different values of t each time.

See Method expressions and Defer statements in the spec.

The indentation is off, which causes the numbering to break. Can you fix that?

How to leak memory:

ch := make(chan int)
go func() {
    for {
        ch <- 0
    }
}()
for x := range ch {
     break
}
ogier commented Sep 22, 2016

append() might not do what you think it does.

empty := make([]int, 0, 1)
a := append(empty, 100)
b := append(empty, 200)
fmt.Printf("a = %v, b = %v\n", a, b)

Prints a = [200], b = [200]. https://play.golang.org/p/5UJKtPu8uZ

sbogacz commented Sep 22, 2016

@gholt In your example, I think the issue is just having the pointer receiver on the PrintID() method, right?

mimoo commented Mar 30, 2017 edited

shadowing in section 3 still seems to work, whereas this says that it was fixed. Isn't it weird?

I see two other issues that might come up:

  1. using PutVarint when you want to use PutUint (you will get weird results)
  2. using a 0 modulus in a math function like big.Exp (you will get an infinite loop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment