Front-end Code Review Checklist
- Does the code work?
- Description of the project status is included.
- Code is easy to understand.
- Code is written following the relevant coding standards/guidelines (React in our case).
- Code is in sync with existing code patterns/technologies.
- DRY. Is the same code duplicated anywhere?
- Can the code be easily tested (don't forget about React components)?
- Are functions/classes/components reasonably small (not too big)?
- Event listeners are removed at teardown.
- Naming conventions are followed for variables, file names, translations.
- Removed unused packages from NPM.
- Separation of Concerns followed.
- No hardcoded values; use constants instead.
- Avoid nested if/else blocks.
- No commented-out code.
- No unnecessary comments: comments that describe the how.
- Add necessary comments where needed. Necessary comments are comments that describe the why.
React code review
- Use ES6 features.
- Use fat arrow instead of var that = this. Be consistent in your usage of arrow function.
- Use spread/rest operator.
- Use default values.
- Use const over let (avoid var).
- Use import and export.
- Use template literals.
- Use destructuring assignment for arrays and objects.
- Use Promises or Async/Await. Rejection is handled.
- Do components have defined propTypes?
- Keep components small.
- Functional components for components that don't use state.
- No api calls in containers, delegate to Sagas
- No state updates in loop.
- No useless constructors.
- Minimize logic in the render method.
- Don’t use mixins; prefer HOC and composition.
- Use lodash/ramda functions instead of implementing yourself.
- Is Immutable.js being used correctly?
- Is any nice/useful library used which we didn't know about before?
CSS/CSS in JS
- Code has no linter errors or warnings.
- No console.logs.
- Consistent naming conventions are used (BEM, OOCSS, SMACSS, etc.).
- CSS selectors are only as specific as they need to be; grouped logically.
- Is any 'CSS in JS' library being used?
- Use Hex color codes #000 unless using rgba().
- Avoid absolute positioning.
- Use flexbox.
- Avoid !important.
- Do not animate width, height, top, left and others. Use transform instead.
- Use same units consistently throughout the project.
- Avoid inline styles.
- Tests are readable, maintainable, trustworthy.
- Test names (describe, it) are concise, explicit, descriptive.
- Avoid logic in your tests.
- Don't test multiple concerns in the same test.
- Cover the general case and the edge cases.
- Test the behavior, not the internal implementation.
- Use a mock to simulate/stub complex class structure, methods or async functions.
- Commits are small and divided into logical parts.
- Commits messages are small and understandable.
- Use branches for new features.
- Make sure no dist files, editor/IDE files, etc are checked in. There should be a .gitignore for that.