Created

Embed URL

HTTPS clone URL

SSH clone URL

You can clone with HTTPS or SSH.

Download Gist

XMLHttpRequest wrapped into a promise

View gist:3099268
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
function xhr(options) {
var deferred = Q.defer(),
req = new XMLHttpRequest();
 
req.open(options.method || 'GET', options.url, true);
 
// Set request headers if provided.
Object.keys(options.headers || {}).forEach(function (key) {
req.setRequestHeader(key, options.headers[key]);
});
 
req.onreadystatechange = function(e) {
if(req.readyState !== 4) {
return;
}
 
if([200,304].indexOf(req.status) === -1) {
deferred.reject(new Error('Server responded with a status of ' + req.status));
} else {
deferred.resolve(e.target.result);
}
};
 
req.send(options.data || void 0);
 
return deferred.promise;
}

You should reject with Error instances, just like you throw with them :)

Owner

Good point, but isn't this something Q should handle internally?

You mean e.target.response not e.target.result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.